FuryShark Posted June 26, 2018 Posted June 26, 2018 (edited) What it does: Buys and sells lots of F2P items. Logs buy price, sell price, margin & Buy limit. It does NOT flip for you afterwards! How to use: Start the script at the GE with coins in your inventory. Make sure the first GE slot (top left) is empty. To view the margins open OSBot Logger - Settings > Toggle Logger. Supported items: Spoiler Gems Spoiler Uncut diamond, Uncut sapphire, Uncut emerald, Uncut ruby, Diamond, Sapphire, Emerald, Ruby Logs Spoiler Logs, Oak logs, Willow logs, Maple logs, Yew logs Food Spoiler Anchovy pizza, Anchovies, Apple pie, Beer, Cake, Chocolate cake, Lobster, Plain pizza, Raw anchovies, Raw lobster, Raw salmon, Raw shrimp, Raw swordfish, Raw tuna, Salmon, Shrimp, Stew, Swordfish, Trout, Tuna Ranged equipment Spoiler Bronze arrow, Iron arrow, Steel arrow, Mithril arrow, Adamant arrow, Maple longbow, Maple shortbow, Green d'hide body, Green d'hide chaps, Green d'hide vamb Runes Spoiler Chaos rune, Cosmic rune, Death rune, Nature rune, Pure essence, Rune essence Ores & Bars Spoiler Adamantite bar, Adamantite ore, Bronze bar, Clay, Coal, Copper ore, Gold bar, Gold ore, Iron bar, Iron ore, Mithril bar, Mithril ore, Runite bar, Runite ore, Silver bar, Silver ore, Soft clay, Steel bar, Tin ore Rune equipment Spoiler Rune 2h sword, Rune axe, Rune battleaxe, Rune chainbody, Rune dagger, Rune full helm, Rune kiteshield, Rune longsword, Rune mace, Rune med helm, Rune pickaxe, Rune platebody, Rune platelegs, Rune plateskirt, Rune Scimitar, Rune sword, Rune warhammer Misc Spoiler Ball of wool, Big bones, Bones, Cowhide, Fishing bait, Gold amulet, Gold amulet (u), Gold ring, Grapes, Hard leather, Jug of water, Jug of wine, Leather, Plank, Steel nails, Vial of water, Wine of zamorak Download Last update: 26/06/2018 Feel free to suggest f2p items to add! Changelog: Spoiler Nothing yet:p Edited July 1, 2018 by FuryShark
unicornpoorn Posted June 26, 2018 Posted June 26, 2018 death runes and adamant arrows would be decent to add
FuryShark Posted June 26, 2018 Author Posted June 26, 2018 6 minutes ago, unicornpoorn said: death runes and adamant arrows would be decent to add Look at the list of supported items, its there
unicornpoorn Posted June 26, 2018 Posted June 26, 2018 1 minute ago, FuryShark said: Look at the list of supported items, its there Ow oops sorry didn't see the reveal hidden option
Team Cape Posted June 26, 2018 Posted June 26, 2018 (edited) Interesting, just a few tips though: 1) You might want to pull prices from online. To my knowledge, RSBuddy's API is down, but there are likely other places you can use. 2) There is a lot of repeated code here that could be condensed into just a few loops. I'd recommend looking into arrays, enums, and for loops. Good idea for the script! Edited June 26, 2018 by Team Cape 1
dogetrix Posted June 27, 2018 Posted June 27, 2018 Please just have 1 method to buy stuff and pass a string and min/max values in lol. Why on earth would you copy paste the same thing into different methods when you could just have 1? Also, you should just create one method for the buyXSet. Use an array instead of 8 different variables and pass the number of the set you're currently checking into one method that separates them out and buys the appropriate item, instead of making 8 different methods with basically the same contents. Makes it much more concise and clear, and it's easier to expand into different areas of items. 1
spanishguy Posted June 27, 2018 Posted June 27, 2018 Cool script, so this buys from a list of custom items the one with the most profit based on profit margin? I would suggest adding custom items as well. Gratz
