Jump to content

Fury's F2P Margins Checker [Over 100 Items]


FuryShark

Recommended Posts

MluDfez.png

What it does:
Buys and sells lots of F2P items.
Logs buy price, sell price, margin & Buy limit.
It does NOT flip for you afterwards!

How to use:
Start the script at the GE with coins in your inventory.
Make sure the first GE slot (top left) is empty.
To view the margins open OSBot Logger - Settings > Toggle Logger.

ofsPRBo.png

Supported items:
 

  Reveal hidden contents

Download
Last update: 26/06/2018

Feel free to suggest f2p items to add!

 

Changelog:

  Reveal hidden contents

 

Edited by FuryShark
Link to comment
Share on other sites

  • FuryShark changed the title to Fury's F2P Margins [Over 100 Items]

Interesting, just a few tips though:

1) You might want to pull prices from online. To my knowledge, RSBuddy's API is down, but there are likely other places you can use.

2) There is a lot of repeated code here that could be condensed into just a few loops. I'd recommend looking into arrays, enums, and for loops.

Good idea for the script! :D 

Edited by Team Cape
  • Heart 1
Link to comment
Share on other sites

Please just have 1 method to buy stuff and pass a string and min/max values in lol. Why on earth would you copy paste the same thing into different methods when you could just have 1?

Also, you should just create one method for the buyXSet. Use an array instead of 8 different variables and pass the number of the set you're currently checking into one method that separates them out and buys the appropriate item, instead of making 8 different methods with basically the same contents. Makes it much more concise and clear, and it's easier to expand into different areas of items.

  • Like 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...