Birdhouse-Farm-Sleep

[Proton]

31 minutes ago, DylanSRT said:

I'm working on fixing all of your issues . I tried to make it allow too much freedom, instead of just putting hard fails when people run out of certain supplies. I'm going to go back to not allowing certain things. Also, I think most of the new issues with BH runs were caused by the camera zoom not being fully out (changed this with farming). This helps during farming, so I will instead make it zoom in and out when it is switching between farm/bh. 

I'm going to run bh/farm on all of my botfarm accounts today. Before I was doing BH only. Hopefully, I can catch a whole bunch of different errors. 

There's no reason for it to have suddenly stopped working on Tuesday because the last update I made was Sunday. I've found that using the same client for a while can start to cause weird things to happen on Mirror Mode. Try restarting the client once in a while.

And yes I am back lol, I am so busy at work during the week at this time of the year. Weekends are devoted to OSbot.

 

 

This is most likely due to the banking issue with mirror mode. Start the script on the main bank tab.

Try downloading the 2.5.59 dev build. Fixes banking issues

This was on 2.5.59

[DylanSRT]

@dabswax @RoundBox @john55 @Proton @lolwutnow

Hey guys,

Thanks for all the feedback. The majority of the issues seem to be caused by the client, but I made a lot of other improvements today as well. As of now, make sure to use 2.5.59 [DEV BUILD]. This didn't fix the issues with bankholders in Mirror Mode so be careful with that still.

Some of the changes:

-Major Improvements to Banking & Travel - I had to reduce the freedom of the user to make it more robust for long periods. There won't be any missing items anymore, but running out of any required items in your bank will make you stand at the bank till you log out. However, it will still turn off herb runs automatically if you have no more usable seeds in the bank. 

-Camera zoom changes between BH and Farm runs - The zoom for farming was causing some issues with BH run pathing
-Fixed Issues with Planting Flower Seeds

-Bot only withdraws 40 seeds at a time now

-Increased area of the farming patches so it doesn't stop if you accidentally click on a tree or something nearby

 -Added a lot more info to the error logger and you can now generate an error report at any time by pressing F12 (Please provide this info when reporting errors):

-Will continue to make more updates over the weekend

-These changes will be in place when you see V2.2 on start-up (24 hours max)

[dabswax]

@DylanSRT everything seems to be fixed as far as I can tell except for the excessive teleporting (not sure if I mentioned oops). For me at least.

but, it seems a solid 70%+of the time when it uses CW tele for ROD, im not sure why but, it will try and click the bank, and then tele again, and does this till it uses all 8 charges, or it reaches the bank before it clicks tele. Very Very obvious.

All the logger shows is.

 

[INFO][Bot #1][09/29 05:40:48 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/29 05:41:39 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/29 05:42:21 PM]: Terminating script Birdhouse-Farm-Sleep...
[WARN][Bot #1][09/29 05:42:26 PM]: Event executor is taking too long to suspend; terminating now...
[INFO][Bot #1][09/29 05:42:26 PM]: Script Birdhouse-Farm-Sleep has exited!

Edited September 29, 2019 by dabswax

[DylanSRT]

33 minutes ago, dabswax said:

@DylanSRT everything seems to be fixed as far as I can tell except for the excessive teleporting (not sure if I mentioned oops). For me at least.

but, it seems a solid 70%+of the time when it uses CW tele for ROD, im not sure why but, it will try and click the bank, and then tele again, and does this till it uses all 8 charges, or it reaches the bank before it clicks tele. Very Very obvious.

All the logger shows is.

 

[INFO][Bot #1][09/29 05:40:48 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/29 05:41:39 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/29 05:42:21 PM]: Terminating script Birdhouse-Farm-Sleep...
[WARN][Bot #1][09/29 05:42:26 PM]: Event executor is taking too long to suspend; terminating now...
[INFO][Bot #1][09/29 05:42:26 PM]: Script Birdhouse-Farm-Sleep has exited!

Okay, so I know exactly what bit of code is causing this. But it has never happened to me which is weird. I'm going to go analytical on this one because I am confused.

So this is the bit of script that handles the banking (or rather bank opening). The goal of this method is to get a bank open, in which case it returns true. 

private boolean bankingHandler() throws InterruptedException {
//So first it tries to simply open a bank nearby. Normally, if you are in castle wars, this line should have no issues opening your bank.
    d.state = "Attempting to open bank";
    if (bank.open())
            return true;
//If opening a bank fails (meaning you are not anywhere close to a bank), it checks to see if you have a ring of duelling equipped. If you do, it teleports you to castle wars.
At this point, you should normally be able to open the bank in the next loop with the first command.
else if (rodEquipped) {
        d.state = "Teleporting to Castle Wars";
        if (equipment.interact(EquipmentSlot.RING, "Castle Wars"))
            Sleep.sleepUntil(() -> d.castleWars.contains(myPlayer()), 5000);
    } 
//If you don't have a ROD equipped, it tries to walk you to the closest bank. This is a custom method in my API which tries to walk you to one of like 60 different banks. 
The only way this would fail is if you are in a very remote location. In which case it stops the script and initiates the error pop-up telling you to get closer to a bank.
else if (!d.walkToClosestBank(true) && bot.getScriptExecutor().isRunning())
        errorMessage("Cannot walk to any banks. Please restart the script near a bank", true);

    return false;
}

So from my understanding, the only way you could be continuously teleporting to Castle Wars is because the bot cannot open the bank in Castle Wars.  

Just to make sure, you are using 2.5.59 right? Because this is exactly the issue it was meant to fix. Also, does it open the bank and then teleport? or does it not even try to open the bank?

Again, this is just another one of my attempts to make the script more failsafe. So even if you don't have an ROD equipped, it can still find a bank.

Otherwise I could just do something like this:

if(castleWars.contains(myPlayer()))
    bank.open();

But it seems like this wouldn't work for you either since the bank.open() doesn't work in my code either.

I really appreciate the feedback and I'm going to keep looking into this. I gave you a 1 week trial on my Tithe Farm script and will give you a week on my Rouge Den script too once it gets approved( later today probably). You've been a good tester 

 

[dabswax]

3 hours ago, DylanSRT said:

Okay, so I know exactly what bit of code is causing this. But it has never happened to me which is weird. I'm going to go analytical on this one because I am confused.

So this is the bit of script that handles the banking (or rather bank opening). The goal of this method is to get a bank open, in which case it returns true. 

private boolean bankingHandler() throws InterruptedException {
//So first it tries to simply open a bank nearby. Normally, if you are in castle wars, this line should have no issues opening your bank.
    d.state = "Attempting to open bank";
    if (bank.open())
            return true;
//If opening a bank fails (meaning you are not anywhere close to a bank), it checks to see if you have a ring of duelling equipped. If you do, it teleports you to castle wars.
At this point, you should normally be able to open the bank in the next loop with the first command.
else if (rodEquipped) {
        d.state = "Teleporting to Castle Wars";
        if (equipment.interact(EquipmentSlot.RING, "Castle Wars"))
            Sleep.sleepUntil(() -> d.castleWars.contains(myPlayer()), 5000);
    } 
//If you don't have a ROD equipped, it tries to walk you to the closest bank. This is a custom method in my API which tries to walk you to one of like 60 different banks. 
The only way this would fail is if you are in a very remote location. In which case it stops the script and initiates the error pop-up telling you to get closer to a bank.
else if (!d.walkToClosestBank(true) && bot.getScriptExecutor().isRunning())
        errorMessage("Cannot walk to any banks. Please restart the script near a bank", true);

    return false;
}

So from my understanding, the only way you could be continuously teleporting to Castle Wars is because the bot cannot open the bank in Castle Wars.  

Just to make sure, you are using 2.5.59 right? Because this is exactly the issue it was meant to fix. Also, does it open the bank and then teleport? or does it not even try to open the bank?

Again, this is just another one of my attempts to make the script more failsafe. So even if you don't have an ROD equipped, it can still find a bank.

Otherwise I could just do something like this:

if(castleWars.contains(myPlayer()))
    bank.open();

But it seems like this wouldn't work for you either since the bank.open() doesn't work in my code either.

I really appreciate the feedback and I'm going to keep looking into this. I gave you a 1 week trial on my Tithe Farm script and will give you a week on my Rouge Den script too once it gets approved( later today probably). You've been a good tester 

 

I am using 2.5.59, and its about half and half it seems, half the time spins the camera and reteles, and other half clicks bank starts running and then reteles during the run. Also, if needed you can always contact me on discord if its easier dabswax#7316

Edited September 30, 2019 by dabswax

[Daggore]

Can we add the option for a bottomless bucket at all?

[dabswax]

For some reason now for me, its only ever visiting 1 farming patch location every run, then goes back to CW.

 

thank you for the trials and everything you do as well!

Edited September 30, 2019 by dabswax

[DylanSRT]

6 hours ago, dabswax said:

For some reason now for me, its only ever visiting 1 farming patch location every run, then goes back to CW.

Hmm.. it's working for me so I don't know what to tell you.

Can you generate an error report with F12 and post it here? I want to see your exact settings. You can just press F12 right after you hit start on the GUI, so I can see what you have selected and try it out on my own.

Edited September 30, 2019 by DylanSRT

[dabswax]

4 hours ago, DylanSRT said:

Hmm.. it's working for me so I don't know what to tell you.

Can you generate an error report with F12 and post it here? I want to see your exact settings

Error: User Generated
Time ran: 0 h 34 m 24 s - In game: 0 h 4 m 8 s
State: Breaking - 18 minutes till login
Position: 3760,3758,0
First run:false - Mode:1
Trip Started:true - Banking:false - Items Withdrawn:false
-----BH:true-----
Trips: 1 (4 BH) - TripTimes:16,17,18,18
Xp Gained: 4080
SeedNest:2 - ClueNest:0 - RingNest:2 - Nest:4
DP:true - DPEquipped:true - BuySeeds:false - Empty:false
-----Farm:true-----
Trips: 1 - TimeTillNextTrip: 49
Xp Gained: 0
Herb:true-Best in Bank-3 - Allotment:true-Best in Bank-18 - Flower:true-Best in Bank-3
HerbHarv:0 - AllotHarv:0 - FlowerHarv:0
Compost:Ultracompost Cure:true
Sec:true,true - AOB:true,false
Hosi:false,Xeric:false - Cath:true - Ardy:true - Mory:false - Fally:true
-----Inventory-----
Barley seed x 40, Yew bird house x 4, Hammer x 1, Chisel x 1, 

 

 

Error: User Generated
Time ran: 0 h 44 m 46 s - In game: 0 h 7 m 15 s
State: Breaking - 8 minutes till login
Position: 3760,3758,0
First run:false - Mode:1
Trip Started:true - Banking:false - Items Withdrawn:false
-----BH:true-----
Trips: 1 (4 BH) - TripTimes:6,7,7,8
Xp Gained: 4560
SeedNest:1 - ClueNest:0 - RingNest:0 - Nest:4
DP:true - DPEquipped:false - BuySeeds:false - Empty:false
-----Farm:true-----
Trips: 1 - TimeTillNextTrip: 42
Xp Gained: 779
Herb:true-Toadflax seed-3 - Allotment:true-Strawberry seed-18 - Flower:true-Limpwurt seed-3
HerbHarv:0 - AllotHarv:15 - FlowerHarv:6
Compost:Ultracompost Cure:true
Sec:true,true - AOB:true,false
Hosi:true,Xeric:false - Cath:true - Ardy:true - Mory:false - Fally:true
-----Inventory-----
Barley seed x 40, Magic bird house x 4, Hammer x 1, Chisel x 1,

 

Error: User Generated
Time ran: 0 h 41 m 44 s - In game: 0 h 3 m 32 s
State: Breaking - 11 minutes till login
Position: 3760,3758,0
First run:false - Mode:1
Trip Started:true - Banking:false - Items Withdrawn:false
-----BH:true-----
Trips: 1 (4 BH) - TripTimes:9,9,10,11
Xp Gained: 4080
SeedNest:1 - ClueNest:0 - RingNest:0 - Nest:2
DP:true - DPEquipped:true - BuySeeds:false - Empty:false
-----Farm:true-----
Trips: 1 - TimeTillNextTrip: 41
Xp Gained: 0
Herb:true-Toadflax seed-3 - Allotment:true-Strawberry seed-18 - Flower:true-Limpwurt seed-3
HerbHarv:0 - AllotHarv:0 - FlowerHarv:0
Compost:Ultracompost Cure:true
Sec:true,true - AOB:true,false
Hosi:false,Xeric:false - Cath:true - Ardy:true - Mory:false - Fally:true
-----Inventory-----
Barley seed x 40, Yew bird house x 4, Hammer x 1, Chisel x 1, 

 

 

Almost every account ive got atm is different as you can see.

Sometimes it is just withdrawing stuff and exiting bank doing nothing and immediately and it thinks it did the farm run and just rebanks. And sometimes does 1 patch (as you can see via xp gained) I haven't seen it do all of the selected since yesterday.

Edited September 30, 2019 by dabswax

[dabswax]

[WARN][Bot #1][09/30 02:42:57 PM]: Use custom breaks at your own risk.
[WARN][Bot #1][09/30 02:42:57 PM]: OSBot is not responsible for any issues with breaking.
[INFO][Bot #1][09/30 02:44:09 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/30 02:45:06 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/30 02:45:46 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/30 02:47:19 PM]: Started random solver : Breaking Till Next Birdhouse/Herb Trip
[INFO][Bot #1][09/30 03:35:18 PM]: Random solver exited : Breaking Till Next Birdhouse/Herb Trip
[INFO][Bot #1][09/30 03:35:19 PM]: Started random solver : Auto Login
[INFO][Bot #1][09/30 03:35:22 PM]: Successfully logged in, waiting for welcome screen.
[INFO][Bot #1][09/30 03:35:34 PM]: Random solver exited : Auto Login
[INFO][Bot #1][09/30 03:35:37 PM]: Started random solver : Welcome Screen
[INFO][Bot #1][09/30 03:35:40 PM]: Random solver exited : Welcome Screen
[INFO][Bot #1][09/30 03:36:27 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/30 03:37:03 PM]: WebWalkingEvent; We have reached the final destination!

 

Error: User Generated
Time ran: 0 h 55 m 16 s - In game: 0 h 7 m 16 s
State: Withdrawing Yew logs x 4
Position: 2443,3083,0
First run:false - Mode:1
Trip Started:false - Banking:true - Items Withdrawn:true
-----BH:true-----
Trips: 2 (8 BH) - TripTimes:48,48,49,49
Xp Gained: 8160
SeedNest:4 - ClueNest:0 - RingNest:2 - Nest:9
DP:true - DPEquipped:true - BuySeeds:false - Empty:false
-----Farm:true-----
Trips: 2 - TimeTillNextTrip: 80
Xp Gained: 0
Herb:true-Best in Bank-3 - Allotment:true-Best in Bank-18 - Flower:true-Best in Bank-3
HerbHarv:0 - AllotHarv:0 - FlowerHarv:0
Compost:Ultracompost Cure:true
Sec:true,true - AOB:true,false
Hosi:false,Xeric:false - Cath:true - Ardy:true - Mory:false - Fally:true
-----Inventory-----
Barley seed x 40, 

 

logger of when it is happening exactly. (took this 10 seconds after it rebanked and didn't do "2nd" farm trip

[DylanSRT]

29 minutes ago, dabswax said:

[WARN][Bot #1][09/30 02:42:57 PM]: Use custom breaks at your own risk.
[WARN][Bot #1][09/30 02:42:57 PM]: OSBot is not responsible for any issues with breaking.
[INFO][Bot #1][09/30 02:44:09 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/30 02:45:06 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/30 02:45:46 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/30 02:47:19 PM]: Started random solver : Breaking Till Next Birdhouse/Herb Trip
[INFO][Bot #1][09/30 03:35:18 PM]: Random solver exited : Breaking Till Next Birdhouse/Herb Trip
[INFO][Bot #1][09/30 03:35:19 PM]: Started random solver : Auto Login
[INFO][Bot #1][09/30 03:35:22 PM]: Successfully logged in, waiting for welcome screen.
[INFO][Bot #1][09/30 03:35:34 PM]: Random solver exited : Auto Login
[INFO][Bot #1][09/30 03:35:37 PM]: Started random solver : Welcome Screen
[INFO][Bot #1][09/30 03:35:40 PM]: Random solver exited : Welcome Screen
[INFO][Bot #1][09/30 03:36:27 PM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][09/30 03:37:03 PM]: WebWalkingEvent; We have reached the final destination!

 

Error: User Generated
Time ran: 0 h 55 m 16 s - In game: 0 h 7 m 16 s
State: Withdrawing Yew logs x 4
Position: 2443,3083,0
First run:false - Mode:1
Trip Started:false - Banking:true - Items Withdrawn:true
-----BH:true-----
Trips: 2 (8 BH) - TripTimes:48,48,49,49
Xp Gained: 8160
SeedNest:4 - ClueNest:0 - RingNest:2 - Nest:9
DP:true - DPEquipped:true - BuySeeds:false - Empty:false
-----Farm:true-----
Trips: 2 - TimeTillNextTrip: 80
Xp Gained: 0
Herb:true-Best in Bank-3 - Allotment:true-Best in Bank-18 - Flower:true-Best in Bank-3
HerbHarv:0 - AllotHarv:0 - FlowerHarv:0
Compost:Ultracompost Cure:true
Sec:true,true - AOB:true,false
Hosi:false,Xeric:false - Cath:true - Ardy:true - Mory:false - Fally:true
-----Inventory-----
Barley seed x 40, 

 

logger of when it is happening exactly. (took this 10 seconds after it rebanked and didn't do "2nd" farm trip

So it goes to fally patch and harvests/replants the plants there and then it teles back to CW right? nvm I can see from xpGained that it doesn't harvest and directly teles. I'll figure this out today

Edited September 30, 2019 by DylanSRT

[DylanSRT]

@dabswax

can you try to get a log after it withdraws items for the farm trip, but before it teles back to cw?

[dabswax]

57 minutes ago, DylanSRT said:

@dabswax

can you try to get a log after it withdraws items for the farm trip, but before it teles back to cw?

? it withdraws the farming items at the cw chest, doesnt tele and just puts them back. it doesn't ever tele except for the hosidius teleport, that is what the previous logger is of. (if im understanding correctly)

 

1 hour ago, DylanSRT said:

So it goes to fally patch and harvests/replants the plants there and then it teles back to CW right? nvm I can see from xpGained that it doesn't harvest and directly teles. I'll figure this out today

Yes when it does do 1 patch it either does hosidius if checked, falador if not, then teles back to cw.

 

 

Oddly enough, one seems to have fixed itself, the other 2 still nothing. Just for reference

 

Going to restart comp again in 30 mins or so and see if that does anything for me.

 

Error: User Generated
Time ran: 2 h 57 m 39 s - In game: 0 h 34 m 17 s
State: Picking Herbs
Position: 3058,3310,0
First run:false - Mode:2
Trip Started:true - Banking:false - Items Withdrawn:false
-----BH:true-----
Trips: 4 (16 BH) - TripTimes:34,35,35,37
Xp Gained: 18240
SeedNest:10 - ClueNest:0 - RingNest:7 - Nest:15
DP:true - DPEquipped:false - BuySeeds:false - Empty:false
-----Farm:true-----
Trips: 2 - TimeTillNextTrip: -6
Xp Gained: 4445
Herb:true-Toadflax seed-3 - Allotment:true-Strawberry seed-18 - Flower:true-Limpwurt seed-3
HerbHarv:3 - AllotHarv:64 - FlowerHarv:12
Compost:Ultracompost Cure:true
Sec:true,true - AOB:true,true
Hosi:true,Xeric:false - Cath:true - Ardy:true - Mory:false - Fally:true
-----Inventory-----
Rake x 1, Seed dibber x 1, Spade x 1, Law rune x 3, Limpwurt root x 11, Air rune x 5, Water rune x 2, Digsite pendant (3) x 1, Toadflax seed x 3, Strawberry seed x 18, Limpwurt seed x 3, Strawberry x 39, Grimy toadflax x 15, Bucket x 3, 

 

Error: User Generated
Time ran: 2 h 50 m 5 s - In game: 0 h 15 m 40 s
State: Breaking - 38 minutes till login
Position: 3760,3758,0
First run:false - Mode:1
Trip Started:true - Banking:false - Items Withdrawn:false
-----BH:true-----
Trips: 4 (16 BH) - TripTimes:37,37,38,38
Xp Gained: 16320
SeedNest:10 - ClueNest:0 - RingNest:6 - Nest:15
DP:true - DPEquipped:false - BuySeeds:false - Empty:false
-----Farm:true-----
Trips: 4 - TimeTillNextTrip: 69
Xp Gained: 0
Herb:true-Best in Bank-3 - Allotment:true-Best in Bank-18 - Flower:true-Best in Bank-3
HerbHarv:0 - AllotHarv:0 - FlowerHarv:0
Compost:Ultracompost Cure:true
Sec:true,true - AOB:true,false
Hosi:false,Xeric:false - Cath:true - Ardy:true - Mory:false - Fally:true
-----Inventory-----
Barley seed x 40, Yew bird house x 4, Hammer x 1, Chisel x 1, 

 

Error: User Generated
Time ran: 2 h 55 m 22 s - In game: 0 h 15 m 38 s
State: Breaking - 34 minutes till login
Position: 3760,3758,0
First run:false - Mode:1
Trip Started:true - Banking:false - Items Withdrawn:false
-----BH:true-----
Trips: 4 (16 BH) - TripTimes:32,32,33,34
Xp Gained: 16320
SeedNest:8 - ClueNest:0 - RingNest:4 - Nest:8
DP:true - DPEquipped:true - BuySeeds:false - Empty:false
-----Farm:true-----
Trips: 4 - TimeTillNextTrip: 65
Xp Gained: 0
Herb:true-Toadflax seed-3 - Allotment:true-Strawberry seed-18 - Flower:true-Limpwurt seed-3
HerbHarv:0 - AllotHarv:0 - FlowerHarv:0
Compost:Ultracompost Cure:true
Sec:true,true - AOB:true,false
Hosi:false,Xeric:false - Cath:true - Ardy:true - Mory:false - Fally:true
-----Inventory-----
Barley seed x 40, Yew bird house x 4, Hammer x 1, Chisel x 1, 

 

Edited September 30, 2019 by dabswax

[dabswax]

Restarted pc again and it seems to be working as intended. Ill let you know if anything changes overnight. thanks again.

Was just wondering if you ever planned on adding a time/collection counter(ex. like people have in their signatures for fruityzul/nmz etc showing hours and how much of gp/items looted etc). Not necessary and not like itd matter, just curious for myself.  lol

Edited October 1, 2019 by dabswax

[DylanSRT]

2 minutes ago, dabswax said:

Restarted pc again and it seems to be working as intended thanks again.

Was just wondering if you ever planned on adding a time/collection counter(ex. like people have in their signatures for fruityzul/nmz etc showing hours and how much of gp/items looted etc). Not necessary and not like itd matter, just curious for myself.  lol

Haha glad it is working again. I was going crazy trying to figure out what is wrong. Sometimes weird shit happens on PC and needs a reset.

That's a good idea. I'm not sure how to collect data like that though. I'd have to look into it.