combat_acc Posted November 14, 2016 Share Posted November 14, 2016 Uses falador teleport for good mage xp. Requirements 37 magic Items needed air staff and law/water runes >>Download link<< http://www.filedropper.com/faladorteleport import org.osbot.rs07.api.ui.Spells; import java.util.concurrent.TimeUnit; import org.osbot.rs07.script.Script; import org.osbot.rs07.script.ScriptManifest; import java.awt.*; @ScriptManifest(name = "Falador teleport", author = "combat_acc", version = 1, info = "", logo = "") public class main extends Script { private long timeBegan; private long timeRan; @[member=Override] public void onStart() { //Code here will execute before the loop is started } @[member=Override] public void onExit() { //Code here will execute after the script ends } @[member=Override] public int onLoop() throws InterruptedException { getMagic().castSpell(Spells.NormalSpells.FALADOR_TELEPORT); return 100; //The amount of time in milliseconds before the loop starts over } @[member=Override] public void onPaint(Graphics2D g) { Graphics2D gr = g; timeRan = System.currentTimeMillis() - this.timeBegan; g.drawString(ft(timeRan), 40, 360); } // FORMAT TIME METHOD private String ft(long duration) { String res = ""; long days = TimeUnit.MILLISECONDS.toDays(duration); long hours = TimeUnit.MILLISECONDS.toHours(duration) - TimeUnit.DAYS.toHours(TimeUnit.MILLISECONDS.toDays(duration)); long minutes = TimeUnit.MILLISECONDS.toMinutes(duration) - TimeUnit.HOURS.toMinutes(TimeUnit.MILLISECONDS.toHours(duration)); long seconds = TimeUnit.MILLISECONDS.toSeconds(duration) - TimeUnit.MINUTES.toSeconds(TimeUnit.MILLISECONDS.toMinutes(duration)); if (days == 0) { res = (hours + ":" + minutes + ":" + seconds); } else { res = (days + ":" + hours + ":" + minutes + ":" + seconds); } return res; } } Quote Link to comment Share on other sites More sharing options...
Juggles Posted November 14, 2016 Share Posted November 14, 2016 You're going to spam click the teleport every .1 seconds. Add a conditional sleep 4 Quote Link to comment Share on other sites More sharing options...
combat_acc Posted November 14, 2016 Author Share Posted November 14, 2016 You're going to spam click the teleport every .1 seconds. Add a conditional sleep yes but it doesnt matter. i ran the script 12 hours with no problems/bans Quote Link to comment Share on other sites More sharing options...
Bamboozled Posted November 14, 2016 Share Posted November 14, 2016 It's nice to you making progress! Keep it up Quote Link to comment Share on other sites More sharing options...
Minions Posted November 14, 2016 Share Posted November 14, 2016 (edited) i appreciate your attempt, but this is just the same as a auto clicker with spam clicking. Edit: I believe it's in the wrong section aswell, has nothing to do with combat & prayer Edited November 14, 2016 by Minions 3 Quote Link to comment Share on other sites More sharing options...
Team Cape Posted November 14, 2016 Share Posted November 14, 2016 (edited) yes but it doesnt matter. i ran the script 12 hours with no problems/bans Yes. It does matter. You're clicking at a ridiculously inhuman rate. also, you're going to keep trying even when you're out of runes. it's a 1 line script - what did you expect? You try to be efficient in programming. Not lazy. 2 very different concepts. Edited November 14, 2016 by Imateamcape 5 Quote Link to comment Share on other sites More sharing options...
Juggles Posted November 14, 2016 Share Posted November 14, 2016 (edited) I'm not trying to be mean here but this script doesn't show you have progressed. Try to work on adding new features. Check if you have runes inventory, else stop(); Check if magic tab is open.Maybe add some l33t antiban by checking WC xp Add different spells with GUI or make it recognize what area you're in and do it accordingly. Idk just do something to help you learn. Copy and pasting one line of code from the API does not benefit you . Edited November 14, 2016 by Juggles 2 Quote Link to comment Share on other sites More sharing options...
Muffins Posted November 14, 2016 Share Posted November 14, 2016 It won't log out when out of runes and will just keep spamming 2 Quote Link to comment Share on other sites More sharing options...
Saiyan Posted November 14, 2016 Share Posted November 14, 2016 Simple checks will improve this script by plentifold 1) check if we have runes what's the the point if it spam clicks a spell if we don't have have runes that's like shooting yourself in the foot. E.g if(getInventory().contains("Law rune","Air rune") && check if equipments weapon slot contains staff of water && getMagic().canCast(Spells.NormalSPells.FALADOR_TELEPORT { long lawCount = getInventory().getAmount("Law runes"); then cast the spell and cond sleep and return that getImventory().getAmount("Law rune") < lawCount Sorry ignore some things are incorrect i wrote this out on my phone at 9am Quote Link to comment Share on other sites More sharing options...
Prolax Posted November 14, 2016 Share Posted November 14, 2016 Repeating your onLoop every 100 ms is very bot-like, don't you think? Which human clicks exactly every 100 ms? Quote Link to comment Share on other sites More sharing options...
Booleans YAY Posted January 1, 2017 Share Posted January 1, 2017 (edited) if (days == 0) { res = (hours + ":" + minutes + ":" + seconds); } else { res = (days + ":" + hours + ":" + minutes + ":" + seconds); } Could just be (utilizing if ternary) res = (days == 0 ? hours + ":" + minutes + ":" + seconds : days + ":" + hours + ":" + minutes + ":" + seconds); You could also use a conditional sleep while the teleporting is being done to have a pause or event-like function take place. Also add a random(#) sleep pause in the conditional, so it's not a constant delay ratio, makes it less detectable if you were to compare the two. Overall, pretty straight forward and easy. Good job on efforts. Edited January 1, 2017 by Booleans YAY Quote Link to comment Share on other sites More sharing options...
Borre Posted January 2, 2017 Share Posted January 2, 2017 if (days == 0) { res = (hours + ":" + minutes + ":" + seconds); } else { res = (days + ":" + hours + ":" + minutes + ":" + seconds); } Could just be (utilizing if ternary) res = (days == 0 ? hours + ":" + minutes + ":" + seconds : days + ":" + hours + ":" + minutes + ":" + seconds); You could also use a conditional sleep while the teleporting is being done to have a pause or event-like function take place. Also add a random(#) sleep pause in the conditional, so it's not a constant delay ratio, makes it less detectable if you were to compare the two. Overall, pretty straight forward and easy. Good job on efforts. Just started looking into Runescape scripting and was wondering if using the shorter equivalents makes a lot of difference script wise, I always thought readability is a lot more important than shorter code. Quote Link to comment Share on other sites More sharing options...
Booleans YAY Posted January 2, 2017 Share Posted January 2, 2017 Just started looking into Runescape scripting and was wondering if using the shorter equivalents makes a lot of difference script wise, I always thought readability is a lot more important than shorter code. Well firstly, this format isn't java formation, and everyone doesn't like to look at it so backspace them back to original spots private String ft(long duration) { private String ft(long duration) { The ternary code is readable if you have the basics of java in mind. 1 Quote Link to comment Share on other sites More sharing options...
fstyle Posted January 2, 2017 Share Posted January 2, 2017 this is like the definition of laziness. Quote Link to comment Share on other sites More sharing options...
Transporter Posted June 25, 2019 Share Posted June 25, 2019 Used this script and got me 99 magic thanks! Quote Link to comment Share on other sites More sharing options...