-
Posts
11169 -
Joined
-
Last visited
-
Days Won
91 -
Feedback
100%
Everything posted by Apaec
-
[LF HELP] - Task based script, changing used variables
Apaec replied to Mephisto's topic in Scripting Help
I'd actually contest this and say that scripts with simple if/else statements are much easier to read than those with these if/else statements in lots of other classes, wrapped in unnecessary objects. For bigger and longer scripts, you're right - you're going to need more than a single class. But using this 'task' framework that everyone is obsessed with really doesn't use object orientation for anything useful. As an example, take a look at my open source AIO Herblore script: https://github.com/apaec/aio-herblore. It supports activity queueing along with every potion, unf potion, tar making and herb cleaning, and yet it doesn't use this 'task' system. The OO design isn't perfect, I can think of a few flaws, but for the most part the OO makes it more concise and readable, in a way that wouldn't be possible with just if/else statements in the onLoop. I'd reiterate what I said before in suggesting just writing scripts with if/else statements. Eventually you will end up with a situation where you are doing something messy, or repeating yourself lots, at which point you can take the opportunity to find an OO solution to the problem Apa -
Hi troro, Thanks for mentioning this. You're correct in saying that this happens when you configure the script to use the special attack when you do not have a weapon with special attack capabilities. I've made a note to add a check for this, although I aim to avoid allowing the user to misconfigure the script and save a misconfigured instance, only to load it up again and face the same problem. So maybe instead of continuing as usual, I could force the script to stop and be reconfigured. Either way, i'll come up with a good solution. As for your second point, I could do this, however then it wouldn't really make sense if the 'EXP gained' counter doesn't show all of the exp gained. I could add a second counter for HP exp, but I want to avoid cluttering the paint unnecessarily. Best Apa
-
[LF HELP] - Task based script, changing used variables
Apaec replied to Mephisto's topic in Scripting Help
Hey, There are quite a few syntax issues and bad practices throughout your code. Instead of pointing them out one by one, i'd suggest falling back to the basics. There's no need to complicate your script with object orientation which you don't need, especially if you're not very confident with object oriented concepts just yet. The more scripts you write and programming you do, the more your skills will develop, and at some point you will naturally get a feel for which design patterns you need and what approach to take when structuring your scripts. If I were in your position, i'd stick with if/else statements inside your onLoop, and perhaps experiment with moving your equipment data into an enum. Don't make a mountain out of a mole hill! Good luck -Apa -
Hmm, that's odd - it shouldn't do that. Nonetheless, I will run some tests and see where it might be going wrong. Thanks for letting me know. Apa
-
Hey! Thanks for the questions. Currently you cannot set the tile yourself. The reason for this is each position has other data also associated with it, for example a safe position where you can log out before breaks and a refresh route. Generating these dynamically would be error prone and as a result the data is hard coded. I hadn't thought of this 'account pair' use case, however custom positions may still not work as there is the risk that the script might detect your other account as a player trying to crash you, and subsequently hop. I'd suggest using two nearby 2-spawns instead, there are plenty of these on the west coast if I remember correctly. You can buy the script with OSGP, however not directly. As the store is managed by OSBot, I cannot take payments directly. You will need to purchase a store voucher from a third party, and then redeem this for in-store credit. This credit can then be used to purchase this script or others. Here's a link to the vouchers subforum where you can find people trading vouchers for OSRS GP: https://osbot.org/forum/forum/227-vouchers/ Hope that helps, let me know if you have any further questions or would like a trial. Apa
-
Update! Version 1.02 Fixed brightness manager issues caused by recent game update. The script should now once again correctly set the brightness if necessary. Migrated profit tracking to official OSRS API. Profit tracking should now once again work. -Apa
-
Of course Trial started. Apa (Please note that the profit tracking is not currently working as the RSBuddy grand exchange API has been retired. Hoping to find a solution to this later on in the week)
-
Hey, I'm not sure why this might be, but please could you help me by answering some diagnostic questions? Does it happen with other scripts? Is there anything logged in the console logger? Does this happen in Stealth Injection too? Are you using the default OSRS client with mirror mode? In general I strongly encourage users to stick with Stealth Injection as mirror mode can cause unexpected behaviour, so it might be best if you were to switch to that Best Apa
-
I'm glad you like the scripts Sure thing - trial started Apa
-
Sure - trial started Apa
-
Hey, Thanks for your custom I don't actually have a thieving script (other than chest thiever if this is the one you mean?) - maybe you're thinking of a different script? Apa Hey, Unfortunately I don't do private scripts. Sorry about that Apa
-
Ah, that's annoying. There's nothing I can do about this really, it's not to do with the script and as such is out of my control. I'll let the developers know that this has issue is still occurring though. Apa
-
Should be working well. I was planning to implement the switch to the OSRS exchange API today, and I will also do a general healthcheck of the script to double check that every feature is working as expected. IAmBackBois flagged an issue with the brightness manager so I will be taking a look at that as well. Apa
-
Have you considered botting at SandCrabs instead? They're much better exp/h ! Both trials started Apa
-
Hey, I do have discord, but I rarely use it. I'd suggest if you want to get in touch, drop a reply here or alternatively you can send me a PM Apa
-
Here's a useful site if you haven't already seen it http://www.itemdb.biz/
-
Thanks for your custom If you run into any issues, don't hesitate to let me know. Best Apa
-
Sure - trial activated Apa
-
Have you tried with the latest dev build? This should fix any outstanding issues. Apa
-
Certainly, trial activated. Enjoy! Apa
-
Hmm, I always thought players would log out over going AFK (which is what the OSBot break system is designed to simulate). Either way, logging out or going AFK probably have no difference on ban rates. I think it's much more down to how you use the script, (timing and frequency etc) I'd recommend giving this thread a quick read if you haven't already! https://osbot.org/forum/topic/124429-preventing-rs-botting-bans-v3/ -Apa Sure - trial started Apa
-
Sure - trial started Apa
-
Hey, Please try the latest Dev build which I linked in the above post - this should fix the file access permission issues which are causing the JOptionPanes not to show up. Best Apa
-
Sure - 24h trial started Apa