TheWind
Members
-
Joined
-
Last visited
Everything posted by TheWind
-
No need to decompile anything. The script's code is provided at the bottom of the post. Copy and paste that into eclipse then just add Satire's fix and delete that single line. Look up a youtube video on how to compile a jar in eclipse and your good to go -
-
-
-
How much are you looking to pay for the accounts?
-
Makes me want to get one of my own
-
Without "TheWind" you'll get no power ;) Also, nice job on your first release!
-
I'm actually an idiot... Thank you so much for the help. I'm just coming back to scripting in osrs and for some reason, I forgot that the interaction event required includes the word of the bar type so "Make X Bronze" instead of "Make X" for the specific Widget. I think I'll do just what you said with the Enum too. Hopefully, I can give back to the community somehow and thanks again!
-
Yah, I've been doing that. Even tried out your code. It doesn't work for choosing any of the options because the widget containing "Bronze" doesn't have the options in it if you look at the debugger. Neither does the widget below it which is larger.
-
I spent like 20 minutes going through all the widgets in the furnace interface. Maybe I was missing something obvious...
-
I can't seem to figure out which widget contains the options for smithing bars. When I look through the widgets each widget's tooltip seems to be one of the options. I would prefer to work with widgets in this context as opposed to MouseDestinations. Anybody worked with this before?
-
Greetings!
-
-
what sort of checks did you do to test if a tile would be a valid addition to the area?
-
I can sell you one too
-
Once again your thread layout manages to be more aesthetically pleasing than almost any other thread on the forum.
-
Liked the correct thread
-
From what I've heard botting on school networks has low ban rates
-
Nice giveaway!
-
I like the thread layout. Its hq
-
It's not "style", and learning why code should be written in a certain way is very important to learn at an early stage if you're actually interested in creating large scripts that function well, or learning to program in general. If you're just creating scripts for the purpose of osbot and you have no intention of understanding the meaning behind what the lines of code do beyond a very basic level then by all means just make the script function at some level. I do think that you're completely correct in saying that making many scripts when you're just starting out is very helpful in learning and may help you learn at a faster pace than just trying to improve one, however, taking even a 5-second glance at this script would allow anybody relatively experienced in making scripts see so many problems. @Jake Slang asked specifically for feedback on his sleep and the logic of his script. If he had not asked I would not have given him that feedback.
-
On the contrary, I think that it's important to take a second look and even a third look over your code to improve its performance and possibly find/fix problems you may not have seen the first time. I think there are a good number of things you can improve in this script. Such as your sleep usage, overall logic (conditional logic/flow of the program), and variable use. 1) In terms of the logic of your script, I feel you need to add quite a few more if statements. The reason for this is to limit the number of actions that you take in one loop iteration of the method onLoop() to one. The method onLoop() is meant to be able to be called many times a second or to be at the rate of about one tick per loop iteration. Heres an example where you could add more if statements. private boolean canFishShrimps() throws InterruptedException { if (!getInventory().contains("Small fishing net")) { getWalking().webWalk(lumbyBank); MethodProvider.sleep(2000); getBank().open(); getBank().withdraw("Small fishing net", 1); } return !myPlayer().isAnimating() && !getInventory().isFull(); } could be broken into something like this: if(!getInventory().contains("Small fishing net")) { if(!lumbyBank.contains(myPlayer().getPosition())) { getWalking().webWalk(lumbyBank); } } else { // you are in lumby bank if(getBank().isOpen()) { if(getBank().contains("Small fishing net")) { getBank().withdraw("Small fishing net"); } } else { // bank isn't open getBank().open(); } } Other things such as when you choose to go to the bank to get the fishing net could also be addressed. There are a large number of other problems in your logic, but I feel if you break the problem down into smaller steps and write them out in this if/else fashion it will help you fix them. 2) The methods fish() and sleepConditional() contain different "fishingSpot" variables. You could create the variable "fishingSpot" in the class scope by putting it after your area and position. Assign it null initially and assign it the closest fishing spot in the first method fish(). The reason for this is that you assign "fishingSpot" the closest fishing spot twice and potentially they could be different. 3) I feel another problem is your sleepConditional() method. You have the exact same code in that method as in the fish() method except that you add the sleep, and then log the sleep (lol). By logging the sleep you're actually calling it a second time. You could assign the first Sleep.sleepUntil to a variable and then log that variable or just log one sleep. Edit: Busy for now, but I may come back and change/add more stuff to this list to make it more complete and concise. Edit 2: On second thought you could move on to a new script and just apply some of these things to that.
-
No way to do it in 3 days unless you play like full 24hrs and use boosts, even with the reduced experience needed to reach 30. I'd be happy to level your account. just respond on skype.
-
There is no reason to use a while loop to continue to fish. The method onLoop() gets called over and over until the script is exited, so you can just have an if statement to check when to fish
-
Are you talking about putting a java applet into a webpage?
