Perfect Fighter AIO

[martinc]

Hey @Czaryou mentioned a while ago you wanted to implement ammonite crabs into this? I just tried it to check but it looks like it isn't working. Are you looking to add this feature? Thank you!

[PineApoe]

Does this support Lava Dragons w/ safe spot by chance?

[MarinoNY]

So I just answered my own questions, basically the script for rock crabs is of course czars but he implemented rock crabs by creating almost a whole new program all together -

My issue is looting? Is it broken or am I doing something wrong? My PC wont look anything at all even if I already have some in my inventory like gp or caskets - I usually select Rare Loot Table as well AND other stuff I want like talisman ect  -

Thank you!

 

PS My official Review will be coming up soon for this after I reached a week with the premium service

[123klaid]

can u test out green dragons it doesnt seem to work correctly, forgets to loot items, sometimes will just teleport back with amulet of glory even tho it just got to dragons ( no pkers is not enabled), sometimes also stops randomly walking around etc etc, seems to be buggy overall

i tried all spots lvl 13 20 23, used amulet of glory as edgeville teleport when no food left, also had pick up loot 1000gb+ and sometimes tried without that and enabled other loots hope this helps

Edited December 29, 2018 by 123klaid

[exactry]

do you have to add superior slayer monsters to the NPC list in the GUI or will it automatically target them if the regular variant is already added? will it target them over regular mobs?

Edited December 30, 2018 by exactry

[Osten1]

Its like the whole bot is bugging. When i use it for melee combat, it keeps clicking the monster every time it attacks it. 

 

[INFO][Bot #1][12/30 11:29:50 AM]: "ss_slayer_bag_of_salt" changed to "0"
[INFO][Bot #1][12/30 11:29:50 AM]: Command (ss_slayer_bag_of_salt) changed from () to (0)
[INFO][Bot #1][12/30 11:29:50 AM]: "ss_slayer_ice_cooler" changed to "0"
[INFO][Bot #1][12/30 11:29:50 AM]: Command (ss_slayer_ice_cooler) changed from () to (0)
[INFO][Bot #1][12/30 11:29:50 AM]: "aio_fighter_attack_delay" changed to "0"
[INFO][Bot #1][12/30 11:29:50 AM]: Command (aio_fighter_attack_delay) changed from (0) to (0)
[INFO][Bot #1][12/30 11:29:50 AM]: "aio_fighter_special_wait" changed to "0"
[INFO][Bot #1][12/30 11:29:50 AM]: Command (aio_fighter_special_wait) changed from () to (0)
[INFO][Bot #1][12/30 11:29:50 AM]: "ss_b2p_wait_food" changed to "0"
[INFO][Bot #1][12/30 11:29:50 AM]: Command (ss_b2p_wait_food) changed from () to (0)
[INFO][Bot #1][12/30 11:29:50 AM]: "ss_save_bounds" changed to "0"
[INFO][Bot #1][12/30 11:29:50 AM]: Command (ss_save_bounds) changed from () to (0)
[INFO][Bot #1][12/30 11:29:50 AM]: "ss_stopcon_safe" changed to "0"
[INFO][Bot #1][12/30 11:29:50 AM]: Command (ss_stopcon_safe) changed from () to (0)
[INFO][Bot #1][12/30 11:29:50 AM]: "ss_real_distance" changed to "0"
[INFO][Bot #1][12/30 11:29:50 AM]: Command (ss_real_distance) changed from () to (0)
[INFO][Bot #1][12/30 11:29:50 AM]: "ss_allow_multicombat" changed to "0"
[INFO][Bot #1][12/30 11:29:50 AM]: Command (ss_allow_multicombat) changed from () to (0)
[INFO][Bot #1][12/30 11:29:50 AM]: "ss_reattack_target" changed to "0"
[INFO][Bot #1][12/30 11:29:50 AM]: Command (ss_reattack_target) changed from () to (0)
[INFO][Bot #1][12/30 11:29:50 AM]: Special change from (0) to (100)
[INFO][Bot #1][12/30 11:29:50 AM]: Cannon mode NOT activated!
[INFO][Bot #1][12/30 11:29:50 AM]: [FFA1] Fighting target at [x=2038, y=5191, z=0]
[INFO][Bot #1][12/30 11:29:51 AM]: [FFA1] Fighting target at [x=2040, y=5190, z=0]
[INFO][Bot #1][12/30 11:29:53 AM]: Changed interaction!
[INFO][Bot #1][12/30 11:29:53 AM]: We attacked our first target, wewt.
[INFO][Bot #1][12/30 11:29:53 AM]: "attacked_before" changed to "1"
[INFO][Bot #1][12/30 11:29:53 AM]: Returning combat to attacker... (SPECIFIC)
[INFO][Bot #1][12/30 11:29:53 AM]: [FFA1] Fighting target at [x=2040, y=5190, z=0]
[INFO][Bot #1][12/30 11:29:55 AM]: Returning combat to attacker... (SPECIFIC)
[INFO][Bot #1][12/30 11:29:55 AM]: [FFA1] Fighting target at [x=2040, y=5190, z=0]
[INFO][Bot #1][12/30 11:29:57 AM]: Returning combat to attacker... (SPECIFIC)
[INFO][Bot #1][12/30 11:29:57 AM]: [FFA1] Fighting target at [x=2040, y=5190, z=0]
[INFO][Bot #1][12/30 11:29:59 AM]: Returning combat to attacker... (SPECIFIC)
[INFO][Bot #1][12/30 11:29:59 AM]: [FFA1] Fighting target at [x=2040, y=5190, z=0]
[INFO][Bot #1][12/30 11:30:00 AM]: Terminating script Perfect Fighter...
[INFO][Bot #1][12/30 11:30:00 AM]: Dumping save...
[INFO][Bot #1][12/30 11:30:00 AM]: 
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_save_bounds" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_hop_at_death" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_allow_multicombat" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_stop_at_death" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "prayer_normal_mode" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "aio_fighter_attack_delay" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_cannon_mode" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_eat_bounds_2" "65"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_eat_bounds_1" "45"
[INFO][Bot #1][12/30 11:30:00 AM]: "loot_item_value" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_break_at_bank" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_custom_break_tile" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_slayer_ice_cooler" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "aio_fighter_special_wait" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_cannonball_range_2" "15"
[INFO][Bot #1][12/30 11:30:00 AM]: "eat_for_space" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "only_loot_target" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "allow_varrock_upstairs" "1"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_cannonball_range_1" "15"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_only_my_npcs" "1"
[INFO][Bot #1][12/30 11:30:00 AM]: "unreachable" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_slayer_bag_of_salt" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_move_mouse_outside" "1"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_wait_loot" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_magic_mode" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "level_task_mode" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_fight_with_cannon" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "fight_position_y" "5192"
[INFO][Bot #1][12/30 11:30:00 AM]: "bank_mode" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "fight_position_z" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "fight_position_x" "2040"
[INFO][Bot #1][12/30 11:30:00 AM]: "bank_condition" "No_food"
[INFO][Bot #1][12/30 11:30:00 AM]: "npc_cb_0" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "loot_in_combat" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_smart_safespot" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "enable_loot_arrows" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_stopcon_safe" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "enable_bone_bury" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_npc_tile_dist" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_fightzone_stay" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_spec_min_target_hp" "40"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_antifire_mode" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_ov_potion_mge" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "telegrab_loot" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_ov_potion_def" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_readyclick_npc" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_first_occurence_y" "5193"
[INFO][Bot #1][12/30 11:30:00 AM]: "no_loot_arrows_combat" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_first_occurence_x" "2037"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_ov_potion_cb" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_first_occurence_z" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_b2p_wait_food" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "npc_name_0" "Flesh_Crawler"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_real_distance" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "pref_bank" "nearest"
[INFO][Bot #1][12/30 11:30:00 AM]: "ranging_mode" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "prayer_flick_mode" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ab_override_random" "1"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_ov_potion_str" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_slayer_rockhammer" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "npc_list_size" "1"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_return_safespot_no_loot" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_force_fightzone" "1"
[INFO][Bot #1][12/30 11:30:00 AM]: "ab_mouse_outside" "1"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_safespot_priority" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_ov_potion_rng" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_avoid_response_combat" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "walk_fight_1" "walk"
[INFO][Bot #1][12/30 11:30:00 AM]: "enable_special_attacks" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_guthans_mode" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_modern_eat" "1"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_ov_potion_att" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_fightzone_loot" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "prioritize_loot" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "walk_bank_0" "walk"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_return_safespot_combat" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "loot_list_size" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "bank_list_size" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: "ss_reattack_target" "0"
[INFO][Bot #1][12/30 11:30:00 AM]: 
[INFO][Bot #1][12/30 11:30:00 AM]:  ... success!
[INFO][Bot #1][12/30 11:30:00 AM]: Dumping SmartInventory
[INFO][Bot #1][12/30 11:30:00 AM]: [ACTION]=deposit_all | [ITEM]= empty  | [AMOUNT]=1 |
[ACTION]=deposit_all | [ITEM]= empty  | [AMOUNT]=1 |
[INFO][Bot #1][12/30 11:30:00 AM]: Killed 0 npcs, gained: 88 exp, ran for: ^700^7:^700^7:^311.
[INFO][Bot #1][12/30 11:30:00 AM]: Make sure to post a progress report on the main thread!
[INFO][Bot #1][12/30 11:30:00 AM]: If you have any bugs/suggestions/feedback, please make a detailed post how to add it to the script, in the main thread!
[INFO][Bot #1][12/30 11:30:00 AM]: Thanks for using Perfect Fighter!
[INFO][Bot #1][12/30 11:30:00 AM]: saving fight bounds for profile [justestesitng]
[INFO][Bot #1][12/30 11:30:00 AM]: Script Perfect Fighter has exited!
 

Edited December 30, 2018 by Osten1

[Czar]

Safespotting/keeps clicking - turn off resizable mode for now. Make sure you are running the client in fixed mode.

Cannoning at rock crabs - not supported just yet, but in the works, ETA 1-2 updates after the one today. I did a lot of re-designing for cannon mode so it should be out faster for rock crabs.

Make sure to bot flesh crawlers using the Stronghold plugin, don't fight them using the normal fighter script, it will work. I will add a warning message to trying to fight stronghold npcs without the plugin. The plugin is located at the file menu (setup window > file > plugins) while setting up the bot.

Superior slayer monsters are prioritized, if there is a superior variant of your chosen npc the script will attack it, after it finishes combat with current npc of course. I haven't tested superior slayer monsters just yet so it is still experimental, I will need a confirmation on how it works, good/bad, and I will add an update ASAP :D

Green Dragons - really appreciate the detailed bug reports, I will be debugging and posting an update ASAP. I really want to get GDK flawless so I can remove it from beta mode.

Stronghold - console shows mirror mode error - restart both clients. Use default OSRS client for hooking. Make sure both clients are fully loaded before logging in. Login manually, let the client load for a bit by walking in the game, opening interfaces etc, then start the script. Make sure you do not log in while the client hasn't loaded. Mirror client supports every bot on OSBot, however it needs more updating.

Will be posting the new update today, it's a big update.

[Osten1]

Thanks, it works!

[123klaid]

okey so the issue with stronghold was i had not finished the 2 step authenticator guide  ( reward rooms )now its all working nice so  the issue was all by me sry, gonna test it out and come back for feedback later thx again

can looting have more options since ankou droped weapon poison, adamant bolts, left skull etc but there is no option for that, maybe have custom loot tab or something

Edited December 30, 2018 by 123klaid

[exactry]

14 hours ago, Czar said:

Safespotting/keeps clicking - turn off resizable mode for now. Make sure you are running the client in fixed mode.

Cannoning at rock crabs - not supported just yet, but in the works, ETA 1-2 updates after the one today. I did a lot of re-designing for cannon mode so it should be out faster for rock crabs.

Make sure to bot flesh crawlers using the Stronghold plugin, don't fight them using the normal fighter script, it will work. I will add a warning message to trying to fight stronghold npcs without the plugin. The plugin is located at the file menu (setup window > file > plugins) while setting up the bot.

Superior slayer monsters are prioritized, if there is a superior variant of your chosen npc the script will attack it, after it finishes combat with current npc of course. I haven't tested superior slayer monsters just yet so it is still experimental, I will need a confirmation on how it works, good/bad, and I will add an update ASAP

Green Dragons - really appreciate the detailed bug reports, I will be debugging and posting an update ASAP. I really want to get GDK flawless so I can remove it from beta mode.

Stronghold - console shows mirror mode error - restart both clients. Use default OSRS client for hooking. Make sure both clients are fully loaded before logging in. Login manually, let the client load for a bit by walking in the game, opening interfaces etc, then start the script. Make sure you do not log in while the client hasn't loaded. Mirror client supports every bot on OSBot, however it needs more updating.

Will be posting the new update today, it's a big update.

Tested slayer earlier and it didn't target the superior mobs (Vitreous Jelly, Monstrous basilisk were the ones I saw while babysitting.) I waited a few kills to see if it would, but kept attacking normal mobs. I eventually paused it and killed it myself before it de-spawned. It's a little tricky to test because they don't spawn very frequently but it would be really nice to have implemented, would love to check after a task to find an imbued heart. Assigning a protection prayer to be used for the duration of the superior fight would be really helpful to prevent unnecessary deaths as well, cause some of them can hit pretty hard/accurate. Let me know if there is any additional information that I can provide

Edited December 31, 2018 by exactry

[Czar]

Okay so if a superior slayer npc spawns, does it aggro your player at all times? Or does it just walk around? Also, what happens if you are fighting aggressive npcs that aggro you all the time, and a superior slayer npc spawns, how will you attack it? I will run some tests and try to support them in the next update.

As for ankous, added more seeds and a few other items. They don't appear to drop adamant bolts (according to wiki), only adamant arrows. Can you confirm? Perhaps wiki is out of date?

New Update (v233)

- Added Ammonite Crabs (BETA)
- Added Looting Bag (BETA) there is no option for it, just make sure it's deposit blocked in the inventory loadout.
- Added bracelet of slaughter support
- Added expeditious bracelet support
- (NMZ) Rock Cake fixed: 'Rock cake' renamed to 'Dwarven rock cake'.
- Added F12 to re-open the GUI while script is running
- Added kills/kills per hour
- Added longer delay for filling cannon
- (CANNON) Looting patched, no longer leaves items on floor.
- Added prayer override, you can now override prayer level to sip at (tab: misc. 2)
- Fixed chaos druid door
- Fight bounds improved for larger npcs
- Fixed slayer tower walking
- Fixed spam clicking fill cannon
- Fixed Setup: guthans/gear tab no longer selectable
- Fixed resizable mode compatibility, should work better now
- Wildy npcs can now be accessed by the webwalker
- Added a few more drops to stronghold npcs

Update will automatically go live within 24 hours, good luck guys, and happy new year!  Just doing a final test run of all the features and I will push to SDN. Thanks guys!

Edited December 31, 2018 by Czar

[exactry]

1 hour ago, Czar said:

Okay so if a superior slayer npc spawns, does it aggro your player at all times? Or does it just walk around? Also, what happens if you are fighting aggressive npcs that aggro you all the time, and a superior slayer npc spawns, how will you attack it? I will run some tests and try to support them in the next update.

From what I have seen and assuming the wiki is accurate, they aren't aggressive. You kill the normal monster, it dies, a superior foe will spawn in its place and yes it will walk around until you attack it or it will despawn from world in 2 min.

 If you have aggressive mobs around you and one spawns, you can attack it right away even if you are in combat with another monster and the standard npc will stop attacking you

Edited December 31, 2018 by exactry

[martinc]

4 hours ago, Czar said:

New Update (v233)

 

Hey man you've been great with your support for this and your Perfect Magic. I really appreciate the work and troubleshooting you put into it! I feel like you enjoy working on those two scripts.

[Offensive]

just got this bot error literally every hit:

(Unknown Source)
[INFO][Bot #1][12/31 08:36:01 PM]: KillCounter error: java.lang.NullPointerException
    at org.osbot.rs07.api.util.NodeDequeIteratorG.next(um:125)
    at org.osbot.rs07.api.model.Character.IIIIiiiiIIii(pl:270)
    at org.osbot.rs07.api.model.Character.getHealthPercent(pl:415)
    at a.c.a.Aux.l(gm:152)
    at a.c.a.Aux.L(gm:210)
    at perfect.scripting.LoopScript.l(kp:342)
    at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
    at java.util.concurrent.FutureTask.run(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at java.lang.Thread.run(Unknown Source)
 

Edited January 1, 2019 by Offensive

[Czar]

Hmm it doesn't affect the script so ignore it, it is either from: 1) npc died too quickly to check their HP or 2) using mirror, npc didn't update fast enough. lower reaction timer to 100ms. The script still works after that, so no worries ^^

Thanks guys I really appreciate the nice words and support  

Here is a small proggy of mine at ammonite crabs: