Jump to content

d0zza

Scripter II
  • Posts

    780
  • Joined

  • Last visited

  • Days Won

    1
  • Feedback

    100%

Everything posted by d0zza

  1. I used a decompiler to take a look at your code and there are a few things I can see that could use some fixing up before applying for scripter status. 1) OSbot's API methods can fail and so you should be checking if they return true before sleeping after calling them. Example: if (bank.depositAll()) { sleep; } 2) You should be using conditional sleeps instead of just random sleeps so that the script waits till the condition has passed. 3) I don't know why you're declaring String arrays every time you want to interact with something. NPC banker = (NPC)this.getNpcs().closest(new String[]{"Banker"}); should be NPC banker = (NPC)this.getNpcs().closest("Banker"); And even then, it's a good idea to store things as variables and even final variables if you know the value is never going to change.
  2. d0zza

    null

    Honestly at this point I'd probably just try re write the script, no scripts that I'm using at the moment are experiencing an issue like that.
  3. d0zza

    null

    Maybe try putting the items in the main first tab, it seems like the error is coming from trying to grab the amount in a specific tab.
  4. Well is it not obvious from my reply that it's not negotiable
  5. I clearly stated in the title that I'm selling for $1.05/m
  6. Accepting Skrill and PayPal from trusted users.
  7. Have you tried checking if the ID of the 2 items is different? Names can be the same but ID can be different.
  8. the keyword final means exactly what it sounds like, whatever value you declare that variable to is FINAL, it can not be changed later on in your code. Most IDEs give an error when you try to redefine a final variable anyway.
  9. dCrafter will craft all leathers into any armour piece you'd want! GUI: Proggies: Script is now on the SDN! Click here to add it.
×
×
  • Create New...