Jump to content

Perfect Fighter AIO

Czar

By Czar
in Combat & Slayer

 Share

Recommended Posts

Czar Champion Poster

Czar

Posted
  • Author
Posted

New Update (v244)

- More performance improvements
- Fixed magic shortbow (i) spec
- Another attempt at fixing super combat drinking while ranging
- Added world hop condition: hop if X npcs are in combat
- Script now stops on death (optional banking after death too) if selected as stop condition
- Fixed Kourend Castle banking when in Kourend catacombs
- Walk-setting 3 is now auto-enabled if you are fighting hill giants with brass key
- 'Loot my targets only' with cannon mode has temporarily been disabled until I add support for it
- Fixed NPE on script startup when starting the script while logged out
- NPC 'refinery' improvements, should check if it is able to load npcs from the client or not
- Misc. changes

Will be doing a final test run then posting the update, I hope I didn't miss anything, if I did, it is on my To-do list and requires more work, I will be posting another update as soon as I can. :D

Please let me know if you have any startup issues I will investigate, right now the NPE isn't being reversed, please post again with the current update if it happens again. Also confirm if you are starting the script while logged in or out, I recommend while logged in, with fixed mode set.

Link to comment
Share on other sites
symbol Steel Poster

symbol

Posted
Posted (edited)

Hello, Czar

Bug report:

Safespot seems to mess up webwalking. I am trying to kill Dragons in Taverly Dungeon with safespot.Using 70 Agility shortcut. After banking the script throws up errors:

EDIT: This only happens when Safespot: Highest priority is set.

Spoiler

[INFO][Bot #1][05/26 04:54:44 PM]: Can use teleports: false to destination: [x=2899, y=9810, z=0]
[INFO][Bot #1][05/26 04:54:44 PM]: WebWalkingEvent; No route found! Destinations = [[x=2899, y=9810, z=0]];
[INFO][Bot #1][05/26 04:54:44 PM]: FAILED
[INFO][Bot #1][05/26 04:54:48 PM]: No suitable tile found for given position: [x=2899, y=9810, z=0]!
[INFO][Bot #1][05/26 04:54:48 PM]: WebWalkingEvent; No route found! Destinations = [[x=2899, y=9810, z=0]];
[INFO][Bot #1][05/26 04:54:48 PM]: Resorting to old web
[INFO][Bot #1][05/26 04:54:48 PM]: java.lang.NullPointerException
    at java.util.LinkedList.addAll(Unknown Source)
    at java.util.LinkedList.addAll(Unknown Source)
    at perfect.scripting.d.COM1.A(bf:429)
    at perfect.scripting.d.COM1.A(bf:362)
    at perfect.scripting.d.COM1.A(bf:417)
    at perfect.scripting.b.d.Prn.E(ri:186)
    at perfect.scripting.b.d.Prn.A(ri:1368)
    at perfect.scripting.b.d.Prn.K(ri:620)
    at a.c.a.cOm1.L(in:166)
    at a.c.a.cOm1.b(in:79)
    at a.PrN.l(gq:1316)
    at a.PrN.onLoop(gq:1556)
    at org.osbot.rs07.event.ScriptExecutor$InternalExecutor.run(ah:293)
    at java.lang.Thread.run(Unknown Source)

 

Edited by symbol
  • Like 1
Link to comment
Share on other sites
JojoStands Iron Poster

JojoStands

Posted
Posted (edited)

[INFO][Bot #1][05/26 07:53:00 AM]: Exception in script thread 2: java.lang.ArithmeticException: / by zero
    at perfect.scripting.b.d.Con.G(ap:75)
    at a.PRN.C(ot:2447)
    at a.PRN.onLoop(ot:1732)
    at org.osbot.rs07.event.ScriptExecutor$InternalExecutor.run(ah:293)
    at java.lang.Thread.run(Unknown Source)


this happens after enabling a "level task"

stats.PNG

Edited by JojoStands
  • Like 1
Link to comment
Share on other sites
Czar Champion Poster

Czar

Posted
  • Author
Posted

Will check both of those reports out ASAP.

For taverley dungeon have you tried enabling walk-setting 3? (initial script setup) hopefully it works better, in the meantime I will be running some tests ASAP. Same goes for levelling, should be an easy fix the only hard part was finding the root cause. Update coming up :D 

Link to comment
Share on other sites
symbol Steel Poster

symbol

Posted
Posted (edited)
1 hour ago, Czar said:

Will check both of those reports out ASAP.

For taverley dungeon have you tried enabling walk-setting 3? (initial script setup) hopefully it works better, in the meantime I will be running some tests ASAP. Same goes for levelling, should be an easy fix the only hard part was finding the root cause. Update coming up :D 

Yes i tried that.

I also have a question, what does the setting Real Distance(advanced) do?

Also somehow when a dragon dies and some loot gets left over. The script starts spamming this after getting to bank:

[INFO][Bot #1][05/26 07:40:15 PM]: exec event (Loot action)
[INFO][Bot #1][05/26 07:40:15 PM]: Taking (lootitem: Dragon bones) event
[INFO][Bot #1][05/26 07:40:15 PM]: Walking to loot item!
[INFO][Bot #1][05/26 07:40:15 PM]: Added event (Loot action)!
[INFO][Bot #1][05/26 07:40:16 PM]: exec event (Loot action)

Edited by symbol
  • Like 1
Link to comment
Share on other sites
Czar Champion Poster

Czar

Posted
  • Author
Posted

Hmm maybe it is trying to loot an item too far away? Try setting the loot tile distance to something around 8 tiles. Or Maybe the loot item is around the wall and is technically 8 tiles near, in which case I will make real distance affect looting items too. Worst case scenario: a fight zone can be built and you can enable to only loot items inside the fight zone. I may be adding a new feature called “loot zone” too, will function a lot better. :D 

as for trials, will activate ASAP :D 

Link to comment
Share on other sites
bluebuffalo83 Newbie

bluebuffalo83

Posted
Posted

is there any way to make it can remember your settings / create presets? for example, say I want the script to remember that I like to melee hill giants and want it to bury bones, and bank only certain items. when I turn off the script for the day and turn it back on tomorrow, is there a way for it to remember the previous settings instead of having to manually re enter everything again?

  • Like 1
Link to comment
Share on other sites
JojoStands Iron Poster

JojoStands

Posted
Posted
7 minutes ago, bluebuffalo83 said:

is there any way to make it can remember your settings / create presets? for example, say I want the script to remember that I like to melee hill giants and want it to bury bones, and bank only certain items. when I turn off the script for the day and turn it back on tomorrow, is there a way for it to remember the previous settings instead of having to manually re enter everything again?

File

saveas.PNG

  • Like 1
Link to comment
Share on other sites
meeterdetsi Bronze Poster

meeterdetsi

Posted
Posted (edited)

Don't know what to think of this:

Spoiler

[INFO][Bot #1][05/27 07:02:55 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:02:55 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:02:55 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:02:57 AM]: Finding nearest npc....
[INFO][Bot #1][05/27 07:02:57 AM]:  .. checking for nearby npcs first...
[INFO][Bot #1][05/27 07:02:57 AM]: We are being attacked by an npc that is on our attack-list.
[INFO][Bot #1][05/27 07:02:57 AM]: Found npc fight zone based on nearby npcs, proceeding!
[INFO][Bot #1][05/27 07:02:58 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:02:58 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:02:58 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:03:01 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:03:01 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:03:01 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:03:04 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:03:04 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:03:04 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:03:07 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:03:07 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:03:07 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:03:10 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:03:10 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:03:10 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:03:13 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:03:13 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:03:13 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:03:16 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:03:16 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:03:16 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:03:19 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:03:19 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:03:19 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:03:22 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:03:22 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:03:22 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:03:25 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:03:25 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:03:25 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:03:28 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:03:28 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:03:28 AM]: Changed item tho 23
[INFO][Bot #1][05/27 07:03:31 AM]: "inv_change" changed to "1"
[INFO][Bot #1][05/27 07:03:31 AM]: Changed item tho 22
[INFO][Bot #1][05/27 07:03:31 AM]: Changed item tho 23

Using mage to kill Ogress warriors (F2P). When I start the script it constantly clicks between spellbook and inventory. It stops after first kill. Small issue tbh but wierd. Same logger content is written just before casting every autocasted spell.

Also it won't pick up the loot.

I've set optimal settings for safespoting and looting in my opinion but still doesn't seem to work. I noticed that when I pick the loot manually it instantly tries to run back to the safespot.

Is there a way to safespot and loot? What settings should I use?

PS. Awesome script!

Edited by meeterdetsi
  • Like 1
Link to comment
Share on other sites
symbol Steel Poster

symbol

Posted
Posted (edited)
9 hours ago, Czar said:

Hmm maybe it is trying to loot an item too far away? Try setting the loot tile distance to something around 8 tiles. Or Maybe the loot item is around the wall and is technically 8 tiles near, in which case I will make real distance affect looting items too. Worst case scenario: a fight zone can be built and you can enable to only loot items inside the fight zone. I may be adding a new feature called “loot zone” too, will function a lot better. :D 

as for trials, will activate ASAP :D 

I had both loot tile distance and only loot on fight one set. 

Script still has safespot problems. After killing blue dragons, inv full of bones and dhide. It banks, then starts to walk back. Console says stuff about being out of safespot. When script walk to the falador wall shortcut it gets those null pointer errors and can't get past it. 

Edited by symbol
  • Like 1
Link to comment
Share on other sites
bluebuffalo83 Newbie

bluebuffalo83

Posted
Posted

I did a trial of your script and am a big fan. Is it possible to add a teleport to prevent death feature? For example, I intend on using this script with guthans so it should last a very long time but there is always a small chance that the monsters will kill me before I can heal with guthans. I would like to see a feature where the bot can click the tele to house tab in my inventory when I reach a certain hp or lower, like 12 for example.

  • Like 1
Link to comment
Share on other sites
symbol Steel Poster

symbol

Posted
Posted (edited)

@Czar

I actually got an idea. Would it be possible to add support for house portals? 

Starting with Taverley. Its way faster to get to Taverly dungeon that way.

EDIT: These should also fix the Blue dragon script problems quickly.

Even tho the loot problem would still happen occasionally.

Edited by symbol
  • Like 1
Link to comment
Share on other sites
  • Czar changed the title to Perfect Fighter AIO

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...