Lol this dude release a script for free and there's literally one post with constructive criticism lll

Just ignore them OP. People easily ridicule others but hide their code and obfuscate it so that no one can look at their mess.  

No one starts out amazing so, just keep at it, make sure to follow standards and learn more.

1 hour ago, dreameo said:

Just ignore them OP. People easily ridicule others but hide their code and obfuscate it so that no one can look at their mess.  

No one starts out amazing so, just keep at it, make sure to follow standards and learn more.

Dude literally said he doesn't care about standards. Because it's a "free" script l0l

I'm still hungry, so I'll say this.

Just because you can put a chicken in the oven, doesn't mean you can season it properly.

Edited September 13, 20178 yr by Viston

Alright so there's quite a bit wrong but I don't have time to go into detail. 

I haven't done hunter for more than 2 levels lmao so I wouldn't know about the monsters and stuff. But from what I can see, you're manually settings area positions, parsing them to an int and then there's you area. You can reduce half the work by making birdSpecs = birdNames  (Assuming that each bird area is far away from one another). 

 

Like so

String[] birdSpecs = {"Copper longtail", "Tropical wagtail", "Crimson swift", "Cerulean twitch"};

And you can make an array of Areas

Area[] area = {new Area(x,y,x2,y2), new Area()} and so on. 

And let's say all the birds are in different spots, then you can just have an area for each bird then use the same index to get the area as well. 

birdspecs[whatever]

birdArea = area[whatever];

And then you'll be able to obtain the areas like this way and won't need to go through the full mess of making an area like that way  I saw in the main page.  Also, it seems you aren't null checking everything  and you're just using exceptions to catch them for you. You should really try prevent that line of code from being reached in the first place by using a null check. 

 

if(something !=null){
//it exists
}

As for your setup booleans, if you aren't using them, then just remove them all. And if you plan on using them, please do not make 4-5 seperate booleans named setup1,2,3,4,5. There are way more efficient ways in doing this and if you look at a few tuts here, you'll find out how to use custom setups. 

 

The use of functions can help someone read the code much easily too and reduce ambiguity. 

Also, you don't seem to be adding the snares positions to a list or something like that, you'll soon find out if someone else is near you and is hunting, the bot will try to pick his traps up too(use a list so you can easily remove and add the locations).

You pretty much document the location as you plant the trap. You can do this a few ways, the main way would be to get the predicted area where the trap will be planted and then if the plant was successful add that location into the list, else you don't. 

So much more could be done differently, but I just don't have the time to go over everything. Just look at a few tutorials in the forum and you'll know what I mean. Seems pretty good for a first script (if it's your first) and don't worry, there's always room to improve. You will improve much more when u get used to it. 

34 minutes ago, Satire said:

Alright so there's quite a bit wrong but I don't have time to go into detail. 

I haven't done hunter for more than 2 levels lmao so I wouldn't know about the monsters and stuff. But from what I can see, you're manually settings area positions, parsing them to an int and then there's you area. You can reduce half the work by making birdSpecs = birdNames  (Assuming that each bird area is far away from one another). 

 

Like so

String[] birdSpecs = {"Copper longtail", "Tropical wagtail", "Crimson swift", "Cerulean twitch"};

And you can make an array of Areas

Area[] area = {new Area(x,y,x2,y2), new Area()} and so on. 

And let's say all the birds are in different spots, then you can just have an area for each bird then use the same index to get the area as well. 

birdspecs[whatever]

birdArea = area[whatever];

And then you'll be able to obtain the areas like this way and won't need to go through the full mess of making an area like that way  I saw in the main page.  Also, it seems you aren't null checking everything  and you're just using exceptions to catch them for you. You should really try prevent that line of code from being reached in the first place by using a null check. 

 

if(something !=null){
//it exists
}

As for your setup booleans, if you aren't using them, then just remove them all. And if you plan on using them, please do not make 4-5 seperate booleans named setup1,2,3,4,5. There are way more efficient ways in doing this and if you look at a few tuts here, you'll find out how to use custom setups. 

 

The use of functions can help someone read the code much easily too and reduce ambiguity. 

Also, you don't seem to be adding the snares positions to a list or something like that, you'll soon find out if someone else is near you and is hunting, the bot will try to pick his traps up too(use a list so you can easily remove and add the locations).

You pretty much document the location as you plant the trap. You can do this a few ways, the main way would be to get the predicted area where the trap will be planted and then if the plant was successful add that location into the list, else you don't. 

So much more could be done differently, but I just don't have the time to go over everything. Just look at a few tutorials in the forum and you'll know what I mean. Seems pretty good for a first script (if it's your first) and don't worry, there's always room to improve. You will improve much more when u get used to it. 

Hey bro I appreciate the effort in this post but the first two sections I actually already knew. I coded this script pretty quickly and just wanted it for myself originally but decided to add the other bird locations and just give it to whoever wanted it. The third part about adding the snare locations...I'm not sure why I didn't do that. I've done similarly before and I guess I just didn't think of it. Will definitely add that so it doesn't pick up other peoples' snares thanks for the tip

P.S. lol i totally forgot about setup1,2,3,4,5. Was gonna be part of a very basic original code idea, and I worked myself out of that idea and into a different tangent.

1 hour ago, Viston said:

Dude literally said he doesn't care about standards. Because it's a "free" script l0l

I'm still hungry, so I'll say this.

Just because you can put a chicken in the oven, doesn't mean you can season it properly.

U mad bro? Lemme go decompile your best script and see what's what lol

EDIT: Viston you crack me the fuck up. You literally have....one script? vHosidius and i've coded the equivalent of that (bank, use item on item, maybe widget interaction, wait) in less than five minutes and they gave you Scripter I for that? Jesus christ please stop pretending you have ANY room to talk about code when your best release script to date is a joke. 

Edited September 13, 20178 yr by TTScripts

7 hours ago, TTScripts said:

Hey bro I appreciate the effort in this post but the first two sections I actually already knew. I coded this script pretty quickly and just wanted it for myself originally but decided to add the other bird locations and just give it to whoever wanted it. The third part about adding the snare locations...I'm not sure why I didn't do that. I've done similarly before and I guess I just didn't think of it. Will definitely add that so it doesn't pick up other peoples' snares thanks for the tip

P.S. lol i totally forgot about setup1,2,3,4,5. Was gonna be part of a very basic original code idea, and I worked myself out of that idea and into a different tangent.

U mad bro? Lemme go decompile your best script and see what's what lol

EDIT: Viston you crack me the fuck up. You literally have....one script? vHosidius and i've coded the equivalent of that (bank, use item on item, maybe widget interaction, wait) in less than five minutes and they gave you Scripter I for that? Jesus christ please stop pretending you have ANY room to talk about code when your best release script to date is a joke. 

 You do realise you get your S1 rank when you release a script on the SDN, right? You don't get your rank by releasing a script under unofficial scripts. I didn't get my S1 rank from vHosidious lol

Now, I'm not trying to hate on you, I like that you've put effort and all of that, that's good. But your attitude is all messed up bro.

10 hours ago, dreameo said:

Just ignore them OP. People easily ridicule others but hide their code and obfuscate it so that no one can look at their mess.  

No one starts out amazing so, just keep at it, make sure to follow standards and learn more.

And to think you abused me for one try catch   

I love you too

What if this is one big bait for him to get 100 PC 

What @Team Cape is saying is correct. If you have any aspirations to better your ability you're never going to achieve that with your current attitude. Imagine you wanted to add a new set of features to this script, you're going to need a lot of duck tape to keep it together...

Edited September 13, 20178 yr by harrypotter

Start by fixing the onStart. You dont want to have booleans like that because what if someone ==null? Then it won't ever store the value. 
Also you don't need to catch errors like that but instead !=null to check if exists. 
Good luck, i suggest starting from scratch and rewriting it all if you truly want to learn and better your scripting progress. 

1 hour ago, harrypotter said:

What @Team Cape is saying is correct. If you have any aspirations to better your ability you're never going to achieve that with your current attitude. Imagine you wanted to add a new set of features to this script, you're going to need a lot of duck tape to keep it together...

I'm already working on new features and no duct tape is necessary.

20 minutes ago, Juggles said:

Start by fixing the onStart. You dont want to have booleans like that because what if someone ==null? Then it won't ever store the value. 
Also you don't need to catch errors like that but instead !=null to check if exists. 
Good luck, i suggest starting from scratch and rewriting it all if you truly want to learn and better your scripting progress. 

Already fixed and will be on the next update. I will not be starting from scratch as I've already removed some of the sloppy code. I plan on releasing on SDN but know it needs to be a bit cleaner to get approved.

7 minutes ago, TTScripts said:

I'm already working on new features and no duct tape is necessary.

Already fixed and will be on the next update. I will not be starting from scratch as I've already removed some of the sloppy code. I plan on releasing on SDN but know it needs to be a bit cleaner to get approved.

Once youve finished your second version, post here so we can gibe constructive criticism. 

Alek is very big on neat clean scripts using java conventions correctly before accepting S1. 

44 minutes ago, TTScripts said:

I'm already working on new features and no duct tape is necessary.

Already fixed and will be on the next update. I will not be starting from scratch as I've already removed some of the sloppy code. I plan on releasing on SDN but know it needs to be a bit cleaner to get approved.

If you ever need help, just post in the Scripter Help section and at least 5 scripters will respond to help you, or come into the chatbox. You don't get better by people telling you how great of a job you did. You get better through hard criticism. 

35 minutes ago, Juggles said:

Once youve finished your second version, post here so we can gibe constructive criticism. 

Alek is very big on neat clean scripts using java conventions correctly before accepting S1. 

No my second version will include more features and will be the one I apply to the SDN application. 

I'm aware. My code I send to Alex will be cleaner. You guys seem to forget this is just a free script I threw together in like an hour.