Everything posted by Eagle Scripts
-
First script feedback
@Override public final void onStart() { } No need to include this if you're simply overriding a method with an empty body. You can remove the entire onStart . ^^ Same applies for onPaint. private void walkToChickenPen(){ Area chickenPen = new Area(3225, 3301, 3235, 3288); log("Walking back to pen"); getWalking().webWalk(chickenPen); //Web as gate may be closed log("Back at pen"); } you can move the chickenPen up one level: private static final Area CHICKEN_PEN = new Area(3225, 3301, 3235, 3288); fightChicken(); new ConditionalSleep(5000, 500) { @Override public boolean condition() throws InterruptedException { log("Waiting to see if we fight a chicken"); return (getCombat().isFighting() || !myPlayer().isMoving()) ; } }.sleep(); Since you're already making a separate method for attacking the chicken; why not sleep inside that method as well? Remove the sleep here. private boolean fightChicken(){ NPC chicken = npcs.closest(new Filter<NPC>() { @Override public boolean match (NPC npc) { return npc.exists() && npc.getName().equals("Chicken") && npc.isAttackable() && npc.getHealthPercent() >0; } }); if (chicken == null){ log("Found no chickens :("); return false; } else { if(chicken.isOnScreen()) { chicken.interact("Attack"); log("Fight that chicken"); return true; } else { //how? return false; } } } The above method can be refactored to: private void fightChicken(){ final NPC chicken = getNpcs().closest(npc -> npc.exists() && npc.getName().equals("Chicken") && npc.isAttackable() && npc.getHealthPercent() > 0); if (chicken != null) { if (chicken.isOnScreen()) { log("Fight that chicken"); if (chicken.interact("Attack")) { new ConditionalSleep(5000, 500) { @Override public boolean condition() throws InterruptedException { log("Waiting to see if we fight a chicken"); return (getCombat().isFighting() || !myPlayer().isMoving()) ; } }.sleep(); } } } else { log("Found no chickens :("); } } Also; notice how I changed the method's type from boolean to void? There's no point in making it a boolean method if you're not doing anything with its return value .
-
AIO Construction
The OT states how to start it
-
AIO MTA - Beta Slots
Please visit my Discord and ask for the beta status. Make sure to give your OSBot Profile in there to verify it's you. https://discord.gg/tvXQfwa
-
AIO Construction
Granted
-
AIO Construction
Went ahead and granted you a trial. If the script does not turn up in your script selector it means you've already had your trial once .
-
AIO MTA - Beta Slots
You've been granted access to the beta.
-
SocialGFX Design Shop |07GP|PP| Discord: Ostdarva#2698
@SocialGFX Somehow my Discord won't send you a friend's request. Could you send me one instead? Eagle Scripts#5266
-
Khal AIO Fletcher
It's not necessarily bad but the old one was 10x better
-
Khal AIO Fletcher
Nice one! On a more serious note: where is that good-looking old khal paint?
-
AIO Construction
Sure thing! Granted
-
[10 Minute Scripts] Make an AIO Fighter Script in 10 Minutes??? (Part 1)
10 min Zulrah next?
-
AIO Construction
Both granted .
-
AIO Farming
Granted!
-
AIO Farming
Of course. Granted
-
Malcolm's Private Script Shop! [Fast] [Customized] [Reliable] [Competent] [Committed] [Lifetime Maintenance]
You can ask them to change that up so you've got a sexy colour
-
Eagle Plunder
Alright. Please write a bug report for each of the issues that you're encountering. As for the feature request; I'm sorry to say that I'm currently not taking feature requests for this script.
-
Eagle Plunder
Sure thing. Granted .
-
Eagle Plunder
Are you using mirror mode?
-
AIO Farming
Since bans happen with any script; not necessarily. If you can supply me with an account that has access to trollheim I could add it in.
-
AIO Construction
Granted .
-
AIO Construction
Granted.
-
AIO Construction
It seems you've already had your trial once.
-
AIO Farming
Granted.
-
AIO Construction
Yeah. Trial granted.
-
AIO Construction
Sure thing. Granted