Ace99

Thanks for the input! I thought of making the drop down menu "grey out" options that did not have the required level but I like the color idea now. Thanks guys!

Couple time savers: Make sure to null check everything you can in order to reduce the amount of times the client freezes during development Log a comment as often as possible to see where a bug may be hiding in the logger

I've been running for a bit, mirror mode.

Hello and welcome to my second script! Not an AIO herb script... there are many of these on the SDN so I tried to think outside the box at what these scripts did not offer. I wanted to create a very user friendly way to quickly make money with low requirements to keep bonded accounts/bots bonded. Making an unfinished potions account takes 10 minutes and can start making money right away. With a little investment in the herb skill the profit can grow significantly. Script Features: Gathers GE profit points for each potion type Displays them in a GUI for the user to pick the best option GE function to buy supplies for a designated amount of potion to make. Speed selection to dictate how fast the script runs and how the script idles when making potions. Greens potion name in the GUI to show what potions the account can make. How to use: Start script and wait to review estimated profits per hour (do your own margin checks for exact price points) Select the potion you would like to make Select if you want the script to use the GE to buy supplies (buy your own materials for maximum profit per hour) Select speed at witch to run the script Consider: Having the vials of water and clean herbs next to each other in the bank Double check your gold on the account to make sure it can buy the desired amount of supplies selected Again... buy your own supplies for max profit Potential future Improvements: Option to sell potions back to get money for more materials Option to buy grimy herbs to clean first in order to make more money TBD - suggestions welcome In the end this was another fun script to make and I learned a lot along the way. I hope this helps people make money and stay bonded in all their endeavors. All constructive criticism is welcome. Shout out to a few snippets I used: @NoxMerc for the GE functions - I had to make a few tweaks to the widgets and buying function to account for the new "previous item" change @BravoTaco for the GE price pulling - no tweaks needed

The class name was not the same as its .java file.

I messaged you, I can try to help in disc for what its worth. Hit me up on there if you feel like it and hopefully I can help.

Make sure you have the ScriptManifest above the main class @ScriptManifest(author = "", name = "", logo = "", version = 1.0 , info = "") public class Main extends Script{ //onStart //onLoop //onExit }

You need to make a GUI, put a Combo Box in the GUI, assigned the array to the combo box, then add a listener to the GUI to retrieve the selected item in the combo box (selected bank in this case). Take a look at Explv GUI tutorial here:

pic == null

Check this thread out. This shows what @BravoTaco was talking about by making an "object next" and an "object last." You can keep your enum instead of the two string arrays in the link.

Back to scratch the itch again?

Just don't put it on a table in upstairs varrock or anything of the sort. It will disappear now.

Plenty of threads about tips and tricks, a recent one is here Walking on this ice trying to keep a main though, good luck!

@Chris I am still getting errors and have been stuck for hours! Shame its a GUI error of all things to be stuck on. Ill put my file structure, code, and error if you have time to review (or anyone)! I have been tunnel visioning this so hard I may be missing something obvious. import org.osbot.rs07.script.Script; import org.osbot.rs07.script.ScriptManifest; import javax.imageio.ImageIO; import javax.swing.*; import java.awt.*; import java.io.IOException; @ScriptManifest(author = "Ace99", name = "Test GUI", logo = "", version = 1.0 , info = "") public class Main extends Script { Image guam; @Override public void onStart() throws InterruptedException { try { this.guam = ImageIO.read(getScriptResourceAsStream("resources/Guam_potion_(unf).png")); } catch (IOException e) { e.printStackTrace(); } JFrame frame = new JFrame("Does this work?" ); ImageIcon guamPic = new ImageIcon(guam); JLabel picture = new JLabel(); picture.setIcon(guamPic); picture.setBounds(10,10,200,200); frame.add(picture); frame.pack(); frame.setLocationRelativeTo(null); frame.setLayout(null); frame.setDefaultCloseOperation(JFrame.DO_NOTHING_ON_CLOSE); frame.setSize(430, 300); frame.setVisible(true); /* if (guam != null) { log("found it"); } else { log("waiting around"); sleep(15000); } */ super.onStart(); } @Override public int onLoop() throws InterruptedException { return 500; } }

In the onExit() method you can log the time of that session (this would be session botted not actually logged in assuming you have breaks set). You can have that sent to a discord server you own for your bots and then manually add up the times every day/week/month. More advanced version of this would be to send the session data to a web server and have it do the additions for you. This post is on the featured section about that.

Kiss your main goodbye that way. You want a main and to bot, you never let the two come in contact, via the game or IPs. The more you care about the main the more precautions you take.

Yeah thanks I saw that after I replied. I had my folder structure off for sure. I don't get null error anymore so I think it found the image and I have JLabel issues to work out. Much appreciated!

But the JLabel requires an ImageIcon not just BufferedImage or Image?

I know the first post on this page is pinned and says how to use the Resource folder... but I am still stuck. I also know there is a Data folder but I don't want that unless I have to. I can make my GUI run as a stand alone JAR without OSBot and images load from resources, but once the client tries to do it the pics are null. It is about 14 pics so I do not want to pull from imgur. Checking the JAR in the OSBot/Scripts folder I see the resources are built into the JAR. Folder structure: Script.jar -->resources/ -->images.png -->src/ -->Main -->GUI Code in GUI: public ImageIcon pic; public class GUI{ public void setImages(){ this.pic = new ImageIcon(getClass().getResource("images.png")); **** error on this line in GUI ***** } } Code in Main: ... public void onStart() { GUI gui = new GUI(); try { gui.setImages(); ***** error on this line in main ***** } catch (IOException e) { e.printStackTrace(); } try { gui.GUI(); } catch (IOException e) { e.printStackTrace(); } }

Yeah no one wants cannonballs to be 1k+ each or then have to make them their-selves. Nuking all bots like that would ruin the cannon, and any game-play that involves it. Just one scenario but the ripple effect would hurt them more than help them in those aspects.

Solid info. Do you turn a profit with 45 accounts month to month? No need for details on how much either way.

Awesome stuff

Any script used when wearing the typical botter outfit... Bald, goatee, tan shirt, green pants lol

Start small is key like you said, just getting overwhelmed is a bad way to quit something. Keep us updated

Any sort of "anti-ban" is just a placebo effect. There is a post on here by @Alek (I think) that I cannot find right now explaining it all. No spinning camera, checking exp, right clicking random things. If you want to learn Java for fun then read up on the OSBot API and yes the link above to @Explv guide - it is how I started.