VersaceGod Posted March 25, 2016 Share Posted March 25, 2016 Versace Goblin Killer By: VersaceGod Released: March 25th, 2016 Features: Kills Goblins Everywhere. Opens doors if doors are closed. Simple AntiBan Features (Random Mouse Movements, Skill tab hovering, etc) Combat EXP gained Paint (Hitpoints, Attack, Strength, Defense, Ranged, Magic) Download Links: GitHub: https://github.com/VersaceGod/Versace-Goblin-Killer-0.1 jar File: https://www.dropbox.com/s/xk87owgpqk19g71/VersaceGoblinKiller.jar?dl=0 Coming Soon: More AntiBan Features Progress Report Ability to Open Gates 3 Quote Link to comment Share on other sites More sharing options...
CharChar Posted March 25, 2016 Share Posted March 25, 2016 Ooo NIce! Quote Link to comment Share on other sites More sharing options...
RC7 Posted March 25, 2016 Share Posted March 25, 2016 is that you in the pic? lol Quote Link to comment Share on other sites More sharing options...
Prolax Posted March 25, 2016 Share Posted March 25, 2016 Yes, it's him. He is black and only wears Versace, Gucci and Armani. Quote Link to comment Share on other sites More sharing options...
Khaleesi Posted March 25, 2016 Share Posted March 25, 2016 Looks very good to me for a first script Quick question,isn't the script opening the door everytime it closes, even though it not required to have it open to reach other goblins? You could change to logic to: (now only opens door when it has to attack a goblin which you can't reach) Npc gob = getGoblin(); if(gob != nullç{ if(getmap().canReach(gob)){ //attack gob }else{ getDoorhandler().handleNextobstacle(gob); sleep(500,1000) } } Someother things you can improve (Your code works fine aswell): for(String actions: door.getDefinition().getActions()) { if(actions.contains("Open")) { } } Can be done by: door.hasAction("Open"); Also check if the interaction was succeeded, don't just simply sleep after it without checking^^ goblin.interact("Attack"); sleep(random(100, 250)); AfterAttack(); Check if was succeeded. if(goblin.interact("Attack")){ sleep(random(100, 250)); AfterAttack(); }else{ log("Failed attacking"); } Kind regards Khaleesi 1 Quote Link to comment Share on other sites More sharing options...
VersaceGod Posted March 25, 2016 Author Share Posted March 25, 2016 Looks very good to me for a first script Quick question,isn't the script opening the door everytime it closes, even though it not required to have it open to reach other goblins? You could change to logic to: (now only opens door when it has to attack a goblin which you can't reach) Npc gob = getGoblin(); if(gob != nullç{ if(getmap().canReach(gob)){ //attack gob }else{ getDoorhandler().handleNextobstacle(gob); sleep(500,1000) } } Someother things you can improve (Your code works fine aswell): for(String actions: door.getDefinition().getActions()) { if(actions.contains("Open")) { } } Can be done by: door.hasAction("Open"); Also check if the interaction was succeeded, don't just simply sleep after it without checking^^ goblin.interact("Attack"); sleep(random(100, 250)); AfterAttack(); Check if was succeeded. if(goblin.interact("Attack")){ sleep(random(100, 250)); AfterAttack(); }else{ log("Failed attacking"); } Kind regards Khaleesi Thanks for the feedback, I'll be updating it in a few days and this will be super useful! is that you in the pic? lol No, that is not me lmao 1 Quote Link to comment Share on other sites More sharing options...
Southperk Posted March 31, 2016 Share Posted March 31, 2016 Sorry to be a noob with this but where do I save the jar file to be able to use this? Quote Link to comment Share on other sites More sharing options...
GaetanoH Posted March 31, 2016 Share Posted March 31, 2016 Sorry to be a noob with this but where do I save the jar file to be able to use this?In the OSBot/Scripts directory Quote Link to comment Share on other sites More sharing options...
Gold Scripts Posted March 31, 2016 Share Posted March 31, 2016 Versace Versace!!! Nice first script, looking good man 1 Quote Link to comment Share on other sites More sharing options...
Rushomi Posted April 5, 2016 Share Posted April 5, 2016 In the OSBot/Scripts directory hmm is it not suppose to be saved in osbot local folder or is it just me?? Quote Link to comment Share on other sites More sharing options...
GaetanoH Posted April 5, 2016 Share Posted April 5, 2016 hmm is it not suppose to be saved in osbot local folder or is it just me?? No I think that doesn't work Quote Link to comment Share on other sites More sharing options...