1. OSBot Version (do NOT put "current version", be specific)

2.5.31

2. A description of the issue. Include relevant logs.

Ok so I start my bot using CLI and the past week or so I noticed that sometimes when I run an account it will run the same script twice. What happens then is it will perform every task twice i.e (withdrawing item from bank it will right click twice, trade account it will trade twice).  As you can see  in the logger it is performing the Web walking event twice. It seems  "Script executor is taking too long to suspend; restarting now..." is causing it. 

Seems to happen when the account starts in lumby and performs first task which is webwalking to varrock. 

CLI COMMAND:      java -jar "osbot 2.5.31.jar" -login  -world 417 -bot  -mem d -script Slavev10:MuleNAME
TIMEOUT /T 15 /NOBREAK

[INFO][Bot #1][12/22 10:20:23 AM]: Loaded 3 built-in random solvers!
[INFO][Bot #1][12/22 10:20:27 AM]: Started random solver : Auto Login
[INFO][Bot #1][12/22 10:20:32 AM]: Successfully logged in, waiting for welcome screen.
[INFO][Bot #1][12/22 10:20:32 AM]: Random solver exited : Auto Login
[INFO][Bot #1][12/22 10:20:35 AM]: Started script : Slavev10
[WARN][Bot #1][12/22 10:20:41 AM]: Script executor is taking too long to suspend; restarting now...
[INFO][Bot #1][12/22 10:20:41 AM]: Started random solver : Welcome Screen
[INFO][Bot #1][12/22 10:20:45 AM]: Random solver exited : Welcome Screen
[INFO][Bot #1][12/22 10:22:18 AM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][12/22 10:22:18 AM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][12/22 10:22:25 AM]: execute
[INFO][Bot #1][12/22 10:22:25 AM]: Adding name to hi3
[INFO][Bot #1][12/22 10:22:25 AM]: Adding hi4names
[INFO][Bot #1][12/22 10:22:25 AM]: execute
[INFO][Bot #1][12/22 10:23:38 AM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][12/22 10:23:38 AM]: WebWalkingEvent; We have reached the final destination!
[INFO][Bot #1][12/22 10:23:38 AM]: execute
[INFO][Bot #1][12/22 10:23:38 AM]: Adding name to hi3
[INFO][Bot #1][12/22 10:23:38 AM]: Adding hi4names
[INFO][Bot #1][12/22 10:23:38 AM]: execute

3. Are you receiving any errors in the client canvas or the logger? 

4. How can you replicate the issue? 

Happens randomly.

5. Has this issue persisted through multiple versions? If so, how far back?

I don't think so

Edited December 22, 20187 yr by GreenGrass

I'll check it out

1 hour ago, Patrick said:

I'll check it out

Okay, thank you

if it helps I think I fixed it by surrounding my walking method with

    if (script.getClient().getLoginState().equals(Client.LoginState.LOGGED_IN)) {

}

and switched to walkpath

 

Bump I see this occasionally too. Especially if you spin a bot up too quickly.

Still looking into this. Might have a fix but unconfirmed

ill look into it.

Food for thought. This only happens on local scripts in my experience. I've only seen the issue when starting/stopping a script super fast or pausing/unpausinf too many times or too fast

besides when loading the web data, does this still happen at other occasions?

I used to have it happen when my whole script was basically a 20 nested for-loops and while (First script, don't judge) and it would eventually start executing everything twice. Would do so randomly. Fixed when I made everything more functional. 

Or stopping and refreshing the scripts and waiting a few moments

I only ever get this issue while launching from Eclipse. But I only encounter it after launching/debugging for awhile. It's as if one of the scripts is never told to stop after the client is closed.

Double scripts = double the work! Sounds more like a feature to me.

 

Happens on any local script, regardless of resource usage on host

The next version might have this solved.