flewis Posted July 24, 2017 Share Posted July 24, 2017 (edited) Bone Collector Bone Collector is a script I have written that can be used anywhere on any world. Once run, Bone Collector will find any bones on the ground pick them up and bury them. Works in ANY place in F2P and P2P where players are killing mobs/monsters. Good for new bots to quickly level up Prayer. Optimised to work in all Ironman modes. What The Script Does: Collects bones from the ground and buries them automatically. Good Area's To Run The Script (Tested): Lumbridge - Goblins Lumbridge - Cows Lumbridge - Chickens Requirements: An area where mobs/monsters drop normal 'Bones'. Other Notes: This is the first ever script I have written for OSBOT so it's probably not perfect. This is also my first ever project in Java too (I usually use python). If you find bugs or anything else like that please do tell me. Also if you want to criticise my code I don't mind, I'm new to Java and criticism will help me!! TOS: Please do not claim this script as your own. Please do not sell this script. All usage is free and will stay that way for this script. Final Words: Thank you for downloading my Bone Collector script. Please leave a comment down below if you used/use the script. I want reviews even if they are negative!! Have a great day -Flewis Download Link - BoneCollector.jar Edited July 24, 2017 by flewis 1 Quote Link to comment Share on other sites More sharing options...
flewis Posted July 24, 2017 Author Share Posted July 24, 2017 (edited) Download link for anyone interested, also a pastebin in case you would like to examine the code!! Pastebin - https://pastebin.com/967KASBH Download link - BoneCollector.jar Edited July 24, 2017 by flewis Quote Link to comment Share on other sites More sharing options...
HeyImJamie Posted July 24, 2017 Share Posted July 24, 2017 Not bad for your first script. I'd suggest looking into the OSBot API a little more though as you could replace a lot of your own methods with simpler ones that've been pre-written. For example, to check if your inventory contains bones you can do: if (getInventory().contains("Bones"){ // bury them } else { // loot them Don't really need a while loop for something that simple :P 1 Quote Link to comment Share on other sites More sharing options...
flewis Posted July 25, 2017 Author Share Posted July 25, 2017 (edited) 21 minutes ago, HeyImJamie said: Not bad for your first script. I'd suggest looking into the OSBot API a little more though as you could replace a lot of your own methods with simpler ones that've been pre-written. For example, to check if your inventory contains bones you can do: if (getInventory().contains("Bones"){ // bury them } else { // loot them Don't really need a while loop for something that simple :P Okay, thank you for the advice, as time goes by I hope to make my code much more efficient!! Edited July 25, 2017 by flewis Quote Link to comment Share on other sites More sharing options...
frozen8 Posted July 25, 2017 Share Posted July 25, 2017 Is the bot that efficient to pick up bone? It look like your sleep is pretty long Quote Link to comment Share on other sites More sharing options...
flewis Posted July 25, 2017 Author Share Posted July 25, 2017 5 hours ago, frozen8 said: Is the bot that efficient to pick up bone? It look like your sleep is pretty long Yes but using Thread.sleep makes the code only delay if it's doing something. It collects them pretty quickly otherwise. Quote Link to comment Share on other sites More sharing options...
Charlotte Posted July 25, 2017 Share Posted July 25, 2017 4 hours ago, flewis said: Yes but using Thread.sleep makes the code only delay if it's doing something. It collects them pretty quickly otherwise. Though simple, you can explore conditional sleep. https://osbot.org/api/org/osbot/rs07/utility/ConditionalSleep.html Quote Link to comment Share on other sites More sharing options...
Transporter Posted July 25, 2017 Share Posted July 25, 2017 lookin gud flewis Quote Link to comment Share on other sites More sharing options...
flewis Posted July 25, 2017 Author Share Posted July 25, 2017 5 hours ago, Charlotte said: Though simple, you can explore conditional sleep. https://osbot.org/api/org/osbot/rs07/utility/ConditionalSleep.html Okay I will do thank you 4 hours ago, Transporter said: lookin gud flewis Thank you Quote Link to comment Share on other sites More sharing options...