Jump to content

Tree cutting help!

Phaibooty

By Phaibooty
in Scripting Help

 Share

Recommended Posts

Phaibooty Black Poster

Phaibooty

Posted
Posted

Hi, 

 

I'm still new to scripting and learning java while scripting..

 

but here is the code, I was wondering how would I tell the bot to only cut trees that are in the tree area? Even if it is visible, I don't want the bot to click trees that are not in the area?

import org.osbot.rs07.api.map.Area;
import org.osbot.rs07.api.model.Entity;
import org.osbot.rs07.script.Script;
import org.osbot.rs07.script.ScriptManifest;
import java.awt.*;

/**
 * Created by Phaibooty on 1/11/2017.
 */

@ScriptManifest(author = "Phaibooty", info = "Chops Logs Only", name ="LogWoodcutter", version = 1, logo ="")
public class SimpleWoodcutter extends Script {

    final String tree_name = "Tree";
    final Area BANK_AREA = new Area(3092,3040,3097,3246);
    final Area Tree_Area = new Area(3103,3226,3114,3233);
    final int BANK_BOOTH_ID = 23961;

    @[member=Override]
    //Code used at Start
    public void onStart() {
        log("lets get started!");
        log("This is where the code begins.");

    }

    @[member=Override]
        public int onLoop() throws InterruptedException {

        if(!inventory.isFull()){
            //Chop
        	
        	if(Tree_Area.contains(myPlayer())){
            Entity tree = objects.closest(tree_name);
            if (tree != null) {
                if (tree.isVisible()) {
                	if(!myPlayer().isAnimating()){
                		if(!myPlayer().isMoving()){
                    tree.interact("Chop down");
                    sleep(random(700,800));
                	}
                } 
            } else {
                    camera.toEntity(tree);
                }
            }
        } else {
        	getWalking().webWalk(Tree_Area);
        }
        }else {
            //bank
        	if (BANK_AREA.contains(myPlayer())){
        		Entity bankbooth = objects.closest(BANK_BOOTH_ID);
        		
        		if(bank.isOpen()){
        			bank.depositAll();
        			
        		}
        		if (bankbooth != null){
        			if(bankbooth.isVisible()){
        				bankbooth.interact("Bank");
        				sleep(random(700,800));
        			}
        			
        		}
       		
        	} else {
        		getWalking().webWalk(BANK_AREA);
        	}
        }

        return random(200, 300);
    }

    @[member=Override]
    //Code used at End
    public void onExit(){
        log("Thanks for using my woodcutter!");
    }

    @[member=Override]
    public void onPaint(Graphics2D g) {

    }

}

Code is really messy and I'm still confused... but hopefully some guidance will help.

Link to comment
Share on other sites
Phaibooty Black Poster

Phaibooty

Posted
  • Author
Posted

Isn't there an area#contains(Entity entity)?

 

If (Tree_area.contains(tree)) {

}

 

or smth

 

Thank you!

 

Gave this a try, and works beautifully.

 

Still a little confused on where I should put it, but I guess that just comes with more java knowledge lol.

 

I put it right before tree.isVisible..

 

  @[member=Override]
        public int onLoop() throws InterruptedException {


        if(!inventory.isFull()){
            //Chop
         
         if(Tree_Area.contains(myPlayer())){
            Entity tree = objects.closest(tree_name);
            if (tree != null) {
             if (Tree_Area.contains(tree))
                if (tree.isVisible()) {
                 if(!myPlayer().isAnimating()){
                 if(!myPlayer().isMoving()){
                    tree.interact("Chop down");
                    sleep(random(700,800));
                 }
                } 
            } else {
                    camera.toEntity(tree);
                }
            }

RS2Object tree = getObjects().closest(AREA_HERE, TREE_NAME HERE);

 

check out the api here for more options:

 

http://osbot.org/api/org/osbot/rs07/api/EntityAPI.html

 

shit, explains why it stops chopping after 1 tree. lmao

 

Still a little confused on how to use that line of code but I'll keep reading. Thank you!

Link to comment
Share on other sites
Precise Adamantite Poster

Precise

Posted
Posted (edited)

Thank you!

 

Gave this a try, and works beautifully.

 

Still a little confused on where I should put it, but I guess that just comes with more java knowledge lol.

 

I put it right before tree.isVisible..

 

  @[member='Override']
        public int onLoop() throws InterruptedException {


        if(!inventory.isFull()){
            //Chop
         
         if(Tree_Area.contains(myPlayer())){
            Entity tree = objects.closest(tree_name);
            if (tree != null) {
             if (Tree_Area.contains(tree))
                if (tree.isVisible()) {
                 if(!myPlayer().isAnimating()){
                 if(!myPlayer().isMoving()){
                    tree.interact("Chop down");
                    sleep(random(700,800));
                 }
                } 
            } else {
                    camera.toEntity(tree);
                }
            }

 

shit, explains why it stops chopping after 1 tree. lmao

 

Still a little confused on how to use that line of code but I'll keep reading. Thank you!

 

here is what it could look like:

 

if(!getInventory().isFull()) {
		            //Chop
			        if(!myPlayer().isAnimating() && !myPlayer().isMoving()) {
			        	 if(TREE_AREA.contains(myPlayer())) {
			        		 Entity tree = getObjects().closest(AREA_HERE, TREE_NAME);
			        		 if (tree != null) {
			        			 if(tree.interact("CHOP??"))
			        				 add sleep here
			        		 }
			        	 }
			        }
		        }
Edited by Precise
  • Like 2
Link to comment
Share on other sites
Phaibooty Black Poster

Phaibooty

Posted
  • Author
Posted

 

here is what it could look like:

 

if(!getInventory().isFull()) {
		            //Chop
			        if(!myPlayer().isAnimating() && !myPlayer().isMoving()) {
			        	 if(TREE_AREA.contains(myPlayer())) {
			        		 Entity tree = getObjects().closest(AREA_HERE, TREE_NAME);
			        		 if (tree != null) {
			        			 if(tree.interact("CHOP??"))
			        				 add sleep here
			        		 }
			        	 }
			        }
		        }

 

 

Thank you! I appreciate the help. It works beautifully now.

 

Going to do more studying lmao. thanks again

  • Like 2
Link to comment
Share on other sites
Sphiinx Newbie

Sphiinx

Posted
Posted

Thank you! I appreciate the help. It works beautifully now.

 

Going to do more studying lmao. thanks again

 

If you're curious to learn more about Java specifically to grow your knowledge, I would recommend these two sources. They're fantastic sources!

 

Source one: 

 

Source two: http://mooc.fi/english.html

Link to comment
Share on other sites
progamerz Rune Poster

progamerz

Posted
Posted 
if (BANK_AREA.contains(myPlayer())){
        		Entity bankbooth = objects.closest(BANK_BOOTH_ID);
        		
        		if(bank.isOpen()){
        			bank.depositAll();
        			
        		}
        		if (bankbooth != null){
        			if(bankbooth.isVisible()){
        				bankbooth.interact("Bank");
        				sleep(random(700,800));
        			}
        			
        		}

Now there is no need for

Entity bankbooth = objects.closest(BANK_BOOTH_ID);

Instead you can simply use the Bank(Api) to open by using:

getBank().open();

And the second thing is that the logic is wrong instead you can do:

if (BANK_AREA.contains(myPlayer())){
        		
        		if(bank.isOpen()){ // If bank is opened deposit all
        			bank.depositAll();
        			
        		} else { // If bank is not opened open it
        			getBank().open();
                                new ConditionalSleep(5000) { // Conditional Sleep 5000ms untill bank is open.
					@[member=Override]
					public boolean condition() throws InterruptedException {
						return getBank().isOpen();
						}
					}.sleep();
        		}
Link to comment
Share on other sites
Phaibooty Black Poster

Phaibooty

Posted
  • Author
Posted 
if (BANK_AREA.contains(myPlayer())){
        		Entity bankbooth = objects.closest(BANK_BOOTH_ID);
        		
        		if(bank.isOpen()){
        			bank.depositAll();
        			
        		}
        		if (bankbooth != null){
        			if(bankbooth.isVisible()){
        				bankbooth.interact("Bank");
        				sleep(random(700,800));
        			}
        			
        		}

Now there is no need for

Entity bankbooth = objects.closest(BANK_BOOTH_ID);

Instead you can simply use the Bank(Api) to open by using:

getBank().open();

And the second thing is that the logic is wrong instead you can do:

if (BANK_AREA.contains(myPlayer())){
        		
        		if(bank.isOpen()){ // If bank is opened deposit all
        			bank.depositAll();
        			
        		} else { // If bank is not opened open it
        			getBank().open();
                                new ConditionalSleep(5000) { // Conditional Sleep 5000ms untill bank is open.
					@[member='Override']
					public boolean condition() throws InterruptedException {
						return getBank().isOpen();
						}
					}.sleep();
        		}

 

Wow. Beautiful. Thank you for the help. 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...