Jump to content

Ace99

Scripter I
 View Profile  See their activity

  • Posts

    81

  • Joined

  • Last visited

  • Feedback

    100%

 Content Type 

Posts posted by Ace99

    While (Loops Bad Practice? and Unexpected Result)

    in Scripting Help

    Posted

    As many mentioned above you were right on the following:

    • My while loop condition was met and was logging that it was met but the loop continued - mirror mode thread issue i guess
    • The Area loop itself was an issue as well because when the code is in the foreach loop it does not hit the return on the onLoop() until the whole Area loop is done - allowing the false return on a boolean inside the Area loop to continue the code rather than loop back through until it is true

    I have resorted to the list of if statements - will let you know if the outcome is better after I get the correct logic on all this restructuring.

    While (Loops Bad Practice? and Unexpected Result)

    in Scripting Help

    Posted

    6 hours ago, Impensus said:

    As for your specific issue, the .webWalk should handle objects like doors?

    I am using a home teleport and nexus/wall mounted things.  I get a false return when the nexus, for example, is not in the screen view so it has to rotate the camera. Then after that else catch it moves onto the false return and I am stuck somewhere like that. Maybe I can adjust that 'if' functionality specially... thanks for the feedback I am going to look into the list of if statements after I try @BravoTaco idea to add a counter in the while loop to catch endless loops.  So far I have not had a mirror mode issue either.

    6 hours ago, Wolk said:

    I have never used a while loop, ever. Never saw/had the need of using them. 

    Never say never 😉

    6 hours ago, azuresuN said:

    you will have to really make sure, that you will match your break conditions perfectly

    I definitely do and will use the count method above as a fail-safe.  These areas are pretty much staples so I do not foresee this as an issue but who knows. I will keep tabs on the updates they make to the game for sure.

    While (Loops Bad Practice? and Unexpected Result)

    in Scripting Help

    Posted

    Discussion:

    I think I have read from time to time that having a while loop in the main loop is a bad idea/bad practice.  Can someone explain why this is?  Loops are nested in loops all the time (small applications), what is the issue here that makes it different?

    Issue:

    I loop though the keyset of a hashmap and run a set of tasks for each key, once complete I set the key value to true and move on.  Part of my task is to get to a specific area.  If I use this: 

    // initial bank for items

for(Area in Areas){
      if(!Area.contains(myPlayer){
        walkTo(Area); // This is a boolean only returning true when Area.contains(myPlayer)
      }
       //  Do actions at area
     }

    Sometimes the bot will not be at the Area and all the sudden move to //  Do action at area.  I assume the walkTo(Area) hit a false return.  So instead I can do: 

    // initial bank for items

for(Area in Areas){
      while(!Area.contains(myPlayer){
        walkTo(Area); // This is a boolean only returning true when Area.contains(myPlayer)
      }
       //  Do actions at area
     }

    And when a false is hit on walkTo(Area) it will try it again and move the screen and find to door/portal is is not finding currently.

    Is there anything wrong with this or a better yet, a cleaner way to accomplish this?

    Ace Unfinished Potions

    in VIP Scripts

    Posted

    On 6/10/2020 at 3:28 PM, Ya Boi Blue said:

    Hey great script. Giving this a go now. Good little in between script to run.

     

    So far so good!

     

    Thanks :)

    Awesome thanks for the feedback!

     

    On 6/12/2020 at 3:01 PM, jesenican said:

    so any proggies?

    People can feel free to post, that would be cool.

     

    On 6/15/2020 at 12:41 AM, KuroMario said:

    I added it on the sdn but it isn't showing up in my scripts list, other scripts I added afterward have shown up.

    Not sure on that one - out of my realm. Make sure OSBot is up to date and refresh 😕

    Notified of a bug with the GP/hr in the GUI - URL changed for the GE, update has been made and should be available in 24-48 hours.  Loading seems slower with this change... I will hopefully figure out how to optimize that better.

    Thanks again to @TheRealWhistles for the heads up.

    General advice for debugging slow/unresponsive scripts?

    in Scripting Help

    Posted

    My best go-to's are to comment everything new and then uncomment it piece by piece so you know what works well, and then just log everything and track the log to see what is being logged during a period of lag/freezing.

    You could be calling something an unreal amount of times and not know it, creating an object over and over, not caching info efficiently, or not creating optimal methods/loops in general.

    Do you have multiple threads running, external API calls, web interfacing? Address things like that.

    Why is this code not working?

    in Scripting Help

    Posted · Edited by Ace99

    On 5/25/2020 at 5:32 PM, Lol_marcus said:

    I'll use an array later to add all doses later.

    This is not related to your actual question, just a suggestion:

    Try using a Filter<Item> to grab all the energy pots at various doses, if you haven't already

    CyberSec vs WebDev

    in Spam/Off Topic

    Posted

    2 hours ago, Swizzbeat said:

    Not sure where you're getting the "saturated market makes it hard to get an entry job" from. No one is coming out of school with full stack knowledge unless they have their own portfolio which makes it very easy to stand out in interviews. School curriculum hasn't caught up to the new, commonly used tech stacks.

    Most everywhere I read/see has said what I said.  Seems to be a lot of entry level personnel that is easily replaceable which makes it hard to stay somewhere and get years of exp under the belt.  I like your point on school curriculum being behind, that makes sense.

     

    32 minutes ago, D9BLADEE said:

    As Swizz said, if you decide to go into CyberSec it's a matter of getting certificates.

    Yeah I would follow a pretty standard approach to getting all certs and then take my shot.  I understand I would have to deal with some help desk/network admin stuff for a bit but would not want to stay permanent.

    DevOps is something I had not looked into so I will start to do so.  Having my degrees not related to this is a pretty big kick in the nuts, but that is why I was leaning towards getting all the certs to get into the industry of Sec or work up some portfolio magic and prove I can be a good Dev to a company.

    CyberSec vs WebDev

    in Spam/Off Topic

    Posted

    Anyone in these fields able to speak to how they like it or expectations vs reality? More specifically Red Team InfoSec or a Full Stack Dev.

    At a fork in my career and want to pursuer one or the other.  Have two degrees but not in an IT or Computer Science field.

    From my research here is a brief summary of what I see:

    CyberSec

    • Make more money early on
    • Easier entry level job opportunity
    • May get stuck in Help Desk Hell
    • Certifications lead to interview

    WebDev

    • Saturated market makes it hard to get entry job
    • Layoffs are prominent as a junior
    • Projects may take 10 turns in 10 different directions before finished
    • Remote work is popular
    • Need a personal portfolio for interview

    Looking for actual experience. PM me if necessary.

    Thanks!

    Remove!

    in Spam/Off Topic

    Posted

    2 hours ago, ez11 said:

    Its mod weath trying to fish for idiots kekw

    Was thinking the same thing lol... hmm lets see what accounts use this random house that has been only advertised on a bot site...

    Ace Unfinished Potions

    in VIP Scripts

    Posted

    54 minutes ago, omgperson1 said:

    Hi! I love the script, but one suggestion is if the user set their withdrawal to 14, could you make it so that it just clicks the herb and vial of water, instead of having to right click the herb and withdraw all. That way it's less clicks, and hopefully lower ban rate. 

     

    Hmm I see what you're saying.  Let me see what I can do!

    • Like 1

    [Script Help Please] Is there a better way to optimize this code?

    in Scripting Help

    Posted

    17 hours ago, Lol_marcus said:

    new ConditionalSleep(1800, 100) { @Override public boolean condition() throws InterruptedException { return getInventory().onlyContains("Molten glass"); } }.sleep();

        If you have a rune pouch in your inv for this (like your banking section makes it seem) your sleep when clickTan() is never met as your inv will never only contain molten glass.  Also to that same degree in your canTan() you don't check for the rune pouch.  There is also a check for "if you have runes to cast x spell" in the api.  Might want to use that too. Finally I think it is good practice to method everything and just use the methods in the main loop.  Organized and clear... well would be clearer if you didn't reuse method names from a tanner lol!

    Oh and to answer your main questions, look into making a custom Interaction Event.  I've only used them with interacting with the inv but it may work with a bank.  This way you don't loop 3 times for 3 seaweed clicks, the event will click all 3 times, at one time.

     

     

    • Like 1

    Hello All

    in Introductions

    Posted

    Welcome!  Don't try to do too much at one time. Managing accounts, a farm, muling, breaks, etc, along with learning to script can be a lot in for a beginner. May lead to being discouraged.  GL!

×
×
  • Create New...