Kenneh

Check if the NPC you are facing is facing you by using Character#isFacing You're missing the point. I'm just saying if character.getFacing() returns an entity then it's poorly named. Most of the stuff in this client is just straight up bad. Who in their right mind thought it was okay to clutter the methodprovider class with a whole bunch of useless methods instead of splitting it up and organizing it into their own classes. It'd be neater and wouldn't take ages to find something you're looking for.

Character#getFacing That naming is just dumb. I'm facing the npc, but not interacting, nor is it interacting with me.

Client is proving to be too shitty to code to my likings.

what do you mean shitty.... I bet if you were to show the source of this script, it'd be full of bad practices and hacky methods.

This site is nothing but a bunch of people who write shitty scripts and throw a premium tag on it

So, does osbot even have a way of getting the entities you're interacting with, and a way to get entities interacting with a npc?

Well, I just started so I ran around and collected some data and made some methods that osbot didn't provide to make things a bit easier on myself. I'd say a few days if I can stay focused.

Soon™

Veteran is specifically for if you joined on, or before, April 10, and you've been active on the forums since then Oh, that's why I don't have it. I'm active now though!

http://osbot.org/forum/topic/18539-hey-im-kenneh/

Seems extremely basic.

Awww thanx Yeah, but her stats are them same as in the real LoL right? All stats are subject to change. Nothing on PBE can be declared as final.

JavaFX does indeed look nicer than swing, but doesn't exactly perform faster. I'm glad you're going to organize the api, the current methodprovider class is a trainwreck (what the hell were you guys thinking? throwing all the methods into one class makes it really hard to find what you need). Also, hopefully in the re-write every interaction method wont throw an interrupted exception, it's annoying to deal with. If you plan on using JFX, you're going to have to release a custom jre with it because JFX won't ship with java til jre8(?). Oh yeah, and remove groovy, no one uses it. It just makes the jar obnoxiously large.

You could apply it once your script is loaded if you want. Component c = JFrame.getWindows()[0]; c.addComponentListener(new WindowSnap(c.getBounds()));

Mind sharing that canReach? ;) it's in the MethodProvider here, mostly everything is in there No idea how I didn't notice that before maybe if the API wasn't such a clusterfuck with everything thrown in one class I'd be able to find things easier

Mind sharing that canReach? ;)

I don't know why you used a 2d array instead of an array of positions.. public boolean WalkAlongPath(Position[] path, boolean forward, int distanceFromEnd) { if (distanceToPoint(forward ? path[path.length - 1].getX() : path[0].getX(), forward ? path[path.length - 1].getY() : path[0].getY()) <= distanceFromEnd) return true; else { walkPath(path, forward); return false; } } public void walkPath(Position[] path, boolean forward) { int destination = 0; for (int i = 0; i < path.length; i++) if (distanceToPoint(path[i].getX(), path[i].getY()) < distanceToPoint(path[destination].getX(), path[destination].getY())) destination = i; if (script.client.getMyPlayer().isMoving() && distanceToPoint(path[destination].getX(), path[destination].getY()) > (script.isRunning() ? 3 : 2)) return; if (forward && destination != path.length - 1 || !forward && destination != 0) destination += (forward ? 1 : -1); try { script.walk(new Position(path[destination].getX(), path[destination].getY(), 0)); script.sleep(600); } catch (InterruptedException e) { e.printStackTrace(); } } private int distanceToPoint(int pointX, int pointY) { return (int) Math.sqrt(Math.pow(script.client.getMyPlayer().getX() - pointX, 2) + Math.pow(script.client.getMyPlayer().getY() - pointY, 2)); } Also, not trying to hijack or anything.. but is there a position.isReachable() or position.canReach() ?

Hey, that's not bad. I'll add a built in price checker, maybe something that allows you select what world exactly to go to and high scores too.

"please write me a woodcutting script that I can claim as my own"

I'm from pb, but idk what you're talking about

This seems funny to play with.

Your sig bothers me.

My children, the expert has spoken. lololol

More like "as seen in multiple tutorials in 2008". Really OP, you should transform this into something useful, like a toolkit. The code itself is rather novice-ish, so it should be a good challenge for you... The toolkit widgets would of course be standalone... I'm getting a bit ahead of myself here, but you could eventually bridge information dynamically obtained from the client to extent the capabilities of said widgets, and eventually transmute it into a macro.... Maybe make that a (very) long-term goal? There will be plenty of rewrites inbetween lol. TL;DR - Make into toolkit. No. You're missing the point. I just wanted something to play on and not worry about advertisments in the client ( I don't have members ) So you don't plan on working on the code at all, but you're asking for feedback? Seems pretty pointless to me. There are quite a few alternatives in which would have allowed you to play the game without advertisements, in which would have required much less time... Like just downloading one of the other thousands of OSRS loaders floating around the web? 'sigh' that's not the point.