[FREE] Fishing Guild Fisher | Both docks - Archive

December 10, 201411 yr

Note: extremely outdated and unmaintained

This is just a quick script I made when the other scripts I tried using to fish sharks in the fishing guild didnt work, and decided to continue developing it a bit.

Started out as a private small project, but turned out that a lot of people liked it so I continued the development.

Start either at the docks or in the bank of the fishing guild, with the fishing tool in your inventory. (also supports barbarian style fishing

for sharks and swordfish/tuna)

Features:

Shark, lobster, swordfish and tuna fishing

Efficient fishing and banking methods

Supports barbarian style fishing

Human-like behavior

Update checker

Upcoming features:

Time till next level in paint

Reworked paint

Changelog:

2.0

Rewrote the whole script!

1.23

Fixed issues with fishing spot recognition

1.22

Switched fishing spot recognition technique

1.21

Fixed issue with centering the mouse

Fixed price checking

Added update checker

Further optimizations, cleaned up old inefficient code

Added option to wait before banking

1.20

Prices are now grabbed from Grand Exchange

Added failsafe methods

Cleaned up the code for increased performance

1.19

Added webwalking

Further CPU usage reduction

1.18

Fixed a banking issue

1.17

Fixed option values not corresponding to the inputted GUI ones

1.16

Disabled mouse speed option, changing the speed setting in OSBot is now deprecated

Fixed came adjusting issues (again)

1.15

Fixed camera adjusting issues

1.14

Fixed malfunctions caused by updates

1.13

Reduced CPU usage

Fixed bank deposit spamming issue

1.12

Increased waiting before interacting from 15 to 30 seconds in the GUI

Added waiting time deviation

1.11

Made starting and stopping the script a lot faster

Fixed status bugging out when fishing

1.1

Fixed bot trying to switch fishing spots which is on the other docks for real this time

Script should now be flawless

1.09

Fixed a couple GUI bugs

GUI is now centered

Optimized fishing method

1.08

Reworked GUI

Added a bunch of new options in the GUI

Reworked fishing and banking methods

1.07

Tweaked some numbers in paint

Fixed issues with status in paint

1.06

Reworked paint

Added a wanky cursor

Seperated methods into classes (now you have to decompile for the source code)

Fixed a bug where theres a 1% chance that the bot wont walk to the bank

Reworked walking paths

1.05

Fixed bot getting stuck on certain occasions

Fixed bot walking behind the bank

1.04

Added XP gained and per hour to paint

Removed a couple unnecessary lines of code to make fishing and banking faster

Cleaned up the code a bit

1.03

Added lobster, swordfish and tuna support!

Added very basic GUI

Improved paint (added percent till next level by Pug)

Made so that the script won't reach out for fishing spots that are on the other docks anymore

Changed name from Damighty's Fishing Guild Shark Fisher to Damighty's Fishing Guild Fisher

1.02
Improved paint a little bit

Made some optimizations for greater effeciency

Added a Zybez price checker (thanks to TheScrub)

1.01
Fixed bot trying to return to original location after trying to fish a fishing spot thats on the other dock

1.0
Release

Source code and bug reporting (GitHub)

Download 2.0 (Dropbox) [Latest update: 17.1.2017]

17 hour proggy:

Edited January 27, 20188 yr by Damighty

5

December 10, 201411 yr

Looks Nice.

December 10, 201411 yr

File @http://www.mediafire.com/download/dw7te93vp5yxii4/FishingGuildSharks.jar is clean.

Good luck to you on your release ^_^

1

December 11, 201411 yr

nice job, looks good!

December 11, 201411 yr

darn didnt realize that fishing guild is members only .

Also, because you posted source i'd like to ask you... Would you mind if i completely scrapped your code for a private script? (: (if i release i will give full credit)

Edited December 12, 201411 yr by tmanowen

December 12, 201411 yr

Author

darn didnt realize that fishing guild is members only .

Also, because you posted source i'd like to ask you... Would you mind if i completely scrapped your code for a private script? (: (if i release i will give full credit)

sure, go ahead. i wouldnt care even if u would literally copy paste it, i just made it for some fun and learning experience.

December 12, 201411 yr

sure, go ahead. i wouldnt care even if u would literally copy paste it, i just made it for some fun and learning experience.

well tysm (:

December 21, 201411 yr

some feedback on start you shouldn't say raw sharks are 900 just do a simple zybez grab

	private static String getZybezRawDataString(String item) {
		if (item == null) {
			return null;
		}
		String s = null;
		try {
			item = java.net.URLEncoder.encode(item, "UTF-8");
		} catch (UnsupportedEncodingException e) {
			System.out.println("Failed to encode item name!");
			e.printStackTrace();
		}
		URL url = null;
		try {
			url = new URL(LINK + item);
		} catch (MalformedURLException e) {
			System.out.println("Invalid Request!");
			e.printStackTrace();
		}
		if (url != null) {
			HttpURLConnection urlConn = null;
			try {
				urlConn = (HttpURLConnection) url.openConnection();
			} catch (IOException e) {
				e.printStackTrace();
			}
			if (urlConn != null) {
				urlConn.addRequestProperty("User-Agent", "Mozilla/4.51");

				BufferedReader br = null;
				try {
					br = new BufferedReader(new InputStreamReader(urlConn.getInputStream()));
				} catch (IOException e1) {
					e1.printStackTrace();
				}
				if (br != null) {
					try {
						s = br.readLine();
					} catch (IOException e) {
						e.printStackTrace();
					}
					try {
						br.close();
					} catch (IOException e) {
						e.printStackTrace();
					}
				}
			}
		}
		return s;
	}

	private final static String LINK = "http://forums.zybez.net/runescape-2007-prices/api/item/";

	public static int priceLookUp(String itemName) {
		String rawData = getZybezRawDataString(itemName);
		if (rawData != null) {
			String tokens[] = rawData.split("\"average\":");
			if (tokens.length > 1)
				if (tokens[1].contains(",")) {
					String number = tokens[1].split(",")[0];
					return parseQuantity(number);
				}
		}
		System.out.println("Invalid Request");
		return -1;
	}

	private static int parseQuantity(String text) {
		if (text == null) {
			return -1;
		}

		if (text.contains("(") && text.contains(")")) {
			text = text.substring(text.indexOf('(') + 1, text.indexOf(')'));
			try {
				NumberFormat.getIntegerInstance(java.util.Locale.US).parse(text).intValue();
			} catch (ParseException e) {
				// TODO Auto-generated catch block
				e.printStackTrace();
			}
		}

		try {
			return NumberFormat.getIntegerInstance(java.util.Locale.US).parse(text).intValue();
		} catch (ParseException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
		return -1;
	}

3

December 21, 201411 yr

some feedback on start you shouldn't say raw sharks are 900 just do a simple zybez grab

	private static String getZybezRawDataString(String item) {
		if (item == null) {
			return null;
		}
		String s = null;
		try {
			item = java.net.URLEncoder.encode(item, "UTF-8");
		} catch (UnsupportedEncodingException e) {
			System.out.println("Failed to encode item name!");
			e.printStackTrace();
		}
		URL url = null;
		try {
			url = new URL(LINK + item);
		} catch (MalformedURLException e) {
			System.out.println("Invalid Request!");
			e.printStackTrace();
		}
		if (url != null) {
			HttpURLConnection urlConn = null;
			try {
				urlConn = (HttpURLConnection) url.openConnection();
			} catch (IOException e) {
				e.printStackTrace();
			}
			if (urlConn != null) {
				urlConn.addRequestProperty("User-Agent", "Mozilla/4.51");

				BufferedReader br = null;
				try {
					br = new BufferedReader(new InputStreamReader(urlConn.getInputStream()));
				} catch (IOException e1) {
					e1.printStackTrace();
				}
				if (br != null) {
					try {
						s = br.readLine();
					} catch (IOException e) {
						e.printStackTrace();
					}
					try {
						br.close();
					} catch (IOException e) {
						e.printStackTrace();
					}
				}
			}
		}
		return s;
	}

	private final static String LINK = "http://forums.zybez.net/runescape-2007-prices/api/item/";

	public static int priceLookUp(String itemName) {
		String rawData = getZybezRawDataString(itemName);
		if (rawData != null) {
			String tokens[] = rawData.split("\"average\":");
			if (tokens.length > 1)
				if (tokens[1].contains(",")) {
					String number = tokens[1].split(",")[0];
					return parseQuantity(number);
				}
		}
		System.out.println("Invalid Request");
		return -1;
	}

	private static int parseQuantity(String text) {
		if (text == null) {
			return -1;
		}

		if (text.contains("(") && text.contains(")")) {
			text = text.substring(text.indexOf('(') + 1, text.indexOf(')'));
			try {
				NumberFormat.getIntegerInstance(java.util.Locale.US).parse(text).intValue();
			} catch (ParseException e) {
				// TODO Auto-generated catch block
				e.printStackTrace();
			}
		}

		try {
			return NumberFormat.getIntegerInstance(java.util.Locale.US).parse(text).intValue();
		} catch (ParseException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
		return -1;
	}

Thanks for this snippet