withdrawing items by name

[Mr Asshole]

I thought some of the new coders would need this. Helps if ids ever change for bank items. I haven't seen it happen but you can't be too sure.

private boolean withdrawItem(int amount, int... ids) throws InterruptedException {
        for (Item item : client.getBank().getItems()) {
            for (int i : ids) {
                if (item != null && item.getId() == i) {
                    client.getBank().withdraw(item.getId(), amount);
                    return true;
                }

            }
        }
        return false;
    } 

Implementation:

String [] itemNames = {Prayer potion(3), Prayer potion(4), etc};

withdraw(2, itemNames);

Will iterate through the array and find first item from index 0 to last index of array. 

Edited October 16, 2013 by Pain

[TheScrub]

I thought some of the new coders would need this. Helps if ids ever change for bank items. I haven't seen it happen but you can't be too sure. 

private void withdrawItem(int amount, String...itemNames) throws InterruptedException {
        int itemID;
        for (Item item : client.getBank().getItems()) {
            for (String s : itemNames) {
                if (item != null && item.getName().equalsIgnoreCase(s)) {
                        itemID = item.getId();
                        client.getBank().withdraw(itemID, amount);

                    
                }
            }
        }
    }

Implementation:

String [] itemNames = {Prayer potion(3), Prayer potion(4), etc};

withdraw(2, itemNames);

Will iterate through the array and find first item from index 0 to last index of array. 

 

problem with this as you're running a for each loop of the name it will withdraw 2 of each item so you will have 4 prayer pots in you're inventory but if you want to withdraw 4 you're doing it right else if you want to withdraw (4) else if it doesn't have (3) you're doing it wrong!

Edited October 16, 2013 by TheScrub

[Rick]

 

I thought some of the new coders would need this. Helps if ids ever change for bank items. I haven't seen it happen but you can't be too sure. 

private void withdrawItem(int amount, String...itemNames) throws InterruptedException {
        int itemID;
        for (Item item : client.getBank().getItems()) {
            for (String s : itemNames) {
                if (item != null && item.getName().equalsIgnoreCase(s)) {
                        itemID = item.getId();
                        client.getBank().withdraw(itemID, amount);

                    
                }
            }
        }
    }

Implementation:

String [] itemNames = {Prayer potion(3), Prayer potion(4), etc};

withdraw(2, itemNames);

Will iterate through the array and find first item from index 0 to last index of array. 

 

problem with this as you're running a for each loop of the name it will withdraw 2 of each item so you will have 4 prayer pots in you're inventory but if you want to withdraw 4 you're doing it right else if you want to withdraw (4) else if it doesn't have (3) you're doing it wrong!

 

yould you repeat that in english lol

i just woke up and read this and im like: dafuqqq

 

ot:

client.getBank().withdraw(itemID, amount); <<<withdraw(itemID.

but you would want it in item name yes? i don't understand sorry if i overread something.

 

Devin

[TheScrub]

he's code will get 2 of the prayer pot's (4) then prayer pots(3)

 

i thought he was trying to withdraw 2 of the (4) if people had them in bank else (3) does

 

but re-reading it i think he is trying to make a method just to withdraw several items by name with the same amount

 

he's implementation is confusing as he's withdrawing 4 prayer potions would of been better if he did a super set

 

 

[Mr Asshole]

he's code will get 2 of the prayer pot's (4) then prayer pots(3)

 

i thought he was trying to withdraw 2 of the (4) if people had them in bank else (3) does

 

but re-reading it i think he is trying to make a method just to withdraw several items by name with the same amount

 

he's implementation is confusing as he's withdrawing 4 prayer potions would of been better if he did a super set

Withdraws same items but different doses.. Useful for pots, rings. anything with charges. Finds item in bank from index 0 to last index of item array. 

[James Oppo]

Much obliged, good Sir.

[Ryley]

The code in the initial post withdraws by ID?

Edited October 30, 2013 by Ryley