Elemental Binder [Open Source Runecrafter]

[Failure]

3 hours ago, BravoTaco said:

Might be fixed? I couldn't reproduce the result so I refactored some things, and added some more checks.

.jar link

Thanks will try out today, I understand it's difficult to reproduce. Hopefully it's fixed. 

For faster banking it should use the X from mobile set to 27 so you can left the pure essence though. 

[Failure]

Something stuck here

i.imgur.com/pHClbeI.png after a while "Walking path to Bank" remains stuck. Also "Getting Essence", "Webwalking to ruins" again.
Got traded 2 times thus it typed in chat i.imgur.com/UsE5bVP.png
It went to the bank traded me just 1 essence i.imgur.com/wdan8SI.png resulted in this i.imgur.com/DCHBNHZ.png (no essence were traded best to "Trade-All" instead of x)

Also walking to ruins goes to the same tile...
Can you make it when you load mule also do the settings?
 

Edited February 3, 2020 by Failure

[BravoTaco]

5 hours ago, Failure said:

Something stuck here

i.imgur.com/pHClbeI.png after a while "Walking path to Bank" remains stuck. Also "Getting Essence", "Webwalking to ruins" again.
Got traded 2 times thus it typed in chat i.imgur.com/UsE5bVP.png
It went to the bank traded me just 1 essence i.imgur.com/wdan8SI.png resulted in this i.imgur.com/DCHBNHZ.png (no essence were traded best to "Trade-All" instead of x)

Also walking to ruins goes to the same tile...
Can you make it when you load mule also do the settings?
 

Changed the walking conditions and the walking method.

Also changed the trading to Trade-all. I was originally using a Trade-x amount while detecting how many free slots were in the other players inventory. I think it might have been messing up on that calculation.

With this latest patch I ran it until Mirror mode crashed on me, which was for about an hour and half. It never got stuck. So hopefully  its good now...

I am probably going to re-write the saving and loading functionality. If so I will make it so it changes all the settings to their set state.

.jar link

Edited February 3, 2020 by BravoTaco

[Failure]

5 hours ago, BravoTaco said:

Changed the walking conditions and the walking method.

Also changed the trading to Trade-all. I was originally using a Trade-x amount while detecting how many free slots were in the other players inventory. I think it might have been messing up on that calculation.

With this latest patch I ran it until Mirror mode crashed on me, which was for about an hour and half. It never got stuck. So hopefully  its good now...

I am probably going to re-write the saving and loading functionality. If so I will make it so it changes all the settings to their set state.

.jar link

Nice thank you. Will hopefully be able to test today else tommorow! 

[BravoTaco]

2 hours ago, Failure said:

Nice thank you. Will hopefully be able to test today else tommorow! 

Np. Currently working on the new GUI with the new Save/Load functionality.

[Failure]

On 2/4/2020 at 7:49 AM, BravoTaco said:

Np. Currently working on the new GUI with the new Save/Load functionality.

Testing now

 

Trading goes way faster since it offers all instead of a amount.
At the ruins it picks a random tile nice!
Withdrawing essence from bank also way faster and more accurate as it picks the last amount! (Could even be faster when using the "X" below so it can left click the essence for 27 instead of right click > 27)

Overall walking feels faster and better and more structured. 
I noticed when it always stops at a tile before trading while the mule is there, instead of wasting time standing still, why not check for the mule while walking (when near location)?

That last update is magnificent! Thank you runs so much better can't wait for the GUI update!  (essence traded/per hour?)
Rougly 12-12.5k exp per hour with 2 accounts!
https://i.imgur.com/cf3MqGB.png

Edited February 5, 2020 by Failure

[BravoTaco]

5 hours ago, Failure said:

Testing now

 

Trading goes way faster since it offers all instead of a amount.
At the ruins it picks a random tile nice!
Withdrawing essence from bank also way faster and more accurate as it picks the last amount! (Could even be faster when using the "X" below so it can left click the essence for 27 instead of right click > 27)

Overall walking feels faster and better and more structured. 
I noticed when it always stops at a tile before trading while the mule is there, instead of wasting time standing still, why not check for the mule while walking (when near location)?

That last update is magnificent! Thank you runs so much better can't wait for the GUI update!  (essence traded/per hour?)
Rougly 12-12.5k exp per hour with 2 accounts!
https://i.imgur.com/cf3MqGB.png

Because of the way the old load system worked I had to restrict the area in which the Crafter would detect the mule. Because of partial name matches if another random player is nearby than it would think that is a mule and would trade it.

But I have finished the new GUI for now and with it added the new Save/Load system.

I think if you manually select the X in the bank and the amount is set to what it needs it will left click it instead of right clicking? I can't remember though.  Using OSBot's API method to withdraw from the bank ATM. If it doesn't do it let me know and I'll implement it.

I will change the UI Text 'Runes made' to 'Essence's traded' for mules in the next update.

 

Edit:

Added the UI text.

Fixed a bug with not detecting the runecrafter.

.jar link

 

 

Edited February 6, 2020 by BravoTaco

[Failure]

17 hours ago, BravoTaco said:

Because of the way the old load system worked I had to restrict the area in which the Crafter would detect the mule. Because of partial name matches if another random player is nearby than it would think that is a mule and would trade it.

But I have finished the new GUI for now and with it added the new Save/Load system.

I think if you manually select the X in the bank and the amount is set to what it needs it will left click it instead of right clicking? I can't remember though.  Using OSBot's API method to withdraw from the bank ATM. If it doesn't do it let me know and I'll implement it.

I will change the UI Text 'Runes made' to 'Essence's traded' for mules in the next update.

 

Edit:

Added the UI text.

Fixed a bug with not detecting the runecrafter.

.jar link

 

 

Cooll! 

Yeah manually clicking x works (previous time) but would be cool to have it built in. edit - having manually x clicked will do left click to grab essence!

For not detecting Runecrafter did you replace the white space with the "space bar" code? 

I will run in an hour or so. 

Edited February 6, 2020 by Failure

[Failure]

Oh the new load/save is lovely!
What happend to the version? From 1.58 to 1.86 hehe.

Essence traded stays even after restart client (also shared between 2 instances)
https://i.imgur.com/seJRfUl.png
Noticed it got stuck here

Also stuck here
https://i.imgur.com/x05XLUe.png
https://i.imgur.com/B0VhsSC.png

Hmm not sure what happends here as it's not in the area or something?
https://i.imgur.com/vJqldbc.png
https://i.imgur.com/f3aLm3r.png
Only seems to work at this specific tile (thoug restart of script works)
https://i.imgur.com/Q5P1UAf.png
Sometimes runner declines offer and goes to bank with a full inventory of essence... And gets stuck in a loop (restarting scripts works though)
https://i.imgur.com/3sIDkFs.png
https://i.imgur.com/WbBToQl.gifv
https://i.imgur.com/uNfn91o.png

Stuck while bank is open and withdrew essence
https://i.imgur.com/oJCmojs.png

Edited February 6, 2020 by Failure

[BravoTaco]

3 hours ago, Failure said:

Cooll! 

Yeah manually clicking x works (previous time) but would be cool to have it built in. edit - having manually x clicked will do left click to grab essence!

For not detecting Runecrafter did you replace the white space with the "space bar" code? 

I will run in an hour or so. 

For some reason when grabbing player names if they have a space in it, it will sometimes count the space as a non-breaking space which will return code 160 while the normal space code is 32. I had to create a method that used a string regex to remove all white space, non breaking and regular. Than compared those names.

Method here:

public static boolean stringMatchesWithRemovedWhiteSpace(String string1, String string2) {
    if (string1.length() != string2.length())
        return false;

    string1 = string1.replaceAll("\\p{Z}", "");
    string2 = string2.replaceAll("\\p{Z}", "");

    return string1.equalsIgnoreCase(string2);
}

I will look into the area problems and the banking problem.

Essences traded not resetting will be fixed in the next update.

Edited February 6, 2020 by BravoTaco

[Failure]

10 minutes ago, BravoTaco said:

For some reason when grabbing player names if they have a space in it, it will sometimes count the space as a non-breaking space which will return code 160 while the normal space code is 32. I had to create a method that used a string regex to remove all white space, non breaking and regular. Than compared those names.

Method here:

public static boolean stringMatchesWithRemovedWhiteSpace(String string1, String string2) {
    if (string1.length() != string2.length())
        return false;

    string1 = string1.replaceAll("\\p{Z}", "");
    string2 = string2.replaceAll("\\p{Z}", "");

    return string1.equalsIgnoreCase(string2);
}

I will look into the area problems and the banking problem.

Thank you.

This seemed to work for me though (source) when I needed it, though you'd need "replaceAll"

String player = "player space".replace(' ', '\u00A0');

 

Edited February 6, 2020 by Failure

[BravoTaco]

3 hours ago, Failure said:

Oh the new load/save is lovely!
What happend to the version? From 1.58 to 1.86 hehe.

Essence traded stays even after restart client (also shared between 2 instances)
https://i.imgur.com/seJRfUl.png
Noticed it got stuck here

Also stuck here
https://i.imgur.com/x05XLUe.png
https://i.imgur.com/B0VhsSC.png

Hmm not sure what happends here as it's not in the area or something?
https://i.imgur.com/vJqldbc.png
https://i.imgur.com/f3aLm3r.png
Only seems to work at this specific tile (thoug restart of script works)
https://i.imgur.com/Q5P1UAf.png
Sometimes runner declines offer and goes to bank with a full inventory of essence... And gets stuck in a loop (restarting scripts works though)
https://i.imgur.com/3sIDkFs.png
https://i.imgur.com/WbBToQl.gifv
https://i.imgur.com/uNfn91o.png

Stuck while bank is open and withdrew essence
https://i.imgur.com/oJCmojs.png

I had a logic error when calculating the local path to see if its usable. I believe that was what was causing it to get stuck.

I added a check before initiating the walking event to the bank to get essences, hopefully that fixes it.  

.jar

[Failure]

13 hours ago, BravoTaco said:

I had a logic error when calculating the local path to see if its usable. I believe that was what was causing it to get stuck.

I added a check before initiating the walking event to the bank to get essences, hopefully that fixes it.  

.jar

I will test this later today, did you also fixed the other errors? 

[Failure]

Tested and it got stuck restarted script and got also stuck see gif (when using stop client gets stuck though think it's not multithread?)

https://i.imgur.com/OHnm5IF.png
https://i.imgur.com/NtZRcfp.gifv

Withdrew essence and got stuck

https://i.imgur.com/BE1vn93.png

Didn't accept trade instead it walked
https://i.imgur.com/u4oMjnL.png

Stuck at the bank again
https://i.imgur.com/llt8yta.png

[John Foster]

Great script, seems broken right now though