Plague Doctor's - Chocolate Grinder

[PlagueDoctor]

http://2007.runescape.wikia.com/wiki/Money_making_guide/Grinding_chocolate_bars
 

$190-200k Profit Per/Hour ~

Script to execute the above method of money making.

No skill requirements!
 
Requirements:

• Have Knife in bank or inventory
• Have Chocolate bars in bank
• Be near a bank or GE

Process:

• Withdraws a Knife and 27 Chocolate Bars.
• Turns all of the Chocolate bars into Chocolate Dust.
• Deposits all Chocolate Dust.
• If you have no Chocolate bars left, it logs out and stops script. 
• Repeat.

Extra Notes:

• You can only buy 10,000 Chocolate bars from the G.E every 4 hours. 
• As with all scripts, if you don't want to get banned, script carefully or don't script at all.

Download: Google Drive Link
https://drive.google.com/file/d/0B68yui8zn4TPVXAyNHBtbzBKdWM/view?usp=sharing

 

EDITS:

• 9/28/2016 - Added conditional sleeping, removed walk to bank function and added support for every bank.

 
If you have any issues, post them here. Otherwise, enjoy!

Edited September 27, 2016 by PlagueDoctor

[House]

TIL you can use a knife rather than only a pestle and mortar.

[Zerker]

TIL you can use a knife rather than only a pestle and mortar.

 

Me to.

 

[10:28:23] Zerker | Selling 07 GP 1.07/M Skrill/BTC: since when can you grind chocolate bars

[10:28:26] Zerker | Selling 07 GP 1.07/M Skrill/BTC: with a knife

[Salty as fuck]

You should really look into conditional sleeps..

Also, why is it restricted to one bank?

private Area varrockWestBank = new Area(3180, 3447, 3190, 3433);

You could just do - 

		if (map.isWithinRange(objects.closest("Grand Exchange booth"), 10) && !bank.isOpen()) {
			bank.open(); //attempts to open the bank
			new ConditionalSleep(10000) { //how many ms to wait for condition
				@[member=Override]
				public boolean condition() throws InterruptedException {
					//method goes here
					return bank.isOpen(); //ends conditional sleep if bank is open
				}
			}.sleep();
		}

		//now it proceeds to the next method

		if (bank.isOpen()) {
			new ConditionalSleep(10000) {
				@[member=Override]
				public boolean condition() throws InterruptedException {
                                        //add your methods here
					return inventory.contains("Knife") && inventory.contains("Chocolate bar"); //ends conditional sleep if you have the knife and chocolate bar
				}
			}.sleep();
		}

There's a lot that can be improved in your script. I suggest going through other open source scripts and releasing the source to your scripts for suggestions on improvements.

[PlagueDoctor]

You should really look into conditional sleeps..

Also, why is it restricted to one bank?

private Area varrockWestBank = new Area(3180, 3447, 3190, 3433);

You could just do - 

		if (map.isWithinRange(objects.closest("Grand Exchange booth"), 10) && !bank.isOpen()) {
			bank.open(); //attempts to open the bank
			new ConditionalSleep(10000) { //how many ms to wait for condition
				@[member='Override']
				public boolean condition() throws InterruptedException {
					//method goes here
					return bank.isOpen(); //ends conditional sleep if bank is open
				}
			}.sleep();
		}

		//now it proceeds to the next method

		if (bank.isOpen()) {
			new ConditionalSleep(10000) {
				@[member='Override']
				public boolean condition() throws InterruptedException {
                                        //add your methods here
					return inventory.contains("Knife") && inventory.contains("Chocolate bar"); //ends conditional sleep if you have the knife and chocolate bar
				}
			}.sleep();
		}

There's a lot that can be improved in your script. I suggest going through other open source scripts and releasing the source to your scripts for suggestions on improvements.

Thanks for the response, i'll look into what you mentioned. I created this script for my own use and decided to share in case others would find it useful.

[Salty as fuck]

Thanks for the response, i'll look into what you mentioned. I created this script for my own use and decided to share in case others would find it useful.

 

Yes, I remember suggesting against it in the chatbox.

Conditional sleeps are your best friend when making scripts.

Best to learn great methods while just starting out. Practicing poor code will make it hard to switch over to better/cleaner code later on. Trust me on that one, I'm speaking from personal experience lol.

 

Congrats on the release btw!

Edited September 27, 2016 by Reminiscence

[PlagueDoctor]

Yes, I remember suggesting against it in the chatbox.

Conditional sleeps are your best friend when making scripts.

Best to learn great methods while just starting out. Practicing poor code will make it hard to switch over to better/cleaner code later on. Trust me on that one, I'm speaking from personal experience lol.

 

Congrats on the release btw!

Will do, thanks for mentioning the conditional sleep stuff, looks as though it will be really useful. Might try implement in into this code as a learning experience.

[PlagueDoctor]

Added support for the use of any bank and added conditional sleeping.

[hxhvxhgfhg]

how do u use the code?????

[EsotericRS]

14 hours ago, hxhvxhgfhg said:

how do u use the code?????

You download the JAR file he linked and place it in the \OSBot\Scripts directory

Then when you launch OSBot, and hit the green play arrow - It will appear as a [Local] script.