Jump to content

[FREE] Versace Goblin Killer [First Script]


Recommended Posts

Posted

Versace Goblin Killer

i8wyIrR.jpg

 

By: VersaceGod

 

Released: March 25th, 2016

 

Features:

  • Kills Goblins Everywhere.
  • Opens doors if doors are closed.
  • Simple AntiBan Features (Random Mouse Movements, Skill tab hovering, etc)
  • Combat EXP gained Paint (Hitpoints, Attack, Strength, Defense, Ranged, Magic)

Download Links:

Coming Soon:

  • More AntiBan Features
  • Progress Report
  • Ability to Open Gates
  • Like 3
Posted

Looks very good to me for a first script biggrin.png

 

Quick question,isn't the script opening the door everytime it closes, even though it not required to have it open to reach other goblins?

You could change to logic to: (now only opens door when it has to attack a goblin which you can't reach)

Npc gob = getGoblin();

if(gob != nullç{
   if(getmap().canReach(gob)){
      //attack gob
   }else{
      getDoorhandler().handleNextobstacle(gob);
      sleep(500,1000)
   }
}

Someother things you can improve (Your code works fine aswell):

for(String actions: door.getDefinition().getActions()) {
  if(actions.contains("Open")) {
  }
}

Can be done by:

door.hasAction("Open");	

Also check if the interaction was succeeded, don't just simply sleep after it without checking^^

goblin.interact("Attack");
sleep(random(100, 250));
AfterAttack(); 

Check if was succeeded.

if(goblin.interact("Attack")){
   sleep(random(100, 250));
   AfterAttack(); 
}else{
   log("Failed attacking");
}

Kind regards

Khaleesi

  • Like 1
Posted

Looks very good to me for a first script biggrin.png

 

Quick question,isn't the script opening the door everytime it closes, even though it not required to have it open to reach other goblins?

You could change to logic to: (now only opens door when it has to attack a goblin which you can't reach)

Npc gob = getGoblin();

if(gob != nullç{
   if(getmap().canReach(gob)){
      //attack gob
   }else{
      getDoorhandler().handleNextobstacle(gob);
      sleep(500,1000)
   }
}

Someother things you can improve (Your code works fine aswell):

for(String actions: door.getDefinition().getActions()) {
  if(actions.contains("Open")) {
  }
}

Can be done by:

door.hasAction("Open");	

Also check if the interaction was succeeded, don't just simply sleep after it without checking^^

goblin.interact("Attack");
sleep(random(100, 250));
AfterAttack(); 

Check if was succeeded.

if(goblin.interact("Attack")){
   sleep(random(100, 250));
   AfterAttack(); 
}else{
   log("Failed attacking");
}

Kind regards

Khaleesi

 

Thanks for the feedback, I'll be updating it in a few days and this will be super useful!

is that you in the pic? lol

 

No, that is not me lmao

  • Like 1

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...