Three Shot Posted July 18, 2015 Share Posted July 18, 2015 (edited) Mirror or normal - Normal Version of OSBot client (number, not something like "latest") - 2.3.84 Description of bug report - Doesn't pick up loot after a while Description of how to replicate if possible - Set to loot after kill, doesn't pick up fire/nature runes and iron ore (noted) Screenshot if possible - http://postimg.org/image/rcy078f7l/ Are you using low priority for your loot by chance? And does this only happen while the mobs are aggro at the start? Edited July 18, 2015 by Three Shot Quote Link to comment Share on other sites More sharing options...
Skynet Posted July 19, 2015 Share Posted July 19, 2015 (edited) Are you using low priority for your loot by chance? And does this only happen while the mobs are aggro at the start? Yeah I experimented with the loot setting and it works fine on high priority loot (removed loot after kill - seems buggy). It's irrelevant whether the mobs are agro or not. A couple of improvements would be to optimize the combat when mobs are agro. Also the loot system seems to be inaccurate. Proggies: 16 hrs: 16 hrs loot: loot inaccuracy: Edited July 19, 2015 by elf2345 Quote Link to comment Share on other sites More sharing options...
Three Shot Posted July 19, 2015 Share Posted July 19, 2015 Yeah I experimented with the loot setting and it works fine on high priority loot (removed loot after kill - seems buggy). It's irrelevant whether the mobs are agro or not. A couple of improvements would be to optimize the combat when mobs are agro. Also the loot system seems to be inaccurate. Proggies: 16 hrs: 16 hrs loot: loot inaccuracy: Yeah I've noticed all this myself, but I have to say it's a nice surprise to look and see that you gained "600k" but it turns out being over a mill lmao. As for the looting, yeah it's better for now to just use high priority loot but honestly it's something small which I'm sure he'll look into. But from my understand there's not much that can be done for the initial 10 minutes during the aggro time since the script is basically going. "I'll loot this when I'm not in danger" But you're constantly in danger so yeah. That aside anything else you noticed? Like for example 1-2 of the answers on the door are still a bit wonky and it gets them wrong but that'll be fixed too for sure. Quote Link to comment Share on other sites More sharing options...
Skynet Posted July 19, 2015 Share Posted July 19, 2015 Yeah I've noticed all this myself, but I have to say it's a nice surprise to look and see that you gained "600k" but it turns out being over a mill lmao. As for the looting, yeah it's better for now to just use high priority loot but honestly it's something small which I'm sure he'll look into. But from my understand there's not much that can be done for the initial 10 minutes during the aggro time since the script is basically going. "I'll loot this when I'm not in danger" But you're constantly in danger so yeah. That aside anything else you noticed? Like for example 1-2 of the answers on the door are still a bit wonky and it gets them wrong but that'll be fixed too for sure. Only a couple of things I have noticed is with the combat as it misclicks the npc on a lot of occasions. Because the npc's are mobile the script seems to misclick them in this state. Only during stationary phases does the script accurately click the npc. Also in terms of optimisation, I have noticed that when going to level 2, the bot will walk to the centre of level 1 and use the ladder to go to level 2. It would be easier to check whether the portal to level 1 treasure room is usable, and use the ladder that way... Still testing on a few accounts atm... will post more if I notice anything else... Good script; with a few improvements, i'd say this would be perfect. Quote Link to comment Share on other sites More sharing options...
Three Shot Posted July 19, 2015 Share Posted July 19, 2015 Only a couple of things I have noticed is with the combat as it misclicks the npc on a lot of occasions. Because the npc's are mobile the script seems to misclick them in this state. Only during stationary phases does the script accurately click the npc. Also in terms of optimisation, I have noticed that when going to level 2, the bot will walk to the centre of level 1 and use the ladder to go to level 2. It would be easier to check whether the portal to level 1 treasure room is usable, and use the ladder that way... Still testing on a few accounts atm... will post more if I notice anything else... Good script; with a few improvements, i'd say this would be perfect. Really? Hmm that's weird I put around 20+ hours into this already and not once have I walked via floor one. It tried to once before, but after a hard restart (osbot and osrs) client it worked perfectly fine. Have you tried that yet? Alright cool anything you find will help me I'm sure he'd appreciate it all when he gets back. 1 Quote Link to comment Share on other sites More sharing options...
Fluttershy Posted July 19, 2015 Share Posted July 19, 2015 (edited) Mirror or normal - Normal Version of OSBot client (number, not something like "latest") - 2.3.84 Description of bug report - When the spiders are aggressive and already in combat with a spider from auto retaliating, it will try to click on a different spider even though already in combat. Will only click the once, but seems to do it each time until they're no longer aggro. Not too much of a problem but looks suspicious if doing it after every kill. Description of how to replicate if possible Withdraw 28 Lobsters, Giant Spiders, Level 3 at Location 2150 5306 the most northern giant spider location with the eating is there like a tolerance on when to eat? i've got it set to eat at 10hp though sometimes it will go to around 8 and i had to manually eat. was going to report it as a bug, but after a few manual eats it started to eat for itself again. good script though, i'll try get a decent progress report came back to find it on the fourth floor. i haven't completed this floor and it appeared to be stuck. here; [INFO][Bot #1][07/19 02:18:30 PM]: Search for door [INFO][Bot #1][07/19 02:18:30 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:30 PM]: No door near [INFO][Bot #1][07/19 02:18:30 PM]: walk [INFO][Bot #1][07/19 02:18:30 PM]: Search for door [INFO][Bot #1][07/19 02:18:30 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:30 PM]: No door near [INFO][Bot #1][07/19 02:18:31 PM]: walk [INFO][Bot #1][07/19 02:18:31 PM]: Search for door [INFO][Bot #1][07/19 02:18:31 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:31 PM]: No door near [INFO][Bot #1][07/19 02:18:32 PM]: walk [INFO][Bot #1][07/19 02:18:32 PM]: Search for door [INFO][Bot #1][07/19 02:18:32 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:32 PM]: No door near [INFO][Bot #1][07/19 02:18:32 PM]: walk [INFO][Bot #1][07/19 02:18:32 PM]: Search for door [INFO][Bot #1][07/19 02:18:32 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:32 PM]: No door near [INFO][Bot #1][07/19 02:18:33 PM]: walk [INFO][Bot #1][07/19 02:18:33 PM]: Search for door [INFO][Bot #1][07/19 02:18:33 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:33 PM]: No door near [INFO][Bot #1][07/19 02:18:33 PM]: Terminating script CMHStronghold v1.73... [WARN][Bot #1][07/19 02:18:38 PM]: Event executor is taking too long to suspend; terminating now... [INFO][Bot #1][07/19 02:18:38 PM]: Script CMHStronghold v1.73 has exited! assuming it was when it tried to bank. as there's no lobsters in inventory and the health is pretty low. Edited July 19, 2015 by Fluttershy Quote Link to comment Share on other sites More sharing options...
Mad Jew Posted July 19, 2015 Share Posted July 19, 2015 at minotaurs it just attacks them all, so im fighting like 5+ minotaurs at once.. not good being a low level pure.. :p Quote Link to comment Share on other sites More sharing options...
Three Shot Posted July 19, 2015 Share Posted July 19, 2015 Mirror or normal - Normal Version of OSBot client (number, not something like "latest") - 2.3.84 Description of bug report - When the spiders are aggressive and already in combat with a spider from auto retaliating, it will try to click on a different spider even though already in combat. Will only click the once, but seems to do it each time until they're no longer aggro. Not too much of a problem but looks suspicious if doing it after every kill. Description of how to replicate if possible Withdraw 28 Lobsters, Giant Spiders, Level 3 at Location 2150 5306 the most northern giant spider location with the eating is there like a tolerance on when to eat? i've got it set to eat at 10hp though sometimes it will go to around 8 and i had to manually eat. was going to report it as a bug, but after a few manual eats it started to eat for itself again. good script though, i'll try get a decent progress report came back to find it on the fourth floor. i haven't completed this floor and it appeared to be stuck. here; [INFO][Bot #1][07/19 02:18:30 PM]: Search for door [INFO][Bot #1][07/19 02:18:30 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:30 PM]: No door near [INFO][Bot #1][07/19 02:18:30 PM]: walk [INFO][Bot #1][07/19 02:18:30 PM]: Search for door [INFO][Bot #1][07/19 02:18:30 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:30 PM]: No door near [INFO][Bot #1][07/19 02:18:31 PM]: walk [INFO][Bot #1][07/19 02:18:31 PM]: Search for door [INFO][Bot #1][07/19 02:18:31 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:31 PM]: No door near [INFO][Bot #1][07/19 02:18:32 PM]: walk [INFO][Bot #1][07/19 02:18:32 PM]: Search for door [INFO][Bot #1][07/19 02:18:32 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:32 PM]: No door near [INFO][Bot #1][07/19 02:18:32 PM]: walk [INFO][Bot #1][07/19 02:18:32 PM]: Search for door [INFO][Bot #1][07/19 02:18:32 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:32 PM]: No door near [INFO][Bot #1][07/19 02:18:33 PM]: walk [INFO][Bot #1][07/19 02:18:33 PM]: Search for door [INFO][Bot #1][07/19 02:18:33 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:33 PM]: No door near [INFO][Bot #1][07/19 02:18:33 PM]: Terminating script CMHStronghold v1.73... [WARN][Bot #1][07/19 02:18:38 PM]: Event executor is taking too long to suspend; terminating now... [INFO][Bot #1][07/19 02:18:38 PM]: Script CMHStronghold v1.73 has exited! assuming it was when it tried to bank. as there's no lobsters in inventory and the health is pretty low. Does it just click a new spider whenever you kill something? Or does it end up clicking even while you're half way killing something else? Also which loot priority are you using? Low or High? The eating has a threshold of around 5 if I remember correctly. So if set to 10 it can eat at 5 hp or 15. I'd recommend setting it to at least 15-20 for your situation eats at no lower than 10, but up to 20-25. Try to restart osbot and osrs client. If this 4th floor bug is persistent then do post about it again that way he can fix it! Quote Link to comment Share on other sites More sharing options...
Skynet Posted July 19, 2015 Share Posted July 19, 2015 (edited) Mirror or normal - Normal Version of OSBot client (number, not something like "latest") - 2.3.84 Description of bug report - When the spiders are aggressive and already in combat with a spider from auto retaliating, it will try to click on a different spider even though already in combat. Will only click the once, but seems to do it each time until they're no longer aggro. Not too much of a problem but looks suspicious if doing it after every kill. Description of how to replicate if possible Withdraw 28 Lobsters, Giant Spiders, Level 3 at Location 2150 5306 the most northern giant spider location with the eating is there like a tolerance on when to eat? i've got it set to eat at 10hp though sometimes it will go to around 8 and i had to manually eat. was going to report it as a bug, but after a few manual eats it started to eat for itself again. good script though, i'll try get a decent progress report came back to find it on the fourth floor. i haven't completed this floor and it appeared to be stuck. here; [INFO][Bot #1][07/19 02:18:30 PM]: Search for door [INFO][Bot #1][07/19 02:18:30 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:30 PM]: No door near [INFO][Bot #1][07/19 02:18:30 PM]: walk [INFO][Bot #1][07/19 02:18:30 PM]: Search for door [INFO][Bot #1][07/19 02:18:30 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:30 PM]: No door near [INFO][Bot #1][07/19 02:18:31 PM]: walk [INFO][Bot #1][07/19 02:18:31 PM]: Search for door [INFO][Bot #1][07/19 02:18:31 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:31 PM]: No door near [INFO][Bot #1][07/19 02:18:32 PM]: walk [INFO][Bot #1][07/19 02:18:32 PM]: Search for door [INFO][Bot #1][07/19 02:18:32 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:32 PM]: No door near [INFO][Bot #1][07/19 02:18:32 PM]: walk [INFO][Bot #1][07/19 02:18:32 PM]: Search for door [INFO][Bot #1][07/19 02:18:32 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:32 PM]: No door near [INFO][Bot #1][07/19 02:18:33 PM]: walk [INFO][Bot #1][07/19 02:18:33 PM]: Search for door [INFO][Bot #1][07/19 02:18:33 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:33 PM]: No door near [INFO][Bot #1][07/19 02:18:33 PM]: Terminating script CMHStronghold v1.73... [WARN][Bot #1][07/19 02:18:38 PM]: Event executor is taking too long to suspend; terminating now... [INFO][Bot #1][07/19 02:18:38 PM]: Script CMHStronghold v1.73 has exited! assuming it was when it tried to bank. as there's no lobsters in inventory and the health is pretty low. I've noticed the combat issue as well and AFAIK I think someone else has already raised the issue. I have run the script for over 50 hrs on a number of accounts and it has never gone past the level I specified. Only noticed one instance where the script was stuck at the unicorn near barb village, but again, I think this has already been raised as well. With the eating, set the value so its not that low. I think it's good it doesn't eat at a specified value. If you are worried, just equip ring of life. I think it's mandatory for testing combat scripts if you are afk. Edited July 19, 2015 by elf2345 Quote Link to comment Share on other sites More sharing options...
Three Shot Posted July 19, 2015 Share Posted July 19, 2015 (edited) at minotaurs it just attacks them all, so im fighting like 5+ minotaurs at once.. not good being a low level pure.. I'll log on and try this for myself too and let you know. xD Once again though mind saying which priority looting you're using? So I can try to recreate this myself. Edit: Can't seem to replicate it I just aggro one mob at a time until it dies. Edited July 19, 2015 by Three Shot 1 Quote Link to comment Share on other sites More sharing options...
SouljaBB Posted July 19, 2015 Share Posted July 19, 2015 24 hour proggie 2 Quote Link to comment Share on other sites More sharing options...
Ericthecmh Posted July 19, 2015 Share Posted July 19, 2015 All right, I'm back, and will be reviewing your reports on the plane if I can secure an internet connection Mirror or normal - Normal Version of OSBot client (number, not something like "latest") - 2.3.84 Description of bug report - Doesn't pick up loot after a while Description of how to replicate if possible - Set to loot after kill, doesn't pick up fire/nature runes and iron ore (noted) Screenshot if possible - http://postimg.org/image/rcy078f7l/ Was the loot marked as stackable so it knows that it can loot even though the inventory is full? If you can reproduce it, tell me on Skype so we can debug it in real time (skype is Ericthecmh) Yeah I experimented with the loot setting and it works fine on high priority loot (removed loot after kill - seems buggy). It's irrelevant whether the mobs are agro or not. A couple of improvements would be to optimize the combat when mobs are agro. Also the loot system seems to be inaccurate. Proggies: 16 hrs: 16 hrs loot: loot inaccuracy: Yeah loot tracker does need some work, but I also don't want to nail the CPU. I have an idea for that and will switch it out soon. Only a couple of things I have noticed is with the combat as it misclicks the npc on a lot of occasions. Because the npc's are mobile the script seems to misclick them in this state. Only during stationary phases does the script accurately click the npc. Also in terms of optimisation, I have noticed that when going to level 2, the bot will walk to the centre of level 1 and use the ladder to go to level 2. It would be easier to check whether the portal to level 1 treasure room is usable, and use the ladder that way... Still testing on a few accounts atm... will post more if I notice anything else... Good script; with a few improvements, i'd say this would be perfect. Unfortunately, this is a problem that I can only make *rarer*, not nonexistant (it really shouldn't happen very often). I'll do that and update the script Mirror or normal - Normal Version of OSBot client (number, not something like "latest") - 2.3.84 Description of bug report - When the spiders are aggressive and already in combat with a spider from auto retaliating, it will try to click on a different spider even though already in combat. Will only click the once, but seems to do it each time until they're no longer aggro. Not too much of a problem but looks suspicious if doing it after every kill. Description of how to replicate if possible Withdraw 28 Lobsters, Giant Spiders, Level 3 at Location 2150 5306 the most northern giant spider location with the eating is there like a tolerance on when to eat? i've got it set to eat at 10hp though sometimes it will go to around 8 and i had to manually eat. was going to report it as a bug, but after a few manual eats it started to eat for itself again. good script though, i'll try get a decent progress report came back to find it on the fourth floor. i haven't completed this floor and it appeared to be stuck. here; [INFO][Bot #1][07/19 02:18:30 PM]: Search for door [INFO][Bot #1][07/19 02:18:30 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:30 PM]: No door near [INFO][Bot #1][07/19 02:18:30 PM]: walk [INFO][Bot #1][07/19 02:18:30 PM]: Search for door [INFO][Bot #1][07/19 02:18:30 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:30 PM]: No door near [INFO][Bot #1][07/19 02:18:31 PM]: walk [INFO][Bot #1][07/19 02:18:31 PM]: Search for door [INFO][Bot #1][07/19 02:18:31 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:31 PM]: No door near [INFO][Bot #1][07/19 02:18:32 PM]: walk [INFO][Bot #1][07/19 02:18:32 PM]: Search for door [INFO][Bot #1][07/19 02:18:32 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:32 PM]: No door near [INFO][Bot #1][07/19 02:18:32 PM]: walk [INFO][Bot #1][07/19 02:18:32 PM]: Search for door [INFO][Bot #1][07/19 02:18:32 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:32 PM]: No door near [INFO][Bot #1][07/19 02:18:33 PM]: walk [INFO][Bot #1][07/19 02:18:33 PM]: Search for door [INFO][Bot #1][07/19 02:18:33 PM]: 207.46083967823904 41 [INFO][Bot #1][07/19 02:18:33 PM]: No door near [INFO][Bot #1][07/19 02:18:33 PM]: Terminating script CMHStronghold v1.73... [WARN][Bot #1][07/19 02:18:38 PM]: Event executor is taking too long to suspend; terminating now... [INFO][Bot #1][07/19 02:18:38 PM]: Script CMHStronghold v1.73 has exited! assuming it was when it tried to bank. as there's no lobsters in inventory and the health is pretty low. The combat thing you mentioned isn't an easy thing to improve. I'll fiddle with it but I can't guarantee anything. It shouldn't really affect the script itself though. I've noticed the combat issue as well and AFAIK I think someone else has already raised the issue. I have run the script for over 50 hrs on a number of accounts and it has never gone past the level I specified. Only noticed one instance where the script was stuck at the unicorn near barb village, but again, I think this has already been raised as well. With the eating, set the value so its not that low. I think it's good it doesn't eat at a specified value. If you are worried, just equip ring of life. I think it's mandatory for testing combat scripts if you are afk. 24 hour proggie Yeah I'll try to make a failsafe for the walking though. Was probably just a one time messup though. And I'd like to give special thanks to @Three Shot for taking over and helping out while I was gone Quote Link to comment Share on other sites More sharing options...
Three Shot Posted July 19, 2015 Share Posted July 19, 2015 All right, I'm back, and will be reviewing your reports on the plane if I can secure an internet connection I'll make it easier on you. Bugs/Concerns: 1. Target AI seems like a main concern. Especially in High Priority looting. (Attacking different mobs after running to loot.) 2. Pathing on the third floor is possibly wonky (Can't test for myself) Causing a user to walk all the way to the forth floor. 3. Some door answers are still wrong. (This I can try to figure out myself tbh.) 4. Client rendering issues leading to idle time walking to and from the bank? 5. Loot drop/loot drop calculator displaying inaccurate gains. (Shows 600k gold gained but price checking shows over 1.2m etc..) 6. Perhaps changing gui to indicate a not static eating system (Players can often think setting at 10-15 means he'll eat exactly at that instead of a possible 5 greater or less. (Set to 10 eat at 5,15 etc..) 7. Check to make sure you don't aggro too many monsters at once (Just check I can't seem to get it to happen.) 1 Quote Link to comment Share on other sites More sharing options...
Ericthecmh Posted July 19, 2015 Share Posted July 19, 2015 I'll make it easier on you. Bugs/Concerns: 1. Target AI seems like a main concern. Especially in High Priority looting. (Attacking different mobs after running to loot.) 2. Pathing on the third floor is possibly wonky (Can't test for myself) Causing a user to walk all the way to the forth floor. 3. Some door answers are still wrong. (This I can try to figure out myself tbh.) 4. Client rendering issues leading to idle time walking to and from the bank? 5. Loot drop/loot drop calculator displaying inaccurate gains. (Shows 600k gold gained but price checking shows over 1.2m etc..) 6. Perhaps changing gui to indicate a not static eating system (Players can often think setting at 10-15 means he'll eat exactly at that instead of a possible 5 greater or less. (Set to 10 eat at 5,15 etc..) 7. Check to make sure you don't aggro too many monsters at once (Just check I can't seem to get it to happen.) as I said in my previous post, thanks a lot of taking over and responding to people while I was gone! I'll go through these on the plane. Not sure how many I can improve on, but we'll see Quote Link to comment Share on other sites More sharing options...
Three Shot Posted July 19, 2015 Share Posted July 19, 2015 as I said in my previous post, thanks a lot of taking over and responding to people while I was gone! I'll go through these on the plane. Not sure how many I can improve on, but we'll see No problem if I'm around why not right? Quote Link to comment Share on other sites More sharing options...
