From what I can see it doesn't work well if there are two npcs with the same ID at the same position (barbarian fishing, for example)

Here: 

public NPC getNPC(String name) {
		List<NPC> npcs = closestNPCListForName(name);
		for (NPC npc : npcs) {
			if (npc.getName().equalsIgnoreCase(name)
					&& client.getCurrentRegion().contains(npc))
				return npc;
		}
		return null;
	}

just do NPC npc = getNPC("NPC NAME HERE");

 

 

Your welcome. Creds to jwiz.

I know, I'm just letting them know so they can fix it

I can't see anything wrong:

 

 
/**
* Returns the closest NPC with the matching ID.
* @param ids The possible npc identifier numbers.
* @return The closest NPC. Returns null if none were found or are reachable.
*/
public NPC closestNPC(int... ids) {
NPC closestNpc = null;
int closestDistance = Integer.MAX_VALUE;
 
for(NPC npc : client.getLocalNPCs()) {
for (int id : ids) {
if(npc.getId() == id) {
int dist = realDistance(npc);
if(dist != -1 && dist < closestDistance) {
closestNpc = npc;
closestDistance = dist;
}
}
}
}
return closestNpc;
}
 

 

Sorry for the bad formatting, it is due the upgrade of the IPB, we'll have it fixed soon.

Here: 

public NPC getNPC(String name) {
		List<NPC> npcs = closestNPCListForName(name);
		for (NPC npc : npcs) {
			if (npc.getName().equalsIgnoreCase(name)
					&& client.getCurrentRegion().contains(npc))
				return npc;
		}
		return null;
	}

just do NPC npc = getNPC("NPC NAME HERE");

 

 

Your welcome. Creds to jwiz.

 

Isn't this mine?

Isn't this mine?

Idk, was it you or daniel who tv'd me...lol. Anyways, creds to whoever did it. And Max, it doesn't work.

Can people please stop using the phrase 'it doesn't work'? The last 10 times I've heard that method were used in the wrong way. Instead, could you please tell me how you are using this method etc?

		NPC fishingSpot = closestNPC(2722);

if (fishingSpot != null) {

if (canReach(fishingSpot)) {

selectEntityOption(fishingSpot, "Use-rod");

state = State.FISHING;

} else {

walk(fishingSpot.getPosition());

}

}

Edited May 9, 201312 yr by Aeterna

Use this for now, this is a specific problem with fishing spots.

 

/**
* Returns the closest NPC with the matching ID.
* @param ids The possible npc identifier numbers.
* @return The closest NPC. Returns null if none were found or are reachable.
*/
public NPC closestNPC(int... ids) {
NPC closestNpc = null;
int closestDistance = Integer.MAX_VALUE;
 
for(NPC npc : client.getLocalNPCs()) {
for (int id : ids) {
if(npc.getId() == id) {
int dist = distance(npc);
if(dist != -1 && dist < closestDistance) {
closestNpc = npc;
closestDistance = dist;
}
}
}
}
return closestNpc;
}