here is the code :-

if(furnacearea.contains(player)){
                    if(!myPlayer().isAnimating()){
                    //Make rings
                    MakeRings();
                    }
                }else{

                    //Go to furnacearea
                    walking.webWalk(furnacearea);

                 }

and my player won't stop moving how?

 

 

What is player? Use myPlayer()

if (furnacearea.contains(myPlayer())) {

Edited July 8, 20178 yr by Eliot

i made player as an entity

Player player = myPlayer();    

Could you show the makeRings() snippet?

Goldbar.interact("use");
                    furnace.interact("use");
                    sleep(1000);
                    getWidgets().get(446,8).interact("Make-X");
                    sleep(1000);
                    getKeyboard().typeString(NumGB, true);

sorry not a fancy code  my first script.

7 minutes ago, kadiem said:

Goldbar.interact("use");
                    furnace.interact("use");
                    sleep(1000);
                    getWidgets().get(446,8).interact("Make-X");
                    sleep(1000);
                    getKeyboard().typeString(NumGB, true);

sorry not a fancy code  my first script.

A lot of that needs to be nullchecked, you're also relying on the game to run perfectly smoothly which with the current servers, won't happen. Try using conditional sleeps and thinking about your logic a bit. Also avoid using static widget IDs like 446,8 and see if there's a text option or another alternative you could be using as these are prone to being updated and will break your script.  

Just now, HeyImJamie said:

A lot of that needs to be nullchecked, you're also relying on the game to run perfectly smoothly which with the current servers, won't happen. Try using conditional sleeps and thinking about your logic a bit. Also avoid using static widget IDs like 446,8 and see if there's a text option or another alternative you could be using as these are prone to being updated and will break your script.  

I don't know how to use conditionalsleep yet, so I'm stuck with the normal sleep and if statements :p now.

1 minute ago, kadiem said:

I don't know how to use conditionalsleep yet, so I'm stuck with the normal sleep and if statements :p now.

Why not learn.  Even so, your if statements could be re-ordered as you're still relying on 'game flow' for your script to work. What if you don't click make-x, or it doesn't load within a second? What if the furnace is null? etc. 

so i did this

 

Goldbar.interact("use");
                    furnace.interact("use");
                    sleep(random(1000,1500));
                    getWidgets().get(446,8).interact("Make-X");
                    sleep(3000);
                    getKeyboard().typeString(NumGB, true);
                    sleep(1000);
                    new ConditionalSleep(random(3000, 5000))
                      {
                        public boolean condition()
                          throws InterruptedException
                        {
                          return !myPlayer().isAnimating();
                        }
                      }.sleep();

 

and it didn't work, what did i do wrong?

Edited July 8, 20178 yr by kadiem

9 minutes ago, kadiem said:

so i did this

 

Goldbar.interact("use");
                    furnace.interact("use");
                    sleep(random(1000,1500));
                    getWidgets().get(446,8).interact("Make-X");
                    sleep(3000);
                    getKeyboard().typeString(NumGB, true);
                    sleep(1000);
                    new ConditionalSleep(random(3000, 5000))
                      {
                        public boolean condition()
                          throws InterruptedException
                        {
                          return !myPlayer().isAnimating();
                        }
                      }.sleep();

 

and it didn't work, what did i do wrong?

Pretty sure it's "Use", not "use". Are you checking the furnace exists or gold bars exist?

 

changed to Use no difference and no I'm not checking if the furnace or gold bar exist I'm just making the client Use gold on furnace.

Entity furnace = objects.closest("Furnace");

Item Goldbar = inventory.getItem("Gold bar"); 

It's getObjects(), not objects and it's getInventory()

Try something like:

if (getInventory().contains("Gold bar){
	if (furnace != null){
		if widget is up
			interact
		else if item is selected and selected item == gold bar
			use on furnace
		else if item is selected and selected item isnt gold bar
			deselect item
		else
			interact with gold in inv

But obviously fill in the code

Edited July 8, 20178 yr by HeyImJamie

I don't think the problem is in that part because the script is working, the problem is in the sleep, conditionalsleep is not working.

21 minutes ago, kadiem said:

I don't think the problem is in that part because the script is working, the problem is in the sleep, conditionalsleep is not working.

Your conditional should return when your player is Animating. If it's !.isAnimating it'll return instantly

didn't get you, what do you mean?