roguehippo's Basket Filler

[roguehippo]

Hello everyone, I am thinking about applying for scripter status and decided to show the community what i can do. Here is a script i quickly made to fill baskets!  

works by any banker npc just have the empty baskets and whatever object you want to fill them with in the bank.

includes: 

easy to use gui

all fruit / vegetable options 

 

let me know if any bugs are found, thanks!

( I updated with gui of time spent and baskets made)

the baskets made / hr will be around 1600 and can profit from like 150k - 300k depending on prices

BasketFiller.jar

Edited June 12, 2017 by roguehippo
updated file

[KyleDBusey]

How much money per hour does this net?

[roguehippo]

i dunno i havent really bought in enough quantity to check but probably a great amount for needing 0 reqs

I can actually add some paint to show baskets filled / hr and reupload

Edited June 12, 2017 by roguehippo

[Psycho White]

script is way glitchy barely usable, wouldnt recommend anyone use this

[roguehippo]

i didnt really put too much time into it, maybe some feedback of how it is bad would let me fix it. 

[ruzhda]

Is any chanse to script to work more than 1 hours + , it stop by it self it say bot need to restart.

[Team Cape]

On 8/11/2017 at 3:05 PM, roguehippo said:

i didnt really put too much time into it, maybe some feedback of how it is bad would let me fix it. 

If you want feedback, post the code and people can critique it.

[d0zza]

I used a decompiler to take a look at your code and there are a few things I can see that could use some fixing up before applying for scripter status.

1) OSbot's API methods can fail and so you should be checking if they return true before sleeping after calling them. Example:

if (bank.depositAll()) {
	sleep;
}

2) You should be using conditional sleeps instead of just random sleeps so that the script waits till the condition has passed.

3) I don't know why you're declaring String arrays every time you want to interact with something. 

NPC banker = (NPC)this.getNpcs().closest(new String[]{"Banker"});

should be

NPC banker = (NPC)this.getNpcs().closest("Banker");

And even then, it's a good idea to store things as variables and even final variables if you know the value is never going to change.

[roguehippo]

1 hour ago, d0zza said:

I used a decompiler to take a look at your code and there are a few things I can see that could use some fixing up before applying for scripter status.

1) OSbot's API methods can fail and so you should be checking if they return true before sleeping after calling them. Example:

if (bank.depositAll()) {
	sleep;
}

2) You should be using conditional sleeps instead of just random sleeps so that the script waits till the condition has passed.

3) I don't know why you're declaring String arrays every time you want to interact with something. 

NPC banker = (NPC)this.getNpcs().closest(new String[]{"Banker"});

should be

NPC banker = (NPC)this.getNpcs().closest("Banker");

And even then, it's a good idea to store things as variables and even final variables if you know the value is never going to change.

i didnt even know that osbot functions returned true if they were successful, i can think of so many places where this would get rid of some bugs. thanks so much for the helpful information!