1. OSBot Version:

2.4.111

2. A description of the issue:

This may not be a bug, but certainly feels like an inconsistency! It causes a few issues when comparing usernames with spaces to a correctly formatted original. When calling message#getUsername(), non-breaking spaces are not replaced.

i.e when calling message#getUsername() with a player name containing a space, an unprintable character is in the space, namely ascii 160.

This means comparing two names

String name = "Example name";

and

String nameToCompare = message.getUsername();

 returns false under equals(), despite the usernames being the same.

3. Are you receiving any errors in the client canvas or the logger? 

No. Ascii code 160 is printed as a space though, despite it not directly being one.

4. How can you replicate the issue?

List<Message> messages = trade.getRequestListener().getRequests();
List<String> verifiedNames = new ArrayList<>(Arrays.asList("Egg cress", "Bacon mayo"));
for (Message m : messages) {
	String username = m.getUsername();
  	if (verifiedNames.contains(username))
    	   log("Username " + username + " verified.");
    	else
      	   log("Username " + username + " not in " + verifiedNames);
}

Solution:

String username = m.getUsername().replaceAll("\u00A0", " ");

 

Edited February 19, 20179 yr by Apaec

Player getUsername() returns their unformatted name, meaning you will get the no-break space and any image tags (such as ironman and mods). It's been like that for a pretty long time and if I change the behavior I may be breaking a lot of scripts.