Herb Cleaning

[Team Cape]

Okay sorry bro i thought you were still wanted to fight with me or being my enemie, Lets clear everything!

Are we good now ?

If so i guarantee you that we will never fight again, We could be friends.

@@Imateamcape

 

nah i got over it pretty quick, im down to bury the hatchet we're cool

Edited September 30, 2016 by Imateamcape

[Mr Pro Pop]

Ohh thanks man, Sounds good!

Rip this thread hehe lolol xD @@Imateamcape

Edited September 30, 2016 by Mr Pro Pop

[Mr Pro Pop]

@@Imateamcape

Unblock me from the message center wanted to send you a pm!

Edited September 30, 2016 by Mr Pro Pop

[Team Cape]

@@Imateamcape

Unblock me from the message center wanted to send you a pm!

 

done

[Mr Pro Pop]

done

 

Still not allowing me to send anything.

 

The following errors were found

The member Imateamcape has chosen to not receive any new messages from you

This personal message has not been sent

 

@@Imateamcape

[House]

new RectangleDestination(getBot(),InventorySlotDestination.getSlot(#))

 useful for moving the mouse to item slots, can help when you iterate which slot has a herb in it as you mentioned you might not have a full inventory sometimes.

[Salty as fuck]

Then he could just do that to check if the bank has enough amount of the item or not..

if(bank.getItem("Item").getAmount() >= 28) {
    bank.withdraw("Item", 28);
}else {
    stop();
}

@@Imateamcape 

This is terrible. Please don't suggest anymore horrible ideas.

[Mr Pro Pop]

This is terrible. Please don't suggest anymore horrible ideas.

 

@

 

Why whats wrong with this ?

 

Edited September 30, 2016 by Mr Pro Pop

[Team Cape]

@

Fuck off it's not terrible, Don't just try to post shit when you don't even understand.

No other methods to check items quantity else than that.

If you really feel confident in yourself then let's see what other methods you have.

 

bro it's not necessary to check item quantity. he just needs to make an inventoryslotdestination and click on it. part of learning is understanding new abilities and adapting to them and using them when necessary. in this case, it's more efficient to use an inventoryslotdestination bro.

 

also i fixed the issue on skype i think

[PlagueDoctor]

kek

[Mr Pro Pop]

Item item = bank.getItem("Item");
  if(item != null && item.getAmount() > 0) {
} 

so is this one better ?

@@Imateamcape

Edited September 30, 2016 by Mr Pro Pop

[Salty as fuck]

@

Fuck off it's not terrible, Don't just try to post shit when you don't even understand.

No other methods to check items quantity else than that.

If you really feel confident in yourself then let's see what other methods you have.

Stupid ass arrogant grey name..

 

First of all, if he were to use that poor code of yours, it would only work so long as he has either 28, or over 28 grimy herbs in the bank. Which is stupid. On-top of that, it doesn't check whether or not the inventory is even empty.

 

Oh and I don't understand? Weird how I have a scripter rank and you don't. Pleb.

		if (bank.isOpen() && inventory.isEmpty()) {
			Item herby = bank.getItem("grimyHerb");

			if (bank.contains("grimyHerb")) {
				if (herby.getAmount() >= 28) {
					bank.withdraw("grimyHerb", 28);
				} else if (herby.getAmount() < 28 && herby.getAmount() > 0) {
					bank.withdraw("grimyHerb", herby.getAmount());
				} else {
					stop();
				}

				new ConditionalSleep(5000) {

					@[member=Override]
					public boolean condition() throws InterruptedException {
						return inventory.contains("grimyHerb");
					}
				}.sleep();
			}
		}

[Mr Pro Pop]

		if (bank.isOpen() && inventory.isEmpty()) {
			Item herby = bank.getItem("grimyHerb");

			if (bank.contains("grimyHerb")) {
				if (herby.getAmount() >= 28) {
					bank.withdraw("grimyHerb", 28);
				} else if (herby.getAmount() < 28 && herby.getAmount() > 0) {
					bank.withdraw("grimyHerb", herby.getAmount());
				} else {
					stop();
				}

				new ConditionalSleep(5000) {

					@[member='Override']
					public boolean condition() throws InterruptedException {
						return inventory.contains("grimyHerb");
					}
				}.sleep();
			}
		}

 

Alright, Thanks for that bro.

Btw I was just giving him suggestions!

Sorry for bothering!

Edited September 30, 2016 by Mr Pro Pop

[venetox]

 

Stupid ass arrogant grey name..

 

 

IMO that code has pointless checks and this code is cleaner.

Comments explain my thoughts on the get amount checks and why they aren't needed.

 

if (bank.isOpen() && inventory.isEmpty()) {
			
			// Note to newbies, if you had this check in the parent 'if' statement
			// And did 'else stop();' it would stop if the bank wasn't open or inventory wasn't empty.
			if(bank.contains("grimyHerb")) 
			{
				/* 
				 * Regardless of how many you have it will withdraw the most you can
				 * Therefore there is no need to check how many you have and withraw that many,
				 * Just withdraw all. If you have 21 it will withdraw 21 if you have 1 million
				 * It will withdraw as many as your inventory can fit.
				*/
				bank.withdrawAll("grimyHerb"); 
				
				new ConditionalSleep(5000) {

					@[member='Override']
					public boolean condition() throws InterruptedException {
						return inventory.contains("grimyHerb");
					}
				}.sleep();
			}
		}

also kek at this thread

Edited September 30, 2016 by venetox

[Salty as fuck]

 

IMO that code has pointless checks and this code is cleaner.

Comments explain my thoughts on the get amount checks and why they aren't needed.

 

if (bank.isOpen() && inventory.isEmpty()) {
			
			// Note to newbies, if you had this check in the parent 'if' statement
			// And did 'else stop();' it would stop if the bank wasn't open or inventory wasn't empty.
			if(bank.contains("grimyHerb")) 
			{
				/* 
				 * Regardless of how many you have it will withdraw the most you can
				 * Therefore there is no need to check how many you have and withraw that many,
				 * Just withdraw all. If you have 21 it will withdraw 21 if you have 1 million
				 * It will withdraw as many as your inventory can fit.
				*/
				bank.withdrawAll("grimyHerb"); 
				
				new ConditionalSleep(5000) {

					@[member='Override']
					public boolean condition() throws InterruptedException {
						return inventory.contains("grimyHerb");
					}
				}.sleep();
			}
		}

just because your version is more simplistic, it doesn't necessarily mean it's better.

the checks are also objective, you pronounce it tomato, i pronounce it tomatoe, etc

i'd rather not spam the player's game chat with "you do not have enough inventory space for that".