Jump to content

Botre

Members
  • Posts

    5883
  • Joined

  • Last visited

  • Days Won

    18
  • Feedback

    100%

Posts posted by Botre

  1. 10 hours ago, The Viking said:

    Not only are your percentages completely anecdotal and have no actual proof to back them up, but the "example" you gave is a complete exaggeration and misrepresentation of my point.  If you would bother to do some actual research, you would see that your claim is way off. Far cry from the "1%" number you gave.

    1dc30d92798e0920bc9cfb3f74b331af.png

    Source: https://github.com/outsideris/popularconvention (Somebody analyzed code conventions across commits on GitHub)

    You're once again off base with your statement that "you are introducing inconsistencies in other people's code base by not respecting the dominant code-style.". What about the 37% of people that use new line braces? Are you introducing inconsistencies into their code base if you release a snippet? No, because they should adjust it to fit with their own preference. I wouldn't consider that a difficult task.

    As long as they are consistent within their own code-base, it doesn't matter which style they use. This is even true at the corporate level, where conventions can vary from company to company. For example, brace placement, tabs vs spaces, line length, variable naming and exception catch clauses (empty catch blocks, swallowing exceptions) are just some of the nuances that can vary from company to company. It isn't a problem though, since their specific rules apply to their specific code base.

    The 1% was a dramatisation but I have to admit that I'm very surprised the number is that high.

    Kinda makes me want to see the details of these percentages (geographic distribution, which types of project use which convention, etc..).

    All the big Java frameworks, libraries, open source projects I have ever visited, oh and the Java library itself do not newline, hence why I'm so surprised.

    Of-course most of my points become invalid without the data to back them up :)

    Cheers.

     

    • Like 1
  2. 10 hours ago, The Viking said:

    Callable was only implemented due to a suggestion above, and this was before I knew BooleanSupplier even existed. I will update the thread to use BooleanSupplier instead.

    Your comment on brace placement is completely subjective. I really hope you won't try to argue otherwise. Sure, there is a 1997 article our there where Oracle states that braces on the same line is the convention, however it's pretty much universally known as a personal choice (as long as you're consistent).

    Thank you for the feedback however, I really do appreciate it.

    You are sharing this snippet for other people to integrate it in their code.

    Most people don't newline.

    Therefore you are introducing inconsistencies in other people's code base by not respecting the dominant code-style.

    Code style always is a personal choice, that doesn't mean you shouldn't be pragmatic about it.

    You are the 1% in this case, don't expect the 99% to deviate from the convention just 'because of  subjectivity'.

    I know, I know, I'm a pain in the ass.

    public class fuckConventions() 
    
    {
    
    public
    
    fuckConventions()
    
    {
    
    // lower*burp*case constructor bro i dont give a fuuuuuuuuuuuck
    
    }
    
    public void UpperCaseMethodsBoy()
    
    {
    
    // hahahaha nope not a constructor just a regular method wubba lubba dub dub
    
    }
    
    }

     

    • Like 1
  3. Please stop using the callable interface for things like this

    Callable is reserved for concurrent programming hence why it's in the java.util.concurrent package and not the java.util.function package.

    Want to get 'functional'? Use the java.util.function package (https://docs.oracle.com/javase/8/docs/api/java/util/function/package-summary.html). You more specifically probably should use a BooleanSupplier in this case.

    Oh and by the way, curly braces usually aren't newlined in Java (this isn't C# !!!), I recommend you drop this habit asap .

    11/10 for effort in terms of documentation and overal cleanness of you code though :)!

     

     
     
     
     

     

     

    • Like 2
  4. 2 minutes ago, QuakedM8 said:

    It's a decent design but nothing special really..

    Have a look at Material Design's documentation, some good points. -> https://material.google.com

    Also for the header, is all the content under class because it seems like they're not all vertically aligned to the center.

    Any particular points of the MD spec you recommend adding to what I currently have?  

    I agree that it's an interesting standard but I tend too really dislike working with most framework implementations of it. Also hate the fact that most implementations are a pain to customize so you end up with an app that looks like every other google application, meh.

    Thanks for pointing out the vertical alignement issue!

  5. Hello all,

    Spent the afternoon working on the frontend of a customer care portal for a product I'm building, your feedback would be most welcome.

    Yes it uses bootstrap, yes I'm totally jumping on the gradient bandwagon, no I'm not switching to wordpress ew.

    portal.png

    Inspiration: (Slack help center, I'm pretty sure it's served by Zendesk Guide but I ain't spending 600$/year if I can write it in 2 weeks)

    slack.png

  6. - Acts cocky & tells everyone they should invest in ETH, they will thank him in a week because he's an investing genius and not a gambler at all

    - ETH crashes -20%

    - Lol short term thinkers

    • Like 1
  7. 2 hours ago, Alek said:

    Event execute() is an internal method used by the event executor. You can use either

    bot.getEventExecutor().execute(event) or the wrapper method which is simply "execute(Event)"

    therefore

    execute(e); will work

    Hi,

    Might be a good idea to put this in the docs.
    Also, since you probably can't hide this method from the public API, could be a good idea to return an error with a message containing what you just explained whenever the method is called 'inappropriately'.

    I remember this part of the API causing me so many headaches back in the day.

    Bye

    • Like 2
  8. Feedback:

    - I see three verbs: 'sign in', 'register' & 'log in'. You only need two, one for each action / flow.

    - 'Forgot your password' indirectly blames the user and is not complete, what if the user forgot his username? 'Trouble logging in?' Is a personal favourite of mine.

    - Light pink placeholder text on a white background is a big no no for me.

    - Getting a user to register is a lot more difficult than convincing an existing user to log back in, yet in this piece both seem equally important, emphasise more valuable call-to-actions. On top of this, mobile apps keep you logged in most of the time so the space you give to the 'sign in' action really is wasted.

    - You are literally asking the user: 'Sign in or Register?', you should answer these questions for him (oh & flip the order, see comment above): "New user? Register. Existing user? Sign in."

    As is, you're not convincing me to press that register button. I takes more than a flashy shade of pink these days ; )

    • Like 1
  9. 3 hours ago, Butta said:

     @Botre have a nice day flipping burgers @ mcdonalds 

    Making money betting blindly doesn't make you smart.

    I prefer creating value instead of making it up, that's all.
    Very few companies survived the dotcom bubble, I sincerely hope you don't end up losing your hard-earned runescape goldfarming retirement fund.

  10. 10 hours ago, Butta said:

    you probably don't even know what Ethereum is, why do you even try to argue?
    if you knew, you wouldn't be typing this shit.

    Google "EEA ethereum" and figure out which companies are building on top of Ethereum and not because of the price .
    Please, at least do a research of 10minutes before you copy paste shit from a bullshit generator

    I do know what Ethereum is kid.

    Ethereum as a decentralised distributed computing platform is awesome.

    Ether as a virtual currency is just another bubble.

    Do you even understand the difference between Ethereum & Ether? The EEA is nothing but a bunch of companies trying to jump on the blockchain bandwagon, they don't give a fuck about you made up little coins.

    • Like 1
  11. Just now, Butta said:

    C'mon , you talk like a 60y/o old man. 
    please do some research before you throw away with words you have no idea of. 
     
    "can't use in real world" - http://tokencard.io/#vision

    Why can't you just admit that the only reason the vast majority of people are interested into these currencies is because they keep rising?

    Try to sell someone the concept of cryptocurrencies without mentioning their rising exchange rate, it's almost impossible.

    That card seems clever, I'll gave you that.
     

  12. 3 minutes ago, Butta said:

    i don't know where you live, but you can use these currencys in the "real world" lmao.

    Europe.

    Last time I checked you can't use it in 99% of the physical shops or on any of the big online stores.

    People are buying these coins to feed a bubble they think will make them rich, that's it.
     

×
×
  • Create New...