[Combat snippet]

This won't return any NPCs that are offscreen because of NPC#isVisible(), it's probably best to remove that entirely and have the script itself run to the off-screen enemy if necessary.

 

Also, like mentioned earlier, NPC#isUnderAttack() isn't the most reliable thing to use. Rather, I'd recommend using NPC#getFacing() to see who the NPC is interacting with. If it's you, always return that one. If it's someone else, they're in combat already, so skip it. If it's null, they're likely not in combat (idle), so chose that one.

Updated according to your comments.

[Combat snippet]

Use of filters is more efficient. Also, NPC#isUnderAttack is bad.

I'm not seeing anything related to filters in the api. Care to explain?

[Combat snippet]

Filterrrrsss.

More input please and your love for adriana grande is slightly disturbing.

You're disturbing. l2spell

L2spell? Lol what did i spell wrong?

[Combat snippet]

Filterrrrsss.

More input please and your love for adriana grande is slightly disturbing.

[Combat snippet]

nice only that i see NPCs there useless as you can just do

for(NPC i:enemies){

...

}

Fixed thanks.

[Combat snippet]

Decided to share this as the get closestAttackableNPC wasn't working that great for me. Enjoy guys

private NPC getTarget(int [] ids){
	List<NPC> NPCs = closestNPCList(ids);
	for (NPC i:NPCs){
		if (i.getFacing() == null && !i.isAnimating()){
			return i;
		}
		}
		
	
	return null;
	}