GaetanoH

March 17, 2016

I guess you're Dutch?

March 17, 2016

Is there any way to pay without RSGP?

March 16, 2016

Its actually that that the cooking animation ends -> interp (-1) -> new cooking animation.

Using a Timer allows it to skip that interp and if the idle is longer than say 1000ms then you would try to cook again/bank or what not.

Instead of:

 isCooking = myPlayer().getAnimation() != -1 ? true : isCooking;

if(emeraldBenedict != null){
    if(!bank.isOpen()){
        emeraldBenedict.interact("Bank");
        sleep(1500);
        if(bank.isOpen()){
            bank.depositAll();
            bank.withdraw("Raw trout", 28);
            bank.close();
            sleep(random(300,400));
        }
    }
}

you could do:

 isCooking = myPlayer().isAnimating();

 if(emeraldBenedict != null){
     if(!getBank().isOpen()){
          emeraldBenedict.interact("Bank");
          sleep(1500);
     }else{
          getBank().depositAll();
          getBank().withdraw("Raw trout", 28);
          getBank().close();
          sleep(random(300,400));
     }
}

Plus you shouldn't nest your if statements so often.

And don't return null in your getState(), if something goes wrong you will get npe's just add a waiting state

in you're states returning null is a bad idea in my opinion. If something goes wrong and the conditions are not met returning null is not a good idea. A fail safe would be better implemented

1. You don't need to store cooking xp

2. Split your code into more methods, each method should do one thing

3. Use ConditionalSleeps

Your banking should look more like:

private void bank(){
    if(!getBank().isOpen()) openBank();
    else if(!getInventory().isEmptyExcept("Raw trout")) getBank().depositAll();
    else if(!getInventory().contains("Raw trout")) getBank().withdrawAll("Raw trout");
    else getBank().close();
}

private void openBank(){
    NPC emeraldBenedict = getNpcs().closest("Emerald Benedict");
    if(emeraldBenedict != null){
        emeraldBenedict.interact("Bank");
        new ConditionalSleep(5000) {
            @Override
            public boolean condition() throws InterruptedException {
                return getBank().isOpen();
            }
        }.sleep(); 
    }
}

Your getState should only return BANKING or COOKING:

private State getState(){
    return !getBank().isOpen() && getInventory().contains("Raw trout") 
           ? State.COOKING
           : State.BANKING;
}

For Widgets you should use getWidgetContainingText() wherever possible. So your cooking method should look more like:

private void cook(){

    RS2Widget troutWidget = getWidgets().getWidgetContainingText("Trout");
    
    if(troutWidget != null) troutWidget.interact("Cook All");
    else if(!isTroutSelected()) getInventory().getItem("Raw trout").interact("Use");
    else useFire();
}

private boolean isTroutSelected(){
    Item selectedItem = getInventory().getSelectedItem();
    return selectedItem != null && selectedItem.getName().equals("Raw trout");
}

private void useFire(){

    RS2Object fire = getObjects().closest("Fire");
    if(fire != null){
        fire.interact("Use");
        new ConditionalSleep(1500){
            @Override
            public boolean condition() throws InterruptedException {
                return getWidgets().getWidgetContainingText("Trout") != null;
            }
        }.sleep();
    }
}

You can also avoid using a timer by using a ConditionalSleep. So all together your script could look more like:

import org.osbot.rs07.api.model.NPC;
import org.osbot.rs07.api.model.RS2Object;
import org.osbot.rs07.api.ui.RS2Widget;
import org.osbot.rs07.api.ui.Skill;
import org.osbot.rs07.script.Script;
import org.osbot.rs07.script.ScriptManifest;
import org.osbot.rs07.utility.ConditionalSleep;

import java.awt.*;
import java.text.DecimalFormat;

@ScriptManifest(name = "RogueDenCooker", author = "GaetanoH", version = 1.0, info = "", logo = "")
public class RogueDenCooker extends Script {

    private long startTime;

    public enum State {
        COOKING, BANKING;
    }

    private State getState(){
        return !getBank().isOpen() && getInventory().contains("Raw trout")
               ? State.COOKING
               : State.BANKING;
    }

    @Override
    public void onStart() {
        log("Thanks for using my Rogue's Den Cooker, please start with enough food in the bank");
        startTime = System.currentTimeMillis();
        getExperienceTracker().start(Skill.COOKING);
    }

    @Override
    public int onLoop() throws InterruptedException {

        switch(getState()){
            case COOKING:
                cook();
                break;
            case BANKING:
                bank();
                break;
        }
        return random(200, 300);
    }

    private void cook(){

        if(getTroutWidget() != null) cookAll();
        else if(!isTroutSelected()) getInventory().getItem("Raw trout").interact("Use");
        else useFire();
    }

    private void cookAll(){
        if(getTroutWidget().interact("Cook All")){
            new ConditionalSleep(60_000){
                @Override
                public boolean condition() throws InterruptedException {
                    return !getInventory().contains("Raw trout");
                }
            }.sleep();
        }
    }

    private boolean isTroutSelected(){
        Item selectedItem = getInventory().getSelectedItem();
        return selectedItem != null && selectedItem.getName().equals("Raw trout");
    }

    private void useFire(){

        RS2Object fire = getObjects().closest("Fire");
        if(fire != null){
            fire.interact("Use");
            new ConditionalSleep(1500){
                @Override
                public boolean condition() throws InterruptedException {
                    return getTroutWidget() != null;
                }
            }.sleep();
        }
    } 

    private RS2Widget getTroutWidget(){
        getWidgets().getWidgetContainingText("Trout");
    }

    private void bank(){
        if(!getBank().isOpen()) openBank();
        else if(!getInventory().isEmptyExcept("Raw trout")) getBank().depositAll();
        else if(!getInventory().contains("Raw trout")) getBank().withdrawAll("Raw trout");
        else getBank().close();
    }

    private void openBank(){
        NPC emeraldBenedict = getNpcs().closest("Emerald Benedict");
        if(emeraldBenedict != null){
            emeraldBenedict.interact("Bank");
            new ConditionalSleep(5000) {
                @Override
                public boolean condition() throws InterruptedException {
                    return getBank().isOpen();
                }
            }.sleep();
        }
    }
    
    @Override
    public void onPaint(Graphics2D g) {
        Point mP = getMouse().getPosition();

        g.drawLine(mP.x - 5, mP.y + 5, mP.x + 5, mP.y - 5);
        g.drawLine(mP.x + 5, mP.y + 5, mP.x - 5, mP.y - 5);

        long runTime = System.currentTimeMillis() - startTime;

        cookingXP = getExperienceTracker().getGainedXPPerHour(Skill.COOKING);

        g.drawString("Time running: " + formatTime(runTime), 10, 290);
        g.drawString("Experience/h: " + String.valueOf(cookingXP), 10, 310);
        g.drawString("Made by GaetanoH", 10, 330);
    }

    private String formatTime(long ms){

        long s = ms / 1000, m = s / 60, h = m / 60, d = h / 24;
        s %= 60; m %= 60; h %= 24;

        return d > 0 ? String.format("%02d:%02d:%02d:%02d", d, h, m, s) :
               h > 0 ? String.format("%02d:%02d:%02d", h, m, s) :
               String.format("%02d:%02d", m, s);
    }
}

Hope that helps

Holy shit, thanks for the feedback tomorrow I'll get in to it! Thank you very much!

March 16, 2016

Hello, I've been working on this for a while now and I still want to add these features.

Able to cook all fishes
Fish cooked
TTL
Add antiban

But I still want some feedback, what should you guys've done better?

import org.osbot.rs07.api.model.NPC;
import org.osbot.rs07.api.model.RS2Object;
import org.osbot.rs07.api.ui.RS2Widget;
import org.osbot.rs07.api.ui.Skill;
import org.osbot.rs07.script.Script;
import org.osbot.rs07.script.ScriptManifest;
import org.osbot.rs07.utility.ConditionalSleep;


import java.awt.*;
import java.text.DecimalFormat;


@ScriptManifest(name = "RogueDenCooker", author = "GaetanoH", version = 1.0, info = "", logo = "")
public class RogueDenCooker extends Script {

    private int cookingXP = 0;
    private long startTime;

    public enum State {
        COOKING, BANKING;
    }

    public State getState(){
        if(!bank.isOpen() && inventory.contains("Raw trout")){
            return State.COOKING;
        }

        if(!inventory.contains("Raw trout")){
            return State.BANKING;
        }
        return null;
    }

    @Override
    public void onStart() {
        log("Thanks for using my Rogue's Den Cooker, please start with enough food in the bank");
        startTime = System.currentTimeMillis();
        getExperienceTracker().start(Skill.COOKING);
    }

    @Override
    public void onExit() {

    }

    @Override
    public int onLoop() throws InterruptedException {

        switch(getState()){
            case COOKING:
                RS2Object fire = getObjects().closest("Fire");
                RS2Widget widget = getWidgets().get(307, 2);
                if(!isCooking()){
                    if(widget == null){
                        getInventory().getItem("Raw trout").interact("Use");
                        if(fire.isVisible() &&  myPlayer().isVisible()){
                            fire.interact("Use");
                            new ConditionalSleep(1500){
                                @Override
                                public boolean condition() throws InterruptedException {
                                    return widget != null;
                                }
                            }.sleep();
                        }
                    } else {
                        widget.interact("Cook All");
                    }
                }
                break;
            case BANKING:
                NPC emeraldBenedict = getNpcs().closest("Emerald Benedict");
                if(emeraldBenedict != null){
                    if(!bank.isOpen()){
                        emeraldBenedict.interact("Bank");
                        sleep(1500);
                        if(bank.isOpen()){
                            bank.depositAll();
                            bank.withdraw("Raw trout", 28);
                            bank.close();
                                sleep(random(300,400));
                            }
                        }
                    }
            break;
        }

        return 100;
        }

    public String formatTime(long ms){

        long s = ms / 1000, m = s / 60, h = m / 60, d = h / 24;
        s %= 60; m %= 60; h %= 24;

        return d > 0 ? String.format("%02d:%02d:%02d:%02d", d, h, m, s) :
                h > 0 ? String.format("%02d:%02d:%02d", h, m, s) :
                        String.format("%02d:%02d", m, s);
    }

    @Override
    public void onPaint(Graphics2D g) {
        Point mP = getMouse().getPosition();

        g.drawLine(mP.x - 5, mP.y + 5, mP.x + 5, mP.y - 5);
        g.drawLine(mP.x + 5, mP.y + 5, mP.x - 5, mP.y - 5);

        long runTime = System.currentTimeMillis() - startTime;

        cookingXP = getExperienceTracker().getGainedXPPerHour(Skill.COOKING);

        g.drawString("Time running: " + formatTime(runTime), 10, 290);
        g.drawString("Experience/h: " + String.valueOf(cookingXP), 10, 310);
        g.drawString("Made by GaetanoH", 10, 330);

    }

    public boolean isCooking() {
        boolean isCooking = false;
        Timer timer = new Timer(1800);
        while (timer.isRunning() && !isCooking) {
            isCooking = myPlayer().getAnimation() != -1 ? true : isCooking;
        }
        return isCooking;
    }


    public class Timer {
        private long period;
        private long start;
        public Timer(long period) {
            this.period = period;
            this.start = System.currentTimeMillis();
        }
        public long getElapsed() {
            return System.currentTimeMillis() - this.start;
        }
        public long getRemaining() {
            return this.period - this.getElapsed();
        }
        public boolean isRunning() {
            return this.getElapsed() <= this.period;
        }
        public void setPeriod(long period) {
            this.period = period;
        }
        public void reset() {
            this.start = System.currentTimeMillis();
        }
        public String format(long milliSeconds) {
            long secs = milliSeconds / 1000L;
            return String.format("%02d:%02d:%02d", secs / 3600L,
                    secs % 3600L / 60L, secs % 60L);
        }
    }
}

Thanks in advance! Really enjoy the community so far, really helpful!

March 16, 2016

Hello I have some questions regarding the animation when cooking, so I get it when your cooking you're isAnimating() == true but when your character "gets up" to get the other fish it stops animating so my bot spams click the fish on the fire...

Any way on how I can fix this, using a conditional sleep isn't very good because I always have a random number of trouts/salmon in my inventory so this would make the bot slow.

Thanks in advance!

March 15, 2016

So how do you use an item on a fire?

March 15, 2016

Yeah i saw what line it was but didn't see my mistake

March 15, 2016

Oh yeah..., knew it was something small, thank you man!

It was the fact that I checked if you had salmon/trout before fishing which ended up not working and just standing still

March 15, 2016

Hello, so I'm busy making a trout/salmon fishing script I know it's far from finished but somehow the bot always seems to get a nullpointer exception and I can't seem to find the problem... Can somebody please help me out?

Thanks in advance GaetanoH

import org.osbot.rs07.api.map.Area;
import org.osbot.rs07.api.map.Position;
import org.osbot.rs07.api.model.Entity;
import org.osbot.rs07.script.Script;
import org.osbot.rs07.script.ScriptManifest;
import org.osbot.rs07.utility.ConditionalSleep;

import java.awt.*;

/**
 * Created by Gaetano on 15/03/16.
 */
@ScriptManifest(name = "Salmon/Trout Fisher", author = "GaetanoH", version = 1.0, info = "", logo = "")
public class Fisher extends Script {

    public enum State {
        FISHING, DROPPING;
    }

    public State getState(){
        if(!inventory.contains("Raw trout") && !inventory.contains("Raw salmon")){
            log("fishing");
            return State.FISHING;
        }

        if(inventory.isFull() && inventory.contains("Raw trout") && inventory.contains("Raw salmon")){
            log("dropping");
            return State.DROPPING;
        }

        return null;
    }

    @Override
    public void onStart() throws InterruptedException {
        log("Welcome to my Barbarian Village Fisher/Cooker, start with a fly fishing rod with enough feathers, a tinderbox and a axe equipped.");
    }

    @Override
    public void onExit() throws InterruptedException {
        log("Thanks for using my script");
    }

    @Override
    public int onLoop() throws InterruptedException {
        switch (getState()) {
            case FISHING:
                if(!myPlayer().isAnimating()){
                    getNpcs().closest("Fishing spot").interact("Lure");
                }
                break;
            case DROPPING:
                getInventory().dropAllExcept("Fly fishing rod", "Feather");
                break;
        }

        return random(500, 800);
    }

    @Override
    public void onPaint(Graphics2D g) {

    }
}

March 14, 2016

Welcome GaetanoH!

Have a great time here, goodluck with the scripting part!

Khaleesi

Thank you!

March 14, 2016

Whalecum

March 14, 2016

Hello everyone, my name is GaetanoH, I'm 20 years old and a Java programmer, I've been lurking on the forums for a few months now. But I'm really liking to script for this bot and wanted to be more active, hope you guys enjoy my future scripts I'll write and I'll hope I have a good stay!

Posted March 10, 2016 · March 10, 2016

Trail for the fletcher pls

March 9, 2016

Invalid or corrupt jar file mate!

Thanks mate!

Thank you!

I get a incorrupt jar file error

March 9, 2016

Can you make the clicking faster? If you can make it faster there is a way to make around 250k fletching xp per hour

March 9, 2016

What are those money making methods? I never seem to be making money

Sign In

GaetanoH

Posts

Joined

Last visited

Feedback

Content Type

Profiles

Forums

Store

Posts posted by GaetanoH

dis is my jam

Harry's Graphic Design Shop [CHEAP ★ FAST ★ RELIABLE]

Please give me some constructive criticism on my first script!

Please give me some constructive criticism on my first script!

How to check if bot is cooking

How to use inventory item on fire?

Fishing script help

Fishing script help

Fishing script help

Hello OSBot!

Hello OSBot!

Hello OSBot!

👑 Perfect Czar Free Trials & Demos 👑 MOST POPULAR 👑 HIGHEST QUALITY 👑 MOST TOTAL USERS 👑 LOWEST BAN-RATES 👑 24/7 SUPPORT 👑 SINCE 2015 👑 MANY SKILLS 👑 MOST VIEWS 👑 MOST REPLIES 👑

BoltMaker

[Free] ItemOnItem, uses item A on item B.

Perfect Fletcher AIO

Browse

Store

Search