1. OSBot Version (do NOT put "current version", be specific)

2.4.53

 

2. A description of the issue. Include relevant logs.

 

CODE:

 

 

The code shows a Task called HandleKebabDialog.

 

It runs if 2 conditions are met:

1) A dialogue is open (Options, Continue, Any other dialogue)

2) Inside the area kebab house

 

Below you can see OSBot open, there is no dialogue open. Yet one of the dialogue methods is returning true: inDialogue(), isPendingOption(), isPendingContinuation().

 

We know this because the logger shows the text HandleKebabDialog, proving that shouldRun() returned true, and void run subsequently was called.

 

 

Important note:

 

I used to use widgets.get(231/217/219) - those are the widget ids for each of the 3 dialogues. (OPTION, NPC_CHAT_HEAD, PLAYER_CHAT_HEAD)

 

This worked, but after a few hours Kebab buyer was incorrectly being told widget.getVisible(231/217/219) was visible when it was not, or vice versa. So I switched to the OSBot API Dialogues.

 

Yet this problem/something similar still happens with it. Very odd. Please let me know because people are reporting this issue on my thread (that the script randomly stops). Now I know why.

 

 

3. Are you receiving any errors in the client canvas or the logger? 

No

 

4. How can you replicate the issue?

Leave kebab buyer running for a few hours, but when it happens script stops moving the mouse, so it logs out after 5 minutes, and the script recovers. So it's hard to catch it, today I was lucky.

 

5. Has this issue persisted through multiple versions? If so, how far back?

at least a few months

I need something which is simple and reproducible. Your method shouldRun() is using 3 dialogue methods and an area check. Pin this down to one method in the dialogues class and I'll thoroughly investigate it.

I need something which is simple and reproducible. Your method shouldRun() is using 3 dialogue methods and an area check. Pin this down to one method in the dialogues class and I'll thoroughly investigate it.

 

I have narrowed it down further now.

 

In the shouldRun() method, I removed the 3rd check: dialogues.inDialogue()

 

So shouldRun now only does 2 checks, and it works perfectly now:

 

 

 

After 20 minutes to 2 hours, dialogues.inDialogue() was always returning true (even if dialogue was closed). Are widgets being cached or something? I don't know. (People reported this bug as "the script randomly freezes, then it logs out and starts working again")

 

I let the script run, and was able to re-produce this after about 45 minutes of it running perfectly. I tried clicking Talk-to Karim manually (which opens the NPC). The script state stays then works through the Kebab Dialogues (clicking continue, doing the various options, and then after it buys the Kebab, the dialogue closes again, and the script freezes).

 

If I manually logout, (or let the script sit for 5 minutes so it logs out), AutoLogin random event runs: the bot logs back in - and the script recovers. The dialogues.inDialogue() *seems* to recover on login, and it starts working as normal. (If you do not logout/in again it always returns true). Hard for me to reproduce this except for letting the script run, waiting for it to occur and giving you my teamviewer details to connect remotely.

 

(Since removing the 3rd check from shouldRun,  inDialogue(), people are now reporting that Kebab Buyer does not freeze anymore after 20min-2hrs)

 

NOTE: Because this simple script runs well for a long period, I hope this helps to show you I am not being a derp :p

Edited April 27, 201610 yr by DragonAlpha

Was this ever solved seeing that it's still here?