2.3.48: MouseDestination bug

March 21, 201511 yr

OSBot version number:

2.3.48

Description of the bug/error:

A MouseDestination retrieved from inventory#getMouseDestination(slot) will close a bank window before execution, as it apparently now deems that the inventory is inaccessible while the bank is open. I'm guessing you've added an internal tab variable in some implementations of MouseDestination recently?

Anyhow. This prevents mouse#click(destination, true/false) from being usable with the previously mentioned mousedestination while the bank is open.

Instructions how to replicate the bug/error:

Open bank -> get a MouseDestination using inventory#getMouseDestination(slot) -> click at the destination using mouse#click(destination)

(IF APPLICABLE) SSCCE that causes the bug/error:

(IF APPLICABLE) Script name ran causing the bug/error. Optionally include relevant parts of source code:

Code that caused the error (Not working):

	public boolean fastDeposit(int id, String action) throws InterruptedException {
		int _slot = inv().getSlot(id);
		boolean left = action.equals("Deposit-1");
		MouseDestination dest = inv().getMouseDestination(_slot);
		boolean click = parent.getMouse().click(dest, !left);
		if (left) {
			return click;
		}
		Menu menu;
		if (click && (menu = Menu.getActiveMenu(parent)) != null && menu.hasOption(action, null)) {
			FrostBarrow.sleep(random(100, 150));
			if (menu.isMouseOnOption(action, null)) {
				parent.getMouse().click(false);
				return true;
			} else {
				return menu.moveMouseToOption(action, null, true);
			}
		}
		return false;
	}

Temporary workaround (working):

	public boolean fastDeposit(int id, String action) throws InterruptedException {
		int _slot = inv().getSlot(id);
		boolean left = action.equals("Deposit-1");
		MouseDestination dest = inv().getMouseDestination(_slot);
		MouseDestination rDest = new RectangleDestination(parent.getBot(), dest.getBoundingBox());
		boolean click = parent.getMouse().click(rDest, !left);
		if (left) {
			return click;
		}
		Menu menu;
		if (click && (menu = Menu.getActiveMenu(parent)) != null && menu.hasOption(action, null)) {
			FrostBarrow.sleep(random(100, 150));
			if (menu.isMouseOnOption(action, null)) {
				parent.getMouse().click(false);
				return true;
			} else {
				return menu.moveMouseToOption(action, null, true);
			}
		}
		return false;
	}

(IF APPLICABLE) Screenshots: