Fix the hook for noted items getName()

Followers

April 7, 201412 yr

Using Client Version: v1.7.98

Issue: getName() of any noted item returns "null"

Media(Pics\Logs): N/A

3 weeks later...

April 25, 201412 yr

Have this snippet (working):

public static String tryGetNotedItemName(int notedId) {
		ItemDefinition def = ItemDefinition.forId(notedId - 1);
		if (def == null)
			return null;
		return def.getName();
	}

	public static String getItemNameNoted(Item item) {
		if (item == null)
			return null;
		String name = item.getName();
		if (name != null && !name.equals("null"))
			return name;
		int notedId = item.getId();
		return tryGetNotedItemName(notedId);
	}

April 25, 201412 yr

Author

Have this snippet (working):

public static String tryGetNotedItemName(int notedId) {
		ItemDefinition def = ItemDefinition.forId(notedId - 1);
		if (def == null)
			return null;
		return def.getName();
	}

	public static String getItemNameNoted(Item item) {
		if (item == null)
			return null;
		String name = item.getName();
		if (name != null && !name.equals("null"))
			return name;
		int notedId = item.getId();
		return tryGetNotedItemName(notedId);
	}

That's a good workaround, but I still think they should fix the hook