Kenneh Posted March 26, 2014 Share Posted March 26, 2014 I just noticed in your example enum, you've capitalized Ten, but not the rest of the numbers. my OCD is killing me. Link to comment Share on other sites More sharing options...
Sigma Posted March 26, 2014 Share Posted March 26, 2014 Use the keyword this for get methods for consistency and redundancy, it makes it easier to see which variable you're actually accessing (I know most if not all IDE's will make sure they are the same color anyways). Link to comment Share on other sites More sharing options...
Joseph Posted March 26, 2014 Author Share Posted March 26, 2014 I just noticed in your example enum, you've capitalized Ten, but not the rest of the numbers. my OCD is killing me. Use the keyword this for get methods for consistency and redundancy, it makes it easier to see which variable you're actually accessing (I know most if not all IDE's will make sure they are the same color anyways). Lol I'll fix it when I get home Link to comment Share on other sites More sharing options...
Softarn Posted March 26, 2014 Share Posted March 26, 2014 Quick and easy! Thanks for this! Link to comment Share on other sites More sharing options...
Joseph Posted March 26, 2014 Author Share Posted March 26, 2014 Quick and easy! Thanks for this! There's more to come Link to comment Share on other sites More sharing options...
Pseudo Posted March 26, 2014 Share Posted March 26, 2014 public enum Number 1 Link to comment Share on other sites More sharing options...
Kenneh Posted March 26, 2014 Share Posted March 26, 2014 public enum Number Enums shouldn't be plural. Number.FIVE vs Numbers.FIVE Link to comment Share on other sites More sharing options...
Sigma Posted March 26, 2014 Share Posted March 26, 2014 (edited) Enums shouldn't be plural. Number.FIVE vs Numbers.FIVE This is only true if the fields inside the enum are not bit fields. Edited March 26, 2014 by Sigma Link to comment Share on other sites More sharing options...
Kenneh Posted March 26, 2014 Share Posted March 26, 2014 This is only true if the fields inside the enum are not bit fields. Plural enums really bother me. I just think they look weird. 1 Link to comment Share on other sites More sharing options...
Joseph Posted March 27, 2014 Author Share Posted March 27, 2014 (edited) Plural enums really bother me. I just think they look weird. public enum Number This is only true if the fields inside the enum are not bit fields. I understand where your coming from, but to have to redo all the picture because of one spelling is a bitch Edited March 27, 2014 by josedpay Link to comment Share on other sites More sharing options...
Kenneh Posted March 27, 2014 Share Posted March 27, 2014 I understand where your coming from, but to have to redo all the picture because of one spelling is a bitch does that look like a bit field to you? 1 Link to comment Share on other sites More sharing options...
Joseph Posted May 9, 2014 Author Share Posted May 9, 2014 (edited) Started working on this again. I removed the picture and added in the code. Easier for me to edit, rather then having to retype, edit, and upload the picture. Which was a hassle. Edited May 9, 2014 by josedpay Link to comment Share on other sites More sharing options...
Joseph Posted May 9, 2014 Author Share Posted May 9, 2014 Let me know how it looks Link to comment Share on other sites More sharing options...
Nezz Posted May 16, 2014 Share Posted May 16, 2014 It might be better if you used runescape related enums. Such as making an example Magic enum, and passing in the Spell.CAMELOT_TELEPORT or something into it. That way you can give scripters an area that they'll be able to see its usefulness, and easily integrate it into their scripts. Making an enum for Numbers isn't very useful at first glance. I realize it's an example, but if you put it into runescape terms people might understand how powerful enums can be. Link to comment Share on other sites More sharing options...
Joseph Posted May 16, 2014 Author Share Posted May 16, 2014 (edited) It might be better if you used runescape related enums. Such as making an example Magic enum, and passing in the Spell.CAMELOT_TELEPORT or something into it. That way you can give scripters an area that they'll be able to see its usefulness, and easily integrate it into their scripts. Making an enum for Numbers isn't very useful at first glance. I realize it's an example, but if you put it into runescape terms people might understand how powerful enums can be. lol alright, ill probably just leave the number enum. but add in a runescape section. Edited May 28, 2014 by josedpay Link to comment Share on other sites More sharing options...