client.getBank().isOpen() is returning true slightly early, to the point where if something is attempted on the bank as soon as it returns true, it will most likely fail because the bank interface is not yet open even though the method is returning true. As a work around I have had to rely on the bank interface being open and not on the isOpen() method.

 

Suggestion: Have isOpen() return true when the interface is actually visible.

You mean once the bot clicks the bank it returns true? If so just put it to sleep for like 750 then continue. Same goes for most interacting interfaces

You mean once the bot clicks the bank it returns true? If so just put it to sleep for like 750 then continue. Same goes for most interacting interfaces

 

 

Not once it clicks. Like right before the interface is actually visible. Static sleeping for 750ms is not efficient.

You mean once the bot clicks the bank it returns true? If so just put it to sleep for like 750 then continue. Same goes for most interacting interfaces

Could just sleep until it's visible.

Could just sleep until it's visible.

 

That is what I am doing, this is just a suggestion to get isOpen() to do the same.

sleep(random(1250,1500);

 

Try that. It does work or just condition is to sleep until it's visible like Erza just said

sleep(random(1250,1500);

 

Try that. It does work or just condition is to sleep until it's visible like Erza just said

 

 

Why the static sleeping?

while(!bank.isOpen) {

sleep(50);

}

while(!bank.isOpen) {
   sleep(50);
}

 

 

You seem to be misunderstanding the suggestion.

I'd rather support the fact that they make banking in general faster..

I'd rather support the fact that they make banking in general faster..

inb4 dev response is "OSBot 2 has faster banking"

@OP:

 

Yes, I agree that isOpen should only return true when the interfaces have loaded, causes a few problems in my script as well.

 

@Others:

 

You guys are missing the point. What you're proposing is that he change the timing of the check. Right now client.getBank().isOpen() is returning true too early (AKA when it's not true). So therefore the problem needs to be fixed because it's causing timing issues. Sleeping after every-time you check isn't going to fix his problem, just make it occur less often.

Current:

    public boolean isOpen() {
        RS2Interface i = client.getInterface(BANK_INTERFACE);
        if (i != null && i.isValid()) {
            return true;
        }
        return false;
    }

to

Proposed version: (note the isVisible)

    public boolean isOpen() {
        RS2Interface i = client.getInterface(BANK_INTERFACE);
        if (i != null && i.isValid() && i.isVisible()) {
            return true;
        }
        return false;
    }

Acceptable?

Current:

    public boolean isOpen() {
        RS2Interface i = client.getInterface(BANK_INTERFACE);
        if (i != null && i.isValid()) {
            return true;
        }
        return false;
    }

to

Proposed version: (note the isVisible)

    public boolean isOpen() {
        RS2Interface i = client.getInterface(BANK_INTERFACE);
        if (i != null && i.isValid() && i.isVisible()) {
            return true;
        }
        return false;
    }

Acceptable?

 

I'm not sure why you're using if statements though, lol.

Current:

    public boolean isOpen() {
        RS2Interface i = client.getInterface(BANK_INTERFACE);
        if (i != null && i.isValid()) {
            return true;
        }
        return false;
    }

to

Proposed version: (note the isVisible)

    public boolean isOpen() {
        RS2Interface i = client.getInterface(BANK_INTERFACE);
        if (i != null && i.isValid() && i.isVisible()) {
            return true;
        }
        return false;
    }

Acceptable?

 

public boolean isOpen() {
    RS2Interface i = client.getInterface(BANK_INTERFACE);
    return i != null && i.isValid() && i.isVisible();
}

@Swizzbeat4developer

 

I'm not to sure what the BANK_INTERFACE represents, but in my opinion it should also look for the child interface which contains the bank items to be visible as well. I think this is whats causing issues where the contains() method return false even though the items are there (parent interface being loaded but not all of the children are or visible yet).