Well, I'm thoroughly confused now, so, what's the actual bug o.O

 

Alright let me give you my example, maybe we clear out this fog

 

My script interacts with the NPC via "Attack", all is well. Whilst the NPC is dead there's a small timeframe where the NPC is visible but I'm NOT sure whether is null or not, the bot however always right click attacks when it's falling to the ground.

 

Like I said the fix to this is very simple, only attack is the HP is not equal to 0

Why don't you guys just use closestAttackableNPCForName()....

 

Works fine for me

 

Ah alright, wasn't aware of that method.. I should really just read through the whole API lol

Why don't you guys just use closestAttackableNPCForName()....

 

Works fine for me

Because some people like attacking the second closest, etc. so it's more random than attacking the nearest thing (imagine multi-combat zones with people floating towards the same NPCs).

Because some people like attacking the second closest, etc. so it's more random than attacking the nearest thing (imagine multi-combat zones with people floating towards the same NPCs).

Oh, I should have paid more attention to the List word in the methods they were using

public List<NPC> listAttackableNPCsForName(String name) {
	List<NPC> attackableList = null;
	NPC[] localNPCs = new NPC[client.getLocalNPCs().size()];
	for (int i = 0; i < client.getLocalNPCs().size(); i++) {
		if (localNPCs[i].getName().equalsIgnoreCase(name) && localNPCs[i].canAttack())
			attackableList.add(localNPCs[i]);
	}
	return attackableList;
}

Would work fine?

Edited March 2, 201412 yr by Swizzbeat

these happens to me all the time hope it's fixed

public List<NPC> listAttackableNPCsForName(String name) {
	List<NPC> attackableList = null;
	NPC[] localNPCs = new NPC[client.getLocalNPCs().size()];
	for (int i = 0; i < client.getLocalNPCs().size(); i++) {
		if (localNPCs[i].getName().equalsIgnoreCase(name) && localNPCs[i].canAttack())
			attackableList.add(localNPCs[i]);
	}
	return attackableList;
}

Would work fine?

 

That theoretically would work just fine

 

Oh, I should have paid more attention to the List word in the methods they were using

public List<NPC> listAttackableNPCsForName(String name) {
	List<NPC> attackableList = null;
	NPC[] localNPCs = new NPC[client.getLocalNPCs().size()];
	for (int i = 0; i < client.getLocalNPCs().size(); i++) {
		if (localNPCs[i].getName().equalsIgnoreCase(name) && localNPCs[i].canAttack())
			attackableList.add(localNPCs[i]);
	}
	return attackableList;
}

Would work fine?

 

Just a note, canAttack() won't work in multi-combat areas. The isAttackable() added in OSBot 2 will work fine though.

I would like to update that the run away from combat worked fine this time