Jump to content

Simple fly fisher (Barb village)


Imthabawse

Recommended Posts

1 minute ago, redeems said:

 private States currentState = States.FISHING; //setting starting state
    private Area area = new Area(3109, 3434, 3103, 3423); // fishing area
    public enum States {FISHING, DROPPING} //the two states

Yes, but when do you set the state back to FISHING once you've set it to DROPPING? You don't, so it will get stuck.

Link to comment
Share on other sites

 } else if (currentState == States.DROPPING) { //if the state is dropping...
                log("Inventory full dropping fish.."); //log that we are in this state and executing
                getInventory().dropAllExcept("Feather","Fly fishing rod"); //drop everything besides feathers and rod
            int openslots = (getInventory().getEmptySlotCount()); //variable for open inventory spots
            if (openslots == 26) {
                currentState = States.FISHING;
            } 
        }
    }

corrected. now it will go the distance.

  • Like 1
Link to comment
Share on other sites

7 minutes ago, Malcolm said:

This is still a boolean method and should be checked with an if statement.

instead of using a static sleep you could use a conditional sleep until the fishing spot is null or your inventory is full.

 

This is what I would do. Hopefully this is helpful.


        NPC fishSpot = getNpcs().closest("Rod Fishing spot");
        if (fishSpot.interact("Lure")) {
            getMouse().moveOutsideScreen();
            new ConditionalSleep(5000) {
                @Override
                public boolean condition() throws InterruptedException {
                    return getInventory().isFull() || fishSpot == null;
                }
            }.sleep();
        }

 

true. conditional sleeps are almost always better than static sleeps.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...