Jump to content

How to efficiently calculate the inventorys gp value?


Recommended Posts

Posted (edited)

http://osbot.org/forum/topic/102611-ge-data-get-price-etc-by-item-name-no-external-libraries-required/

 

 

private long getInventoryValue() {

      long value = 0;

     for(Item i: inventory.getAll()) {

           value += new ExchangeItem(i.getName(), i.getId()).getPrice();

      }

      return value;

}

       

Edited by Imateamcape
Posted

http://osbot.org/forum/topic/102611-ge-data-get-price-etc-by-item-name-no-external-libraries-required/

 

 

private long getInventoryValue() {

      long value = 0;

     for(Item i: inventory.getAll()) {

           value += new ExchangeItem(i.getName(), i.getId()).getPrice();

      }

      return value;

}

 

While you did provide the skeleton for doing this, it's important to note that you should cache the item value or something.

 

Firstly, it's not like the item's price will change that much over the course of the script running. Secondly and most importantly, you don't want to be bombarding their server with requests as well as stopping the thread from running until the page has loaded. Of course using asynch methods would be better for this.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...