Jump to content

Sigma

Trade With Caution
  • Posts

    61
  • Joined

  • Last visited

  • Feedback

    0%

Everything posted by Sigma

  1. The script manager saying you're all shitty, and the script manager's source code being ugly as all hell is enough reason to group you all like that. If you think otherwise, get your head on straight. If I saw your code, I'd bet you I'd want to facedesk just as hard as I did when I read some threads in the tutorials section. If you don't believe me, post some and I'll be happy to take a look in a non-biased manner.
  2. The method does not validate anything, it simply checks if the conditional statement inside returns true or false. You basically just countered yourself by posting the dictionary definition of the word. A correct method name would be shouldExecute or something of the like. Also if you want to get into technicalities, then the execute method should be named executeNode.
  3. Just from looking at your GUI's, you don't know how to use layout managers which you should be doing for something static like a script UI. You add poor anti-ban to you scripts which believe it or not negatively effect your users. Here's why: Traditional scripter implemented anti-ban looks something like this: public static void antiBan() { switch(random int 0-100) { case 0: //wiggle mouse; break; case 20: //wiggle camera; break; case 60: //check xp; case 70: //break; case 90: //examine object; break; } } This forms a considerably easy to detect pattern. Now, this isn't so bad if only a few people are using your scripts, but lets say for the sake of this example you have 500 users running this script with this anti-ban. All 500 people will have the same pattern: -wiggle mouse 1% of the time -wiggle camera 2% of the time -check xp 1% of the time -examine object 1% of the time As you can see, that hurts your users more than helping them. None of your code is actually open source so I'm not able to comment on it.
  4. I'm not allowed to do that in my current position. If you want to head over to another botting site you'll see that I've done just that.
  5. Simple pathfinding can solve that for you.
  6. You don't need web walking to do it, you just need to write a method to figure out the best method of travel to get to the destination. The only things you need to hardcode are the non-coordinate clue destinations. You shouldn't need any other data prior to picking up a clue.
  7. Yes, with any clue other than the riddle clues, you can parse the data and send it to a method to solve the clue without previously knowing what the clue was. Which is why I was asking why you were hard coding every one of them.
  8. You're collecting clue data, what else would you be doing with it other than hard coding?
  9. Omitting braces with only one line inside the statement is ok... but explain why you do that, otherwise people looking at the tutorial will be confused. Sometimes you did it with more than one line, though. I promise you that the walking method in the api does not recurse itself until the destination is reached, therefore you are able to easily fix it by doing what I stated above. Lastly, if this is a tutorial, make sure the code is presentable and functional with no logic errors or syntax errors. The entire point of a tutorial is to teach people how to code correctly.
  10. Why are you hard coding clues? That is the worst way to go about a clue scroll script.
  11. I'm almost positive each of the skills is an interface child, so no point in create rectangles. Also, take Toph's suggestion, as the random element of the anti-ban should be created by the person using this snippet.
  12. Combine some of your if statements, there's no reason not to.
  13. No, this pip provides no purpose. If you're adept at a language and post seldomly or often, people will recognize you for it regardless of whether or not you have a pip.
  14. No point in creating static variables that are not going to be used at the class level in any other classes, especially if they are inside a class that's parent is Script. Also, it's probably a good idea to be consistent with formatting, especially when making a tutorial (I am referring to your braces). It would be different if this was black box code, or something of the like. Your walking method looks to be written poorly with static sleeps not accounting for movements or lag. I don't know how the walk method inside the api works, but you're explanation of it "tending to click until it's at the destination" can easily be remedied by not calling the method over and over if the current game destination is the tile you wanted to walk to. Another thing, you may want to check if the object you're trying to click is on the screen before clicking it as that could cause problems. Lastly, you could be stuck in an infinite loop with that banking method you've written. Instead, why not use a conditional sleep that times out after x seconds if the clients open method returns true?
×
×
  • Create New...