I released a script a while back but as I'm not too familiar with Java and very new to bot scripting I'm looking for someone experienced to nitpick the fuck out of my code. It's functionally correct and works flawlessly (haven't run into a single bug in over 40+ hrs as of around 2 weeks ago but haven't ran it since I've been quite busy) but I'd like to get some general input on best practices. The thread describing the script is here.
As I'm semi attached to this script and plan on doing more work with it in the future I don't want to give out the source to just anyone so if you have one of them fancy scripter ranks and want to do a guy a favor come take a look at my code. I think the best way is to comment here or pm me and I'll send it on over. Pls no steal thx.
I was looking at this thread and was hoping someone could answer 2 questions about the free/VIP form
2) 180x180 logo (direct links only, puush not allowed):
Does it have to have a logo?
4) Link to script thread:
Is this the link to our post in the Official OSBot Scripts section? Before it's even accepted? Or is this a different script thread?
You read correctly. Should I make it togglable?
I'll add that to the list of things to do. I currently have that in another script I made so it'll probably be an easy change
What
Picks bananas on Karamja and fills baskets to make baskets of bananas worth ~400gp often closer to 500.
Uses Glories to to teleport to Karmaja and dueling ring to bank at Castle Wars.
Why
No requirements
140K/HR (was getting more last week but haven't used it recently so unsure about prices. Could be more! - EDIT: after running it today was getting 180K+)
Setup
Start at CW
Have baskets in the bank
Have charged glories in the bank
Have dueling rings in the bank
Be wearing a glory or no amulet
Be wearing a dueling ring or no ring
Note
Has weird anti-ban like adding random people as friends
No paint but will add in the future if people are interested
Taking ideas for future scripts
Give me feedback pls
TODO
Fix anti-ban if people feel strongly about it
Add paint
Auto sell bananas and buy glories/dueling rings when out
DOWNLOAD
Sorry if this is a stupid question, I'm new to writing bots. What's the proper way to use the return value of something like
bank.withdraw(x, 1);
is something like this safe or is there some convention?
while (!bank.withdraw(x, 1)) {
sleep(random(100, 500));
}