User

I'd go with KFC / Burger King (called Hungry Jack's here) - I used to love Subway, but when I tried it again a few times recently, it just didn't taste as good as I remember. Big reason for Hungry Jack's would be the onion rings and free unlimited refills on drinks (fuck yeah). McDonalds is just bad (but cheap I guess).

Entity food = client.getInventory().getItemForName(FOOD.Shark.toString()); Will work out, if you wish to keep your current form, but you shouldn't! Your conventions are whack, and if the specific food item has a space in it's name, you're going to run into a little trouble. I'm in a bit of a rush, but I'll leave this here: // enumeration declaration public enum Food { SHARK(1234); private final int id; Food(final int id) { this.id = id; } public int getId() { return id; } } // usage // NOTE - IT MAY NOT BE 'getItemForId', I wouldn't know - I haven't looked at OSBOT since the first/second release Entity food = client.getInventory().getItemForId(Food.SHARK.getId());

More like "as seen in multiple tutorials in 2008". Really OP, you should transform this into something useful, like a toolkit. The code itself is rather novice-ish, so it should be a good challenge for you... The toolkit widgets would of course be standalone... I'm getting a bit ahead of myself here, but you could eventually bridge information dynamically obtained from the client to extent the capabilities of said widgets, and eventually transmute it into a macro.... Maybe make that a (very) long-term goal? There will be plenty of rewrites inbetween lol. TL;DR - Make into toolkit. No. You're missing the point. I just wanted something to play on and not worry about advertisments in the client ( I don't have members ) So you don't plan on working on the code at all, but you're asking for feedback? Seems pretty pointless to me. There are quite a few alternatives in which would have allowed you to play the game without advertisements, in which would have required much less time... Like just downloading one of the other thousands of OSRS loaders floating around the web?

More like "as seen in multiple tutorials in 2008". Really OP, you should transform this into something useful, like a toolkit. The code itself is rather novice-ish, so it should be a good challenge for you... The toolkit widgets would of course be standalone... I'm getting a bit ahead of myself here, but you could eventually bridge information dynamically obtained from the client to extent the capabilities of said widgets, and eventually transmute it into a macro.... Maybe make that a (very) long-term goal? There will be plenty of rewrites inbetween lol. TL;DR - Make into toolkit.

/* * Initializes Nagle's algorithm. */ socket.setTcpNoDelay(true); Disables Nagle's algorithm - it doesn't enable it as you've stated in the documentation. Maybe read up on things like this as you're writing the code? Or did you just C+P this from another RSPS? This kind of ties in with the statement below: Stop with the useless documentation - documenting what you write is great, sure, but documenting self-explanatory statements is just a waste of time. A random example of this, taken from the code you've written, is: /* * While the application is active the thread will be cycled. */ while (isRunning) { Also, you really need to keep consistent in your style. For example, half the time you appear to be using 4 spaces, and half the time a hard TAB. It's a good idea to stick to 4 spaces - as the TAB character may be 4, 8, or anything really, spaces, depending on the environment. Also, the game runs on a 600 millisecond cycle, not a 500 millisecond one. Were you referencing a server from 2005 or something? Good luck with the server, btw - there isn't really much to look at, at the moment, though, so pointing out problems is a little difficult. Edit: This link may also prove useful to you.

I'm calling you out on this one... The company in which you have stated does not exist, the web site of the project your email is set to is unregistered, and the image in which you have posted of a 'model your team has made' is not yours.