Error in script onStart(): Freaky Fast Abyss

[elliottdehn]

[iNFO][bot #1][04/27 07:07:43 PM]: Error in script onStart(): Freaky Fast Abyss

[iNFO][bot #1][04/27 07:07:43 PM]: Started script : Freaky Fast Abyss

 

onstart: http://pastebin.com/HcsdKrQH

ActivityInBank: http://pastebin.com/4hS2MQFf

ActivityOutOfBank: http://pastebin.com/WaHyzwvy

Node: http://pastebin.com/u8LZunsF

Data.Constants:

 

package Data;

public class Constants {

    public int BANK_ID = 11744;

    public int UNNOTE_ESS = 7937;

    public int NOTE_ESS = 7936;

    public String BANK_OPTION = "Bank";

}

 

Example inbanksubactivity: http://pastebin.com/ez8d6UAZ (they all follow the same format)

 

 

anyone any have clue of what could be going on? extra pastes on request

Thanks!!

[elliottdehn]

I've narrowed the issue down to it trying to add the node, not even bothering starting to read the constructor, and just exiting script.

 

 

edit: further narrowed it down to it getting to "constructing inbank node" in:

package osbotOS;

 

import org.osbot.rs07.script.Script;

 

import Data.Constants;

 

public abstract class Node {

 

    public Script script;

    public Constants c = new Constants();

 

    public Node(Script script) {

 

        this.script = script;

        this.script.log("constructing inbank node");

    }

 

    public abstract void execute();

 

    public abstract boolean validate();

 

}

 

but then not getting to "got here" in

 

    public ActivityInBank(Script script, Constants c) {

 

        super(script);

        this.script.log("got here");

        this.c = c;

 

        this.needToWithdrawFood = this.validateFood();

        this.needToWithdrawGlory = this.validateGlory();

        this.needToWithdrawPrayer = this.validatePrayer();

        this.needToWithdrawRunes = this.validateRunes();

        this.needToWithdrawTabs = this.validateTabs();

        this.needToWithdrawStam = this.validateStam();

 

        // TODO Auto-generated constructor stub

    }

 

Edited April 28, 2015 by elliottdehn

[fixthissite]

What exception is being thrown? Please post the stack trace

[elliottdehn]

czar fixed it for me. I needed to move the Collection.addAll to the constructors of the objects.

[lare96]

A little off topic but just a tip: constants are static and final.