Jump to content

Tanner & Crafter


liverare

Recommended Posts

I just bought your script and it doesn't work with Banking to make Green dragonhide items.. I wasted my money yet again.

 

This may a problem in mirror mode, because mirror mode is still in beta.

 

However, only convention banks (e.g., bank booths) are supported. The newer stuff like the Grand Exchange is not currently supported. This is because I wrote my own banking method that would only interact with the nearby banks that are either directly in front/behind/at our sides, so our bot doesn't keep switching between bank booths. Try run the script standing at in front of a conventional bank booth.

 

I have ran the script and found no problems using conventional banks. But again, I will extend the range so all banks are supported.

My bot doesn't have the paint showing, any advice would be much appreciated?

 

The script paint will not display if user input is enabled, this is because I have personally found paints to be in the way when I want to take temporary control over my bot. But also, if paint is not enabled, the paint can still be hidden if you click on the chat box. Simply re-click there to reveal the paint.

 

Please let me know if it continues to be a problem. smile.png

Edited by liverare
Link to comment
Share on other sites

 

 

 

 

Bugreport:

 

Client mode: 

Mirror and normal mode 

 

Method:

Tanning green hides

 

Bugs: 

 

- No paint

- slow in general this includes trading, banking, walking!

- often gets stuck behinde the tanning shop as it missclicks and then does not know where to walk

 

what should be added?

- anti ban with randomness walking and camera movement 

- fail safe if it walks wrong and gets stuck

- speed improvement 

 

Console output

 

 
[DEBUG][05/01 01:02:39 PM]: Loading script id : 547
[DEBUG][05/01 01:02:40 PM]: Loaded script!
[DEBUG][05/01 01:02:40 PM]: Launching script...
[iNFO][bot #1][05/01 01:02:40 PM]: Loaded 1 built-in random solvers!
[iNFO][bot #1][05/01 01:02:40 PM]: Error in script onStart(): Tanner & Crafter
[iNFO][05/01 01:02:40 PM]: Started script : Tanner & Crafter
[iNFO][bot #1][05/01 01:02:46 PM]: Tanning Green dragonhides
[ERROR][bot #1][05/01 01:02:46 PM]: Error in script executor!
java.lang.NullPointerException
at javax.swing.ImageIcon.<init>(Unknown Source)
at com.liverare.scripts.tanner_and_crafter.Main.onLoop(zb:234)
at org.osbot.rs07.event.ScriptExecutor$InternalExecutor.run(qj:191)
at java.lang.Thread.run(Unknown Source)
[iNFO][bot #1][05/01 01:09:25 PM]: Script Tanner & Crafter has paused!
[WARN][bot #1][05/01 01:09:30 PM]: Event executor is taking too long to suspend; terminating now...
[iNFO][bot #1][05/01 01:09:31 PM]: Script Tanner & Crafter has resumed!
 

Link to comment
Share on other sites

 

Bugreport:

 

Client mode: 

Mirror and normal mode 

 

Method:

Tanning green hides

 

Bugs: 

 

- No paint

- slow in general this includes trading, banking, walking!

- often gets stuck behinde the tanning shop as it missclicks and then does not know where to walk

 

what should be added?

- anti ban with randomness walking and camera movement 

- fail safe if it walks wrong and gets stuck

- speed improvement 

 

Console output

 

 
[DEBUG][05/01 01:02:39 PM]: Loading script id : 547
[DEBUG][05/01 01:02:40 PM]: Loaded script!
[DEBUG][05/01 01:02:40 PM]: Launching script...
[iNFO][bot #1][05/01 01:02:40 PM]: Loaded 1 built-in random solvers!
[iNFO][bot #1][05/01 01:02:40 PM]: Error in script onStart(): Tanner & Crafter
[iNFO][05/01 01:02:40 PM]: Started script : Tanner & Crafter
[iNFO][bot #1][05/01 01:02:46 PM]: Tanning Green dragonhides
[ERROR][bot #1][05/01 01:02:46 PM]: Error in script executor!
java.lang.NullPointerException
at javax.swing.ImageIcon.<init>(Unknown Source)
at com.liverare.scripts.tanner_and_crafter.Main.onLoop(zb:234)
at org.osbot.rs07.event.ScriptExecutor$InternalExecutor.run(qj:191)
at java.lang.Thread.run(Unknown Source)
[iNFO][bot #1][05/01 01:09:25 PM]: Script Tanner & Crafter has paused!
[WARN][bot #1][05/01 01:09:30 PM]: Event executor is taking too long to suspend; terminating now...
[iNFO][bot #1][05/01 01:09:31 PM]: Script Tanner & Crafter has resumed!
 

 

Thank you for the report. I'm looking into this now.

 

- No paint

This error relates to the console output you posted (Thanks!). I've added the assets for this script into the /resources/ folder which (I believe) is where it's supposed to be in order for it to load with the script.

 

Hopefully this will be fixed in the next build. smile.png

 

- slow in general this includes trading, banking, walking!

The bot can't even open the bank in Mirror Mode, and that's using OSBot's own banking API. I am going to get in touch with a few other scripters/developers to see if there's any progress with solving this problem, otherwise I will create my own to replace it.

 

As for 'slow in general', I will look into the current speed of the script and see if the rate can be increased without increasing ban rate/potential for problems.

 

- often gets stuck behinde the tanning shop as it missclicks and then does not know where to walk

Solved. I've added massive area range around the store. tongue.png

 

- anti ban with randomness walking and camera movementI

I could implement this, but it won't really be of much use. These kinds of antiban behaviours are feel good antibans, which is already handled with OSBot's default anti-ban.

 

- fail safe if it walks wrong and gets stuck

I will also look into adding anti-ban for the furnace building and kebab shop for additional fail-safe.

Edited by liverare
  • Like 1
Link to comment
Share on other sites

When will this be fixed, I will be writing a complaint and getting my money back if not fixed, thanks.

Banking at any bank isn't working

 

The banking issue is only occurring in Mirror Mode and I have reported the issue here. But you're not even a VIP so you cannot use Mirror Mode.

 

(Note: MGI has informed me that this error is a result of hooking the bot to a RS client whilst already being logged in.)

 

This is the banking method being used:

 

public boolean tryOpenNearbyBank() throws InterruptedException {
			boolean b = script.getBank().open();
			if (!b) {
				RS2Object bank = objects.getNearestBank();
				if (bank == null) {
					b = script.getBank().open();
				} else {
					b = bank.interact("Bank", "Use");
				}
			}
			return b;
		}

If at all the script cannot find a valid bank booth, it will attempt to use OSBot's banking API as a failsafe mechanism.

Edited by liverare
Link to comment
Share on other sites

Runs awesome since the last update.

I found a very small bug:

 

-It sometimes (very rare) missclicks and opens the collectionbox instead of the bank forcing the script to idel.

 

Maybe you can solve this by adding some kind of fail safe like " if idel 3mins click ..."

or you could add if collection box is open close or something

 

I will provide you the console output if it happens again.

 

All in all, great script thank you ^_^

  • Like 1
Link to comment
Share on other sites

Runs awesome since the last update.

I found a very small bug:

 

-It sometimes (very rare) missclicks and opens the collectionbox instead of the bank forcing the script to idel.

 

Maybe you can solve this by adding some kind of fail safe like " if idel 3mins click ..."

or you could add if collection box is open close or something

 

I will provide you the console output if it happens again.

 

All in all, great script thank you happy.png

Thanks for the report! I will fix this hopefully tomorrow, but I am preparing for a demonstration and presentation I have to deliver on Thursday, which is more important. But I will get around to it!

  • Like 1
Link to comment
Share on other sites

Guest
This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...