is it just me or is this method broken for anything i do, it keeps returning false.

 

im using it like this

if (trapDoor.getDefinition().getActions().equals("Open"))	{
	log("door is closed");
}else{
	log("door is open");
}

im tried 

• .equals("open") all lower case
• .equals("open ") all lower case with a space after the action name 
• .equals("Open") first letter capitalize
• .equals("Open ") first letter capitalize with a space after the action name

 

You have to loop through all the actions

		for (String action : trapDoor.getDefinition().getActions())
			if (action.equals("Open"))
				log("Open");
			else
				log("Closed")

 

You have to loop through all the actions

		for (String action : trapDoor.getDefinition().getActions())
			if (action.equals("Open"))
				log("Open");
			else
				log("Closed")

 

 

thats a lie because i use this method.

	boolean isTrapDoorClosed()	{
		if (trapDoor!=null)	{
			for (String actions: trapDoor.getDefinition().getActions())	{
				if (actions!=null && actions.contains("open"))	{
					return true;
				}
                else if (actions!=null && actions.contains("climb-down"))	{
                	return false;
                }
			}
		}
		return false;
	}

 and i use it this way

					if (trapDoor!=null)	{
						if (trapDoor.isVisible())	{
							if (this.isDoorClosed())	{
								log("door is closed");

							}else{
								log("door is open");
							}
						}else{
							client.moveCameraToEntity(trapDoor);
							sleep(1000);
						}
					}

Edited September 29, 201312 yr by josedpay

 

Arrays.asList() is a pretty neat thing.

You have to loop through all the actions

for (String action : trapDoor.getDefinition().getActions())			if (action.equals("Open"))				log("Open");			else				log("Closed")

thats a lie because i use this method.

boolean isTrapDoorClosed()	{		if (trapDoor!=null)	{			for (String actions: trapDoor.getDefinition().getActions())	{				if (actions!=null && actions.contains("open"))	{					return true;				}                else if (actions!=null && actions.contains("climb-down"))	{                	return false;                }			}		}		return false;	}

and i use it this way

if (trapDoor!=null)	{						if (trapDoor.isVisible())	{							if (this.isDoorClosed())	{								log("door is closed");							}else{								log("door is open");							}						}else{							client.moveCameraToEntity(trapDoor);							sleep(1000);						}					}

You do realize that you are looping through the actions in this method, right?

ya im looping throught the action, but it never changes boolean. So i just decided to change it from getAction(). to getVerticalCount()

You have to loop through all the actions

		for (String action : trapDoor.getDefinition().getActions())
			if (action.equals("Open"))
				log("Open");
			else
				log("Closed")

Apparently we are not supposed to use for loops in osbot scripts but conditional sleeping instead.

ya im looping throught the action, but it never changes boolean. So i just decided to change it from getAction(). to getVerticalCount()

 

All you had to do is this..

 

if (Arrays.asList(trapDoor.getDefinition().getActions()).contains("Open"))    {
        log("door is closed");
     }else {
        log("door is open");
    }