GetFirstBankItem

[TheScrub]

this method is useful for stuff like withdrawing ring of duelings so u can have an array of strings and it will search the bank and find the first one if not it will find the second third fourth fifth etc... or potions

    private String getBankItem(String items[]) {
        String item;
        if (client.getBank().isOpen()) {
            Item[] bankitems = client.getBank().getItems();
            if (items.length > 0 && items != null) {
                for (String correctItem : items) {
                    for (int i = 0; i < bankitems.length; i++) {
                        if (bankitems[i].getName().contains(correctItem)) {
                            item = correctItem;
                            return item;
                        }
                    }
                }
            }
        }
        return null;
    }

Edited September 5, 2013 by TheScrub

[Neodork]

That's a nice snippet.. There is no need for 2 loops though, OSBot already has a method which searches for the item name:

bank.getItemForName();  

So I formatted a bit, other than that I like it and was already using something similar.

private String getBankItem(String ...itemNames) {
	Bank bank = this.client.getBank();
        if(!client.getBank().isOpen() || itemNames == null || itemNames.length < 0) {
              return null;
        }
        
        for(String name:itemNames){
        	Item selectedItem = bank.getItemForName(name);
        	if(selectedItem !=null){
        		return name;
        	}
        }
        
        return null;
    } 

Edited September 5, 2013 by Neodork

[TheScrub]

 

That's a nice snippet.. There is no need for 2 loops though, OSBot already has a method which searches for the item name:

bank.getItemForName();  

So I formatted a bit, other than that I like it and was already using something similar.

private String getBankItem(String ...itemNames) {
	Bank bank = this.client.getBank();
        if(!client.getBank().isOpen() || itemNames == null || itemNames.length < 0) {
              return null;
        }
        
        for(String name:itemNames){
        	Item selectedItem = bank.getItemForName(name);
        	if(selectedItem !=null){
        		return name;
        	}
        }
        
        return null;
    } 

thanks i didn't know they updated the bank api to get item by name if you check my older snippets... thanks though!