Need some help with my deposit code

[atoo]

this is my deposit code when @bank, it deposit's my dragon axe too

worked like 2 days ago but now i dont fkn know.

getBank().depositAllExcept(item -> item.getName().contains("axe"));

Edited January 18, 2017 by atoo

[Sysm]

  if (this.bank.isOpen()) {
                    this.bank.depositAllExcept("Bronze axe", "Iron axe", "Steel axe", "Black axe", "Mithril axe", "Adamant axe", "Rune axe", "Dragon axe");
                    

Havent tested it so not sure if it woks, but it should  

[aeondenied]

xd

Edited January 18, 2017 by aeondenied

[atoo]

  if (this.bank.isOpen()) {
                    this.bank.depositAllExcept("Bronze axe", "Iron axe", "Steel axe", "Black axe", "Mithril axe", "Adamant axe", "Rune axe", "Dragon axe");
                    

Havent tested it so not sure if it woks, but it should  

 

I wrote that too, but i just thought if we include "axe" it wouldnt deposit it.

Thanks though

[Sysm]

I wrote that too, but i just thought if we include "axe" it wouldnt deposit it.

Thanks though

think it looks for a item "axe" instead of looking for a item containing the word i always type it out and that work so may aswell

[Hayase]

Strange if it worked before and suddenly stops working. Also not too important in this situation but I think using .contains() could be bad practice if you were dealing with strings that used other words with the sequence "axe" but were not axes. Again there's no case in this situation but if you were dealing with axel logs, .endsWith() would be better in this case since we know our axes  always ends with "axe"

 

 

Edited January 18, 2017 by Hayase

[DocMatson]

best thing to do is make a constant that lists your axe names.

public static final String AXES = ("Bronze axe", "Iron axe", "Steel axe", "Black axe", "Mithril axe", "Adamant axe", "Rune axe", "Dragon axe");

if (this.bank.isOpen()) {
                    this.bank.depositAllExcept(AXES);

This will always call the list of axes (which i doubt will ever change) this is a helpful technique and makes the code much more readable and modular.

Edited January 18, 2017 by DocMatson

[atoo]

best thing to do is make a constant that lists your axe names.

public static final String AXES = ("Bronze axe", "Iron axe", "Steel axe", "Black axe", "Mithril axe", "Adamant axe", "Rune axe", "Dragon axe");

if (this.bank.isOpen()) {
                    this.bank.depositAllExcept(AXES);

This will always call the list of axes (which i doubt will ever change) this is a helpful technique and makes the code much more readable and modular.

Thanks mate

I always code messy lol, this will help a bit.

[Explv]

 

this is my deposit code when @bank, it deposit's my dragon axe too

worked like 2 days ago but now i dont fkn know.

getBank().depositAllExcept(item -> item.getName().contains("axe"));

getBank().depositAllExcept(item -> item.getName().endsWith(" axe"));