Jump to content

Team Cape

Members
  • Posts

    2607
  • Joined

  • Last visited

  • Days Won

    1
  • Feedback

    100%

Posts posted by Team Cape

  1. So, a few problems. I'll go in order of least important to most important:

    (1) Your code is prone to null pointer exceptions:

    CT.contains(SC) && SC != null

    Switch this to check if the object is null first. You should do this for all of your code. 

    (2)

          (a) The sand crab is quite possibly also not in range. If you're not currently fighting the sand crab, somebody else probably is. How far away are the sand crabs you're trying to interact with? My guess is that they're reasonably far, or not easily visible.

           (b) Similarly, Sand crabs aren't actually NPCs until you turn them agro by standing beside them. You'll only attack a sand crab if it's already up and around.

    (3) You sleep for up to an entire minute in between even checking the actions, totally tossing aside actually doing them.

    return random(3000, 60000);

    Make this wayyyy less. There are very few scenarios where it would actually make sense to have a gap this big, and this is not one of them.

    (4) Please look into a state-based system. There are quite a few tutorials on it in the tutorials section. It'll make the code a lot easier to follow when you/others debug. Similarly, revise your variable names if you want others to be able to read your code. I don't know what CT, RSA, or BT are. 

     

    Side note: This should reset agro anytime there isn't an active sand crab around you, given you have >= 35% HP, and have Salmon/are in some area CT. 

    • Like 1
  2. 14 hours ago, Tom moose said:

    Just looking at yor scrift looks pretty decent, i've currently have another scripters script but it doesn't support a function that i want. Does yours support the Hardwood Grove tree location wth teaks and Mahoganies which you need to pay 100 trading sticks to get into, and bank with The Tai Bwo Wannai Parcel Service, run by Rionasta?

    If you're looking to powerchop in the area, or there's no major barrier (e.g. paying 100 trading sticks) between the bank and the chopping area, then it is equipped to handle that! :) 

    • Like 1
  3. Definitely not the SDN for a few reasons.

    1) SDN code is all heavily reviewed before it even touches the SDN.

    2) Scripters have a lot to lose by even trying to put something like that into their scripts, and with the code reviews after every update, they would not be successful.

    3) Developers and those who review the code have even more to lose than scripters.

    4) If any of the above people really wanted to hack somebody, they would go for one of the numerous goldfarmers that use the OSBot client and regularly have thousands in OSGP on their accounts, not one random person.

     

    It's much, much more likely that you accidentally downloaded a keylogger or clicked on a phishing link. Be careful!

  4. 18 minutes ago, cooldoruk60 said:

    Just looking at it though, you can kind of see that it's having something go wrong with the code. It's got that vibration kind of look if you know what I mean. Possibly some sort of exception

    What does this mean..?

    Also, just a note, for every single item, you press shift, rapidly drop it, then unshift. You do the same thing 28 times, each in the span of less than 50ms. 

  5. On 8/18/2018 at 1:36 AM, RSOS said:

    Is there a specific setting in the GUI that I need to check so that the script does random mouse or camera movement so that I stay logged in?  I'm chopping Yews but it logs me out after a short while of afk chopping.

    Strange, I'll look into this. Thanks for reporting that! :D 

×
×
  • Create New...