The method "depositAllExcept(java.lang.String... excludedItems)" from the Bank class seems to not work properly. It deposits all the item your inventory including the excluded item.

client.getBank().depositAllExcept("Thread", "Needle", "Item im crafting");  Still works in my script. It does fail sometimes, so I have a check to make sure it worked and I will just recall it till it deposits them all, but I haven't noticed a problem with it depositing the items I told it. I have had someone else report this happeneing with my script but I have done 5k+ crafts without it depositing the thread or needle.

 

Edited June 30, 201312 yr by Deck

client.getBank().depositAllExcept("Thread", "Needle", "Item im crafting");  Still works in my script. It does fail sometimes, so I have a check to make sure it worked and I will just recall it till it deposits them all, but I haven't noticed a problem with it depositing the items I told it. I have had someone else report this happeneing with my script but I have done 5k+ crafts without it depositing the thread or needle.

I am starting to notice it sometimes deposits all and sometimes deposits all but the excluded.

Just wondering, are you trying to close the bank using client.getBank().close();  then clicking the items it is not supposed to deposit? I had to write my own close bank method, because it would sometimes fail and then the client.getBank().isOpen(); would tell me the bank was closed. so it would click the thread and needle depositing them. I haven't tried the banks close method in about a week so it may be fixed, but I know I was having trouble with stuff getting deposited till I wrote my own method to close the bank.

Just wondering, are you trying to close the bank using client.getBank().close();  then clicking the items it is not supposed to deposit? I had to write my own close bank method, because it would sometimes fail and then the client.getBank().isOpen(); would tell me the bank was closed. so it would click the thread and needle depositing them. I haven't tried the banks close method in about a week so it may be fixed, but I know I was having trouble with stuff getting deposited till I wrote my own method to close the bank.

I use close() after I am done depositing and withdrawing. close() seems to work fine for me.

thats bad

Just curious to when this will be fixed...

 

Any updates on this admins?

You can easily create your own method.

 

 

 

 

 

People using my scripts are reporting the same thing.Sometimes it works and sometimes it doesn't.

You can easily create your own method.

I know you can, but a broken method in the API is just ugly.

 

People using my scripts are reporting the same thing.Sometimes it works and sometimes it doesn't.

I hope @Laz gets to this.

client.getBank().depositAllExcept("Thread", "Needle", "Item im crafting");  Still works in my script. It does fail sometimes, so I have a check to make sure it worked and I will just recall it till it deposits them all, but I haven't noticed a problem with it depositing the items I told it. I have had someone else report this happeneing with my script but I have done 5k+ crafts without it depositing the thread or needle.

Yeah same here for a few of mine. It seems to only happen when you use multiple items. I also used a simple failsafe to withdraw the items that are needed if they aren't in the inventory.

My banking method right now is about 100 lines long. I loaded it with failsafes, now my script runs foreverr.