Would it not be better if the NPC and Object Definition class's both implemented an interface named Definition, which means getDefinition() could then be applied to the entity class? as it would be easier to do something like:

private boolean hasAction(Entity entity, String action) {
	Definition i = entity.getDefinition();
	for(String a : i.getActions()) {
		if(action.equals(a))
			return true;
	}
	return false;
}

than to do

private boolean hasAction(NPC npc, String action) {
	NPCDefinition i = npc.getDefinition();
	return hasAction(i.getActions());
}

private boolean hasAction(RS2Object object, String action) {
	ObjectDefinition i = object.getDefinition();
	return hasAction(i.getActions());
}

private boolean hasAction(String[] actions) {
	for(String a : actions) {
		if(actions.equals(a))
			return true;
	}
	return false;
}

Just a thought.

Edited June 19, 201312 yr by Cory

Yes it would be pretty smart. The only issue is with Item Definitions which has getActions() as well as getGroundActions().

Yes it would be pretty smart. The only issue is with Item Definitions which has getActions() as well as getGroundActions().

 

I don't see the issue here...?

 

Example:

public interface Definition {
	String[] getActions();
}

public class ItemDefinition implements Definition {
	String[] getActions() {
		//...
	}
	
	String[] getGroundActions() {
		//...
	}
}

public class ObjectDefinition implements Definition {
	String[] getActions() {
		//...
	}
}

public class NPCDefition implements Definition {
	String[] getActions() {
		//...
	}
}